X-Git-Url: https://git.gag.com/?a=blobdiff_plain;f=server-src%2Fchunker.c;h=6f81ad2b1cd9ef12cfdcf24ee2d156a3fde131cb;hb=d28952249e392eb31bc8eecc53f6c477f30c617b;hp=5e6c1ef45c7619ec9bb761fe871494d8714a5e5f;hpb=fb2bd066c2f8b34addafe48d62550e3033a59431;p=debian%2Famanda diff --git a/server-src/chunker.c b/server-src/chunker.c index 5e6c1ef..6f81ad2 100644 --- a/server-src/chunker.c +++ b/server-src/chunker.c @@ -1,6 +1,7 @@ /* * Amanda, The Advanced Maryland Automatic Network Disk Archiver * Copyright (c) 1991-1999 University of Maryland at College Park + * Copyright (c) 2007-2012 Zmanda, Inc. All Rights Reserved. * All Rights Reserved. * * Permission to use, copy, modify, distribute, and sell this software and its @@ -37,20 +38,13 @@ #include "protocol.h" #include "security.h" #include "stream.h" -#include "token.h" -#include "version.h" #include "fileheader.h" #include "amfeatures.h" #include "server_util.h" #include "util.h" #include "holding.h" #include "timestamp.h" - -#define chunker_debug(i, ...) do { \ - if ((i) <= debug_chunker) { \ - dbprintf(__VA_ARGS__); \ - } \ -} while (0) +#include "sockaddr-util.h" #ifndef SEEK_SET #define SEEK_SET 0 @@ -93,7 +87,7 @@ static char *options = NULL; static char *progname = NULL; static int level; static char *dumpdate = NULL; -static int command_in_transit; +static struct cmdargs *command_in_transit = NULL; static char *chunker_timestamp = NULL; static dumpfile_t file; @@ -104,9 +98,14 @@ static ssize_t write_tapeheader(int, dumpfile_t *); static void databuf_init(struct databuf *, int, char *, off_t, off_t); static int databuf_flush(struct databuf *); -static int startup_chunker(char *, off_t, off_t, struct databuf *); -static int do_chunk(int, struct databuf *); +static int startup_chunker(char *, off_t, off_t, struct databuf *, int *, int *); +static int do_chunk(int, struct databuf *, int, int); +/* we use a function pointer for full_write, so that we can "shim" in + * full_write_with_fake_enospc for testing */ +static size_t (*db_full_write)(int fd, const void *buf, size_t count); +static size_t full_write_with_fake_enospc(int fd, const void *buf, size_t count); +static off_t fake_enospc_at_byte = -1; int main( @@ -114,18 +113,19 @@ main( char ** argv) { static struct databuf db; - struct cmdargs cmdargs; - cmd_t cmd; - int infd; + struct cmdargs *cmdargs; + int header_fd; char *q = NULL; char *filename = NULL; - char *qfilename = NULL; off_t chunksize, use; times_t runtime; am_feature_t *their_features = NULL; int a; - config_overwrites_t *cfg_ovr = NULL; + config_overrides_t *cfg_ovr = NULL; char *cfg_opt = NULL; + char *m; + int header_socket; + int data_socket; /* * Configure program for internationalization: @@ -145,28 +145,35 @@ main( /* Don't die when child closes pipe */ signal(SIGPIPE, SIG_IGN); - erroutput_type = (ERR_AMANDALOG|ERR_INTERACTIVE); - set_logerror(logerror); + add_amanda_log_handler(amanda_log_stderr); + add_amanda_log_handler(amanda_log_trace_log); - cfg_ovr = extract_commandline_config_overwrites(&argc, &argv); + cfg_ovr = extract_commandline_config_overrides(&argc, &argv); if (argc > 1) cfg_opt = argv[1]; - config_init(CONFIG_INIT_EXPLICIT_NAME | CONFIG_INIT_USE_CWD | CONFIG_INIT_FATAL, - cfg_opt); - apply_config_overwrites(cfg_ovr); + set_config_overrides(cfg_ovr); + config_init(CONFIG_INIT_EXPLICIT_NAME | CONFIG_INIT_USE_CWD, cfg_opt); + + if (config_errors(NULL) >= CFGERR_WARNINGS) { + config_print_errors(); + if (config_errors(NULL) >= CFGERR_ERRORS) { + g_critical(_("errors processing config file")); + } + } safe_cd(); /* do this *after* config_init() */ check_running_as(RUNNING_AS_DUMPUSER); - dbrename(config_name, DBG_SUBDIR_SERVER); + dbrename(get_config_name(), DBG_SUBDIR_SERVER); + log_add(L_INFO, "%s pid %ld", get_pname(), (long)getpid()); g_fprintf(stderr, _("%s: pid %ld executable %s version %s\n"), get_pname(), (long) getpid(), - argv[0], version()); + argv[0], VERSION); fflush(stderr); /* now, make sure we are a valid user */ @@ -174,20 +181,33 @@ main( signal(SIGPIPE, SIG_IGN); signal(SIGCHLD, SIG_IGN); - cmd = getcmd(&cmdargs); - if(cmd == START) { - if(cmdargs.argc <= 1) + cmdargs = getcmd(); + if(cmdargs->cmd == START) { + if(cmdargs->argc <= 1) error(_("error [dumper START: not enough args: timestamp]")); - chunker_timestamp = newstralloc(chunker_timestamp, cmdargs.argv[2]); + chunker_timestamp = newstralloc(chunker_timestamp, cmdargs->argv[1]); } else { + log_add(L_INFO, "%s pid %ld", get_pname(), (long)getpid()); error(_("Didn't get START command")); } + free_cmdargs(cmdargs); + + /* set up a fake ENOSPC for testing purposes. Note that this counts + * headers as well as data written to disk. */ + if (getenv("CHUNKER_FAKE_ENOSPC_AT")) { + char *env = getenv("CHUNKER_FAKE_ENOSPC_AT"); + fake_enospc_at_byte = (off_t)atoi(env); /* these values are never > MAXINT */ + db_full_write = full_write_with_fake_enospc; + g_debug("will trigger fake ENOSPC at byte %d", (int)fake_enospc_at_byte); + } else { + db_full_write = full_write; + } /* do {*/ - cmd = getcmd(&cmdargs); + cmdargs = getcmd(); - switch(cmd) { + switch(cmdargs->cmd) { case QUIT: break; @@ -206,97 +226,97 @@ main( * use * options */ - cmdargs.argc++; /* true count of args */ - a = 2; + a = 1; - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: handle]")); /*NOTREACHED*/ } - handle = newstralloc(handle, cmdargs.argv[a++]); + handle = newstralloc(handle, cmdargs->argv[a++]); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: filename]")); /*NOTREACHED*/ } - qfilename = newstralloc(qfilename, cmdargs.argv[a++]); - if (filename != NULL) - amfree(filename); - filename = unquote_string(qfilename); - amfree(qfilename); + filename = newstralloc(filename, cmdargs->argv[a++]); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: hostname]")); /*NOTREACHED*/ } - hostname = newstralloc(hostname, cmdargs.argv[a++]); + hostname = newstralloc(hostname, cmdargs->argv[a++]); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: features]")); /*NOTREACHED*/ } am_release_feature_set(their_features); - their_features = am_string_to_feature(cmdargs.argv[a++]); + their_features = am_string_to_feature(cmdargs->argv[a++]); + if (!their_features) { + error(_("error [chunker PORT-WRITE: invalid feature string]")); + /*NOTREACHED*/ + } - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: diskname]")); /*NOTREACHED*/ } - qdiskname = newstralloc(qdiskname, cmdargs.argv[a++]); - if (diskname != NULL) - amfree(diskname); - diskname = unquote_string(qdiskname); + diskname = newstralloc(diskname, cmdargs->argv[a++]); + if (qdiskname) + amfree(qdiskname); + qdiskname = quote_string(diskname); /* qdiskname is a global */ - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: level]")); /*NOTREACHED*/ } - level = atoi(cmdargs.argv[a++]); + level = atoi(cmdargs->argv[a++]); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: dumpdate]")); /*NOTREACHED*/ } - dumpdate = newstralloc(dumpdate, cmdargs.argv[a++]); + dumpdate = newstralloc(dumpdate, cmdargs->argv[a++]); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: chunksize]")); /*NOTREACHED*/ } - chunksize = OFF_T_ATOI(cmdargs.argv[a++]); + chunksize = OFF_T_ATOI(cmdargs->argv[a++]); chunksize = am_floor(chunksize, (off_t)DISK_BLOCK_KB); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: progname]")); /*NOTREACHED*/ } - progname = newstralloc(progname, cmdargs.argv[a++]); + progname = newstralloc(progname, cmdargs->argv[a++]); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: use]")); /*NOTREACHED*/ } - use = am_floor(OFF_T_ATOI(cmdargs.argv[a++]), DISK_BLOCK_KB); + use = am_floor(OFF_T_ATOI(cmdargs->argv[a++]), DISK_BLOCK_KB); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker PORT-WRITE: not enough args: options]")); /*NOTREACHED*/ } - options = newstralloc(options, cmdargs.argv[a++]); + options = newstralloc(options, cmdargs->argv[a++]); - if(a != cmdargs.argc) { + if(a != cmdargs->argc) { error(_("error [chunker PORT-WRITE: too many args: %d != %d]"), - cmdargs.argc, a); + cmdargs->argc, a); /*NOTREACHED*/ } - if((infd = startup_chunker(filename, use, chunksize, &db)) < 0) { - q = squotef(_("[chunker startup failed: %s]"), errstr); + if ((header_fd = startup_chunker(filename, use, chunksize, &db, + &header_socket, &data_socket)) < 0) { + q = quote_string(vstrallocf(_("[chunker startup failed: %s]"), errstr)); putresult(TRYAGAIN, "%s %s\n", handle, q); - error("startup_chunker failed"); + error("startup_chunker failed: %s", errstr); } - command_in_transit = -1; - if(infd >= 0 && do_chunk(infd, &db)) { + command_in_transit = NULL; + if (header_fd >= 0 && do_chunk(header_fd, &db, header_socket, data_socket)) { char kb_str[NUM_STR_SIZE]; char kps_str[NUM_STR_SIZE]; double rt; @@ -309,12 +329,17 @@ main( isnormal(rt) ? (double)dumpsize / rt : 0.0); errstr = newvstrallocf(errstr, "sec %s kb %s kps %s", walltime_str(runtime), kb_str, kps_str); - q = squotef("[%s]", errstr); - if(command_in_transit != -1) - cmd = command_in_transit; - else - cmd = getcmd(&cmdargs); - switch(cmd) { + m = vstrallocf("[%s]", errstr); + q = quote_string(m); + amfree(m); + free_cmdargs(cmdargs); + if(command_in_transit != NULL) { + cmdargs = command_in_transit; + command_in_transit = NULL; + } else { + cmdargs = getcmd(); + } + switch(cmdargs->cmd) { case DONE: putresult(DONE, "%s %lld %s\n", handle, (long long)(dumpsize - (off_t)headersize), q); @@ -334,9 +359,11 @@ main( } else { errstr = newvstrallocf(errstr, - _("dumper returned %s"), cmdstr[cmd]); + _("dumper returned %s"), cmdstr[cmdargs->cmd]); amfree(q); - q = squotef("[%s]",errstr); + m = vstrallocf("[%s]",errstr); + q = quote_string(m); + amfree(m); putresult(FAILED, "%s %s\n", handle, q); log_add(L_FAIL, "%s %s %s %d [%s]", hostname, qdiskname, chunker_timestamp, level, errstr); @@ -344,26 +371,26 @@ main( default: break; } amfree(q); - } else if(infd != -2) { + } else if (header_fd != -2) { + if(q == NULL) { + m = vstrallocf("[%s]", errstr); + q = quote_string(m); + amfree(m); + } if(!abort_pending) { - if(q == NULL) { - q = squotef("[%s]", errstr); - } putresult(FAILED, "%s %s\n", handle, q); - log_add(L_FAIL, "%s %s %s %d [%s]", - hostname, qdiskname, chunker_timestamp, level, errstr); - amfree(q); } + log_add(L_FAIL, "%s %s %s %d [%s]", + hostname, qdiskname, chunker_timestamp, level, errstr); + amfree(q); } amfree(filename); amfree(db.filename); break; default: - if(cmdargs.argc >= 1) { - q = squote(cmdargs.argv[1]); - } else if(cmdargs.argc >= 0) { - q = squote(cmdargs.argv[0]); + if(cmdargs->argc >= 1) { + q = quote_string(cmdargs->argv[0]); } else { q = stralloc(_("(no input?)")); } @@ -372,7 +399,9 @@ main( break; } -/* } while(cmd != QUIT); */ +/* } while(cmdargs->cmd != QUIT); */ + + log_add(L_INFO, "pid-done %ld", (long)getpid()); amfree(errstr); amfree(chunker_timestamp); @@ -383,6 +412,9 @@ main( amfree(dumpdate); amfree(progname); amfree(options); + free_cmdargs(cmdargs); + if (command_in_transit) + free_cmdargs(command_in_transit); am_release_feature_set(their_features); their_features = NULL; @@ -400,50 +432,90 @@ startup_chunker( char * filename, off_t use, off_t chunksize, - struct databuf * db) + struct databuf * db, + int *headersocket, + int *datasocket) { - int infd, outfd; + int header_fd, outfd; char *tmp_filename, *pc; - in_port_t data_port; - int data_socket; + in_port_t header_port, data_port; + int header_socket, data_socket; int result; struct addrinfo *res; + struct addrinfo *res_addr; + sockaddr_union *addr = NULL; + sockaddr_union data_addr; + header_port = 0; data_port = 0; if ((result = resolve_hostname("localhost", 0, &res, NULL) != 0)) { errstr = newvstrallocf(errstr, _("could not resolve localhost: %s"), gai_strerror(result)); return -1; } - data_socket = stream_server(res->ai_family, &data_port, 0, + for (res_addr = res; res_addr != NULL; res_addr = res_addr->ai_next) { + g_debug("ra: %s\n", str_sockaddr((sockaddr_union*)res_addr->ai_addr)); + if (res_addr->ai_family == AF_INET) { + addr = (sockaddr_union *)res_addr->ai_addr; + break; + } + } + if (!addr) { + addr = (sockaddr_union *)res->ai_addr; + g_debug("addr: %s\n", str_sockaddr(addr)); + } + + header_socket = stream_server(SU_GET_FAMILY(addr), &header_port, 0, + STREAM_BUFSIZE, 0); + data_socket = stream_server(SU_GET_FAMILY(addr), &data_port, 0, STREAM_BUFSIZE, 0); + copy_sockaddr(&data_addr, addr); + + SU_SET_PORT(&data_addr, data_port); + + if (res) freeaddrinfo(res); + + if (header_socket < 0) { + errstr = vstrallocf(_("error creating header stream server: %s"), strerror(errno)); + aclose(data_socket); + return -1; + } - if(data_socket < 0) { - errstr = vstrallocf(_("error creating stream server: %s"), strerror(errno)); + if (data_socket < 0) { + errstr = vstrallocf(_("error creating data stream server: %s"), strerror(errno)); + aclose(header_socket); return -1; } - putresult(PORT, "%d\n", data_port); + putresult(PORT, "%d %s\n", header_port, str_sockaddr(&data_addr)); - infd = stream_accept(data_socket, CONNECT_TIMEOUT, 0, STREAM_BUFSIZE); - if(infd == -1) { - errstr = vstrallocf(_("error accepting stream: %s"), strerror(errno)); + header_fd = stream_accept(header_socket, CONNECT_TIMEOUT, 0, + STREAM_BUFSIZE); + if (header_fd == -1) { + errstr = vstrallocf(_("error accepting header stream: %s"), + strerror(errno)); + aclose(header_socket); + aclose(data_socket); return -1; } tmp_filename = vstralloc(filename, ".tmp", NULL); pc = strrchr(tmp_filename, '/'); + g_assert(pc != NULL); *pc = '\0'; mkholdingdir(tmp_filename); *pc = '/'; if ((outfd = open(tmp_filename, O_RDWR|O_CREAT|O_TRUNC, 0600)) < 0) { int save_errno = errno; - - errstr = squotef(_("holding file \"%s\": %s"), + char *m = vstrallocf(_("holding file \"%s\": %s"), tmp_filename, strerror(errno)); + + errstr = quote_string(m); + amfree(m); amfree(tmp_filename); - aclose(infd); + aclose(header_fd); + aclose(data_socket); if(save_errno == ENOSPC) { putresult(NO_ROOM, "%s %lld\n", handle, (long long)use); @@ -455,15 +527,20 @@ startup_chunker( amfree(tmp_filename); databuf_init(db, outfd, filename, use, chunksize); db->filename_seq++; - return infd; + *headersocket = header_socket; + *datasocket = data_socket; + return header_fd; } static int do_chunk( - int infd, - struct databuf * db) + int header_fd, + struct databuf * db, + int header_socket, + int data_socket) { - ssize_t nread; + size_t nread; + int data_fd; char header_buf[DISK_BLOCK_BYTES]; startclock(); @@ -477,48 +554,66 @@ do_chunk( * need to save into "file", as well as write out. Later, the * chunk code will rewrite it. */ - nread = fullread(infd, header_buf, SIZEOF(header_buf)); - if (nread != DISK_BLOCK_BYTES) { - if(nread < 0) { + nread = full_read(header_fd, header_buf, SIZEOF(header_buf)); + aclose(header_fd); + aclose(header_socket); + if (nread != sizeof(header_buf)) { + if(errno != 0) { errstr = vstrallocf(_("cannot read header: %s"), strerror(errno)); } else { - errstr = vstrallocf(_("cannot read header: got %zd bytes instead of %d"), - nread, - DISK_BLOCK_BYTES); + errstr = vstrallocf(_("cannot read header: got %zd bytes instead of %zd"), + nread, sizeof(header_buf)); } + aclose(data_socket); return 0; } parse_file_header(header_buf, &file, (size_t)nread); if(write_tapeheader(db->fd, &file)) { int save_errno = errno; - - errstr = squotef(_("write_tapeheader file %s: %s"), + char *m = vstrallocf(_("write_tapeheader file %s: %s"), db->filename, strerror(errno)); + errstr = quote_string(m); + amfree(m); if(save_errno == ENOSPC) { putresult(NO_ROOM, "%s %lld\n", handle, (long long)(db->use+db->split_size-dumpsize)); } + aclose(data_socket); return 0; } dumpsize += (off_t)DISK_BLOCK_KB; filesize = (off_t)DISK_BLOCK_KB; headersize += DISK_BLOCK_KB; + /* open the data socket */ + data_fd = stream_accept(data_socket, CONNECT_TIMEOUT, 0, STREAM_BUFSIZE); + + if (data_fd == -1) { + errstr = vstrallocf(_("error accepting data stream: %s"), + strerror(errno)); + aclose(data_socket); + return 0; + } + /* * We've written the file header. Now, just write data until the * end. */ - while ((nread = fullread(infd, db->buf, + while ((nread = full_read(data_fd, db->buf, (size_t)(db->datalimit - db->datain))) > 0) { db->datain += nread; while(db->dataout < db->datain) { if(!databuf_flush(db)) { + aclose(data_fd); + aclose(data_socket); return 0; } } } while(db->dataout < db->datain) { if(!databuf_flush(db)) { + aclose(data_fd); + aclose(data_socket); return 0; } } @@ -526,6 +621,8 @@ do_chunk( dumpsize += (off_t)1; /* count partial final KByte */ filesize += (off_t)1; } + aclose(data_fd); + aclose(data_socket); return 1; } @@ -558,12 +655,12 @@ static int databuf_flush( struct databuf * db) { - struct cmdargs cmdargs; + struct cmdargs *cmdargs = NULL; int rc = 1; - ssize_t written; + size_t size_to_write; + size_t written; off_t left_in_chunk; char *arg_filename = NULL; - char *qarg_filename = NULL; char *new_filename = NULL; char *tmp_filename = NULL; char sequence[NUM_STR_SIZE]; @@ -588,16 +685,14 @@ databuf_flush( /* * Probably no more space on this disk. Request some more. */ - cmd_t cmd; - putresult(RQ_MORE_DISK, "%s\n", handle); - cmd = getcmd(&cmdargs); - if(command_in_transit == -1 && - (cmd == DONE || cmd == TRYAGAIN || cmd == FAILED)) { - command_in_transit = cmd; - cmd = getcmd(&cmdargs); + cmdargs = getcmd(); + if(command_in_transit == NULL && + (cmdargs->cmd == DONE || cmdargs->cmd == TRYAGAIN || cmdargs->cmd == FAILED)) { + command_in_transit = cmdargs; + cmdargs = getcmd(); } - if(cmd == CONTINUE) { + if(cmdargs->cmd == CONTINUE) { /* * CONTINUE * serial @@ -605,34 +700,30 @@ databuf_flush( * chunksize * use */ - cmdargs.argc++; /* true count of args */ - a = 3; + a = 2; /* skip CONTINUE and serial */ - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker CONTINUE: not enough args: filename]")); /*NOTREACHED*/ } - qarg_filename = newstralloc(qarg_filename, cmdargs.argv[a++]); - if (arg_filename != NULL) - amfree(arg_filename); - arg_filename = unquote_string(qarg_filename); + arg_filename = newstralloc(arg_filename, cmdargs->argv[a++]); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker CONTINUE: not enough args: chunksize]")); /*NOTREACHED*/ } - db->chunk_size = OFF_T_ATOI(cmdargs.argv[a++]); + db->chunk_size = OFF_T_ATOI(cmdargs->argv[a++]); db->chunk_size = am_floor(db->chunk_size, (off_t)DISK_BLOCK_KB); - if(a >= cmdargs.argc) { + if(a >= cmdargs->argc) { error(_("error [chunker CONTINUE: not enough args: use]")); /*NOTREACHED*/ } - db->use = OFF_T_ATOI(cmdargs.argv[a++]); + db->use = OFF_T_ATOI(cmdargs->argv[a++]); - if(a != cmdargs.argc) { + if(a != cmdargs->argc) { error(_("error [chunker CONTINUE: too many args: %d != %d]"), - cmdargs.argc, a); + cmdargs->argc, a); /*NOTREACHED*/ } @@ -662,17 +753,15 @@ databuf_flush( */ db->filename = newstralloc(db->filename, arg_filename); } - } else if(cmd == ABORT) { + } else if(cmdargs->cmd == ABORT) { abort_pending = 1; - errstr = newstralloc(errstr, "ERROR"); + errstr = newstralloc(errstr, cmdargs->argv[1]); putresult(ABORT_FINISHED, "%s\n", handle); rc = 0; goto common_exit; } else { - if(cmdargs.argc >= 1) { - q = squote(cmdargs.argv[1]); - } else if(cmdargs.argc >= 0) { - q = squote(cmdargs.argv[0]); + if(cmdargs->argc >= 1) { + q = quote_string(cmdargs->argv[0]); } else { q = stralloc(_("(no input?)")); } @@ -700,12 +789,14 @@ databuf_flush( ".tmp", NULL); pc = strrchr(tmp_filename, '/'); + g_assert(pc != NULL); /* Only a problem if db->filename has no /. */ *pc = '\0'; mkholdingdir(tmp_filename); *pc = '/'; newfd = open(tmp_filename, O_RDWR|O_CREAT|O_TRUNC, 0600); if (newfd == -1) { int save_errno = errno; + char *m; if(save_errno == ENOSPC) { putresult(NO_ROOM, "%s %lld\n", handle, @@ -714,9 +805,11 @@ databuf_flush( db->split_size = dumpsize; continue; } - errstr = squotef(_("creating chunk holding file \"%s\": %s"), + m = vstrallocf(_("creating chunk holding file \"%s\": %s"), tmp_filename, strerror(errno)); + errstr = quote_string(m); + amfree(m); aclose(db->fd); rc = 0; goto common_exit; @@ -726,18 +819,25 @@ databuf_flush( file.cont_filename[0] = '\0'; if(write_tapeheader(newfd, &file)) { int save_errno = errno; + char *m; aclose(newfd); if(save_errno == ENOSPC) { + if (unlink(tmp_filename) < 0) { + g_debug("could not delete '%s'; ignoring", tmp_filename); + } putresult(NO_ROOM, "%s %lld\n", handle, (long long)(db->use+db->split_size-dumpsize)); db->use = (off_t)0; /* force RQ_MORE DISK */ db->split_size = dumpsize; + file.type = save_type; continue; } - errstr = squotef(_("write_tapeheader file %s: %s"), + m = vstrallocf(_("write_tapeheader file %s: %s"), tmp_filename, strerror(errno)); + errstr = quote_string(m); + amfree(m); rc = 0; goto common_exit; } @@ -747,9 +847,11 @@ databuf_flush( * to the next chunk, and then close it. */ if (lseek(db->fd, (off_t)0, SEEK_SET) < (off_t)0) { - errstr = squotef(_("lseek holding file %s: %s"), + char *m = vstrallocf(_("lseek holding file %s: %s"), db->filename, strerror(errno)); + errstr = quote_string(m); + amfree(m); aclose(newfd); rc = 0; goto common_exit; @@ -759,9 +861,11 @@ databuf_flush( strncpy(file.cont_filename, new_filename, SIZEOF(file.cont_filename)); file.cont_filename[SIZEOF(file.cont_filename)-1] = '\0'; if(write_tapeheader(db->fd, &file)) { - errstr = squotef(_("write_tapeheader file \"%s\": %s"), + char * m = vstrallocf(_("write_tapeheader file \"%s\": %s"), db->filename, strerror(errno)); + errstr = quote_string(m); + amfree(m); aclose(newfd); unlink(tmp_filename); rc = 0; @@ -806,8 +910,8 @@ databuf_flush( /* * Write out the buffer */ - written = fullwrite(db->fd, db->dataout, - (size_t)(db->datain - db->dataout)); + size_to_write = (size_t)(db->datain - db->dataout); + written = db_full_write(db->fd, db->dataout, size_to_write); if (written > 0) { db->dataout += written; dumpbytes += (off_t)written; @@ -815,9 +919,11 @@ databuf_flush( dumpsize += (dumpbytes / (off_t)1024); filesize += (dumpbytes / (off_t)1024); dumpbytes %= 1024; - if (written < 0) { + if (written < size_to_write) { if (errno != ENOSPC) { - errstr = squotef(_("data write: %s"), strerror(errno)); + char *m = vstrallocf(_("data write: %s"), strerror(errno)); + errstr = quote_string(m); + amfree(m); rc = 0; goto common_exit; } @@ -841,10 +947,11 @@ databuf_flush( common_exit: + if (cmdargs) + free_cmdargs(cmdargs); amfree(new_filename); /*@i@*/ amfree(tmp_filename); amfree(arg_filename); - amfree(qarg_filename); return rc; } @@ -858,15 +965,60 @@ write_tapeheader( dumpfile_t *file) { char *buffer; - ssize_t written; + size_t written; file->blocksize = DISK_BLOCK_BYTES; - buffer = build_header(file, DISK_BLOCK_BYTES); + if (debug_chunker > 1) + dump_dumpfile_t(file); + buffer = build_header(file, NULL, DISK_BLOCK_BYTES); + if (!buffer) /* this shouldn't happen */ + error(_("header does not fit in %zd bytes"), (size_t)DISK_BLOCK_BYTES); - written = fullwrite(outfd, buffer, DISK_BLOCK_BYTES); + written = db_full_write(outfd, buffer, DISK_BLOCK_BYTES); amfree(buffer); if(written == DISK_BLOCK_BYTES) return 0; - if(written < 0) return written; - errno = ENOSPC; + + /* fake ENOSPC when we get a short write without errno set */ + if(errno == 0) + errno = ENOSPC; + return (ssize_t)-1; } + +static size_t +full_write_with_fake_enospc( + int fd, + const void *buf, + size_t count) +{ + size_t rc; + + //g_debug("HERE %zd %zd", count, (size_t)fake_enospc_at_byte); + + if (count <= (size_t)fake_enospc_at_byte) { + fake_enospc_at_byte -= count; + return full_write(fd, buf, count); + } + + /* if we get here, the caller has requested a size that is less + * than fake_enospc_at_byte. */ + count = fake_enospc_at_byte; + g_debug("returning fake ENOSPC"); + + if (fake_enospc_at_byte) { + rc = full_write(fd, buf, fake_enospc_at_byte); + if (rc == (size_t)fake_enospc_at_byte) { + /* full_write succeeded, so fake a failure */ + errno = ENOSPC; + } + } else { + /* no bytes to write; just fake an error */ + errno = ENOSPC; + rc = 0; + } + + /* switch back to calling full_write directly */ + fake_enospc_at_byte = -1; + db_full_write = full_write; + return rc; +}