X-Git-Url: https://git.gag.com/?a=blobdiff_plain;f=flash%2Fmain.c;h=a74525a5a300f87354b1b51812393093582bb6af;hb=42d2da531f52ead18091a1211a5e6206e27dc178;hp=791b0730b90dee0c0f906184601d59edc6db758d;hpb=ffe5d1f31a80c6d889fed923e8c374a1aa079176;p=fw%2Fstlink

diff --git a/flash/main.c b/flash/main.c
index 791b073..a74525a 100644
--- a/flash/main.c
+++ b/flash/main.c
@@ -1,5 +1,7 @@
 /* simple wrapper around the stlink_flash_write function */
 
+// TODO - this should be done as just a simple flag to the st-util command line...
+
 
 #include <stdio.h>
 #include <stdlib.h>
@@ -17,6 +19,11 @@ struct opts
   size_t size;
 };
 
+static void usage(void)
+{
+    puts("stlinkv1 command line: ./flash {read|write} /dev/sgX path addr <size>");
+    puts("stlinkv2 command line: ./flash {read|write} path addr <size>");
+}
 
 static int get_opts(struct opts* o, int ac, char** av)
 {
@@ -48,7 +55,7 @@ static int get_opts(struct opts* o, int ac, char** av)
     o->do_read = 0;
 
     /* stlinkv1 mode */
-    if (ac == 5)
+    if (ac == 4)
     {
       o->devname = av[1];
       i = 1;
@@ -75,28 +82,32 @@ int main(int ac, char** av)
   if (get_opts(&o, ac - 1, av + 1) == -1)
   {
     printf("invalid command line\n");
+    usage();
     goto on_error;
   }
 
   if (o.devname != NULL) /* stlinkv1 */
   {
     static const int scsi_verbose = 2;
-    sl = stlink_quirk_open(o.devname, scsi_verbose);
+    sl = stlink_v1_open(o.devname, scsi_verbose);
+    if (sl == NULL) goto on_error;
   }
   else /* stlinkv2 */
   {
-    sl = stlink_open_usb(NULL, 10);
+    sl = stlink_open_usb(10);
+    if (sl == NULL) goto on_error;
   }
 
-  if (sl == NULL) goto on_error;
+  if (stlink_current_mode(sl) == STLINK_DEV_DFU_MODE)
+    stlink_exit_dfu_mode(sl);
 
-  if (o.do_read == 0) /* write */
-  {
-    if (stlink_current_mode(sl) == STLINK_DEV_DFU_MODE)
-      stlink_exit_dfu_mode(sl);
+  if (stlink_current_mode(sl) != STLINK_DEV_DEBUG_MODE)
     stlink_enter_swd_mode(sl);
-    stlink_reset(sl);
 
+  stlink_reset(sl);
+
+  if (o.do_read == 0) /* write */
+  {
     err = stlink_fwrite_flash(sl, o.filename, o.addr);
     if (err == -1)
     {