X-Git-Url: https://git.gag.com/?a=blobdiff_plain;f=common-src%2Fpipespawn.c;h=28f342bdc18f5a6e7564bde5a9a1f016c11018fc;hb=79cdc4b6ea8848b21ba4a0e7d2fd3bc401e0bebe;hp=a56a1d48d92c605a5b25c45de03e7d24e76043d5;hpb=cdbbeef9cde260e429854dd313bc0bf7560e1e24;p=debian%2Famanda

diff --git a/common-src/pipespawn.c b/common-src/pipespawn.c
index a56a1d4..28f342b 100644
--- a/common-src/pipespawn.c
+++ b/common-src/pipespawn.c
@@ -6,7 +6,7 @@
 
 char skip_argument[1];
 
-pid_t pipespawnv_passwd(char *prog, int pipedef,
+pid_t pipespawnv_passwd(char *prog, int pipedef, int need_root,
                   int *stdinfd, int *stdoutfd, int *stderrfd,
                   char **my_argv);
 
@@ -19,6 +19,7 @@ pid_t
 pipespawn(
     char *	prog,
     int		pipedef,
+    int         need_root,
     int *	stdinfd,
     int *	stdoutfd,
     int *	stderrfd,
@@ -49,7 +50,8 @@ pipespawn(
     }
     arglist_end(ap);
 
-    pid = pipespawnv_passwd(prog, pipedef, stdinfd, stdoutfd, stderrfd, argv);
+    pid = pipespawnv_passwd(prog, pipedef, need_root,
+			    stdinfd, stdoutfd, stderrfd, argv);
     amfree(argv);
     return pid;
 }
@@ -58,12 +60,14 @@ pid_t
 pipespawnv(
     char *	prog,
     int		pipedef,
+    int		need_root,
     int *	stdinfd,
     int *	stdoutfd,
     int *	stderrfd,
     char **	my_argv)
 {
-    return pipespawnv_passwd(prog, pipedef, stdinfd, stdoutfd, stderrfd,
+    return pipespawnv_passwd(prog, pipedef, need_root,
+			     stdinfd, stdoutfd, stderrfd,
 	my_argv);
 }
 
@@ -71,6 +75,7 @@ pid_t
 pipespawnv_passwd(
     char *	prog,
     int		pipedef,
+    int		need_root,
     int *	stdinfd,
     int *	stdoutfd,
     int *	stderrfd,
@@ -83,6 +88,8 @@ pipespawnv_passwd(
     char **arg;
     char *e;
     char **env;
+    char *cmdline;
+    char *quoted;
     char **newenv;
     char *passwdvar = NULL;
     int  *passwdfd = NULL;
@@ -90,53 +97,52 @@ pipespawnv_passwd(
     /*
      * Log the command line and count the args.
      */
-    dbprintf(("%s: spawning %s in pipeline\n", debug_prefix_time(NULL), prog));
-    dbprintf(("%s: argument list:", debug_prefix(NULL)));
     if ((pipedef & PASSWD_PIPE) != 0) {
 	passwdvar = *my_argv++;
 	passwdfd  = (int *)*my_argv++;
     }
+    g_debug("pipespawnv: stdoutfd is %d", *stdoutfd);
     memset(inpipe, -1, SIZEOF(inpipe));
     memset(outpipe, -1, SIZEOF(outpipe));
     memset(errpipe, -1, SIZEOF(errpipe));
     memset(passwdpipe, -1, SIZEOF(passwdpipe));
     argc = 0;
-    for(arg = my_argv; *arg != NULL; arg++) {
-	char *quoted;
 
+    cmdline = stralloc(prog);
+    for(arg = my_argv; *arg != NULL; arg++) {
 	if (*arg != skip_argument) {
 	    argc++;
 	    quoted = quote_string(*arg);
-	    dbprintf((" %s", quoted));
+	    cmdline = vstrextend(&cmdline, " ", quoted, NULL);
 	    amfree(quoted);
 	}
     }
-    dbprintf(("\n"));
+    dbprintf(_("Spawning \"%s\" in pipeline\n"), cmdline);
 
     /*
      * Create the pipes
      */
     if ((pipedef & STDIN_PIPE) != 0) {
 	if(pipe(inpipe) == -1) {
-	    error("error [open pipe to %s: %s]", prog, strerror(errno));
+	    error(_("error [open pipe to %s: %s]"), prog, strerror(errno));
 	    /*NOTREACHED*/
 	}
     }
     if ((pipedef & STDOUT_PIPE) != 0) {
 	if(pipe(outpipe) == -1) {
-	    error("error [open pipe to %s: %s]", prog, strerror(errno));
+	    error(_("error [open pipe to %s: %s]"), prog, strerror(errno));
 	    /*NOTREACHED*/
 	}
     }
     if ((pipedef & STDERR_PIPE) != 0) {
 	if(pipe(errpipe) == -1) {
-	    error("error [open pipe to %s: %s]", prog, strerror(errno));
+	    error(_("error [open pipe to %s: %s]"), prog, strerror(errno));
 	    /*NOTREACHED*/
 	}
     }
     if ((pipedef & PASSWD_PIPE) != 0) {
 	if(pipe(passwdpipe) == -1) {
-	    error("error [open pipe to %s: %s]", prog, strerror(errno));
+	    error(_("error [open pipe to %s: %s]"), prog, strerror(errno));
 	    /*NOTREACHED*/
 	}
     }
@@ -147,7 +153,7 @@ pipespawnv_passwd(
     switch(pid = fork()) {
     case -1:
 	e = strerror(errno);
-	error("error [fork %s: %s]", prog, e);
+	error(_("error [fork %s: %s]"), prog, e);
 	/*NOTREACHED*/
 
     default:	/* parent process */
@@ -192,15 +198,15 @@ pipespawnv_passwd(
 	 * Shift the pipes to the standard file descriptors as requested.
 	 */
 	if(dup2(inpipe[0], 0) == -1) {
-	    error("error [spawn %s: dup2 in: %s]", prog, strerror(errno));
+	    error(_("error [spawn %s: dup2 in: %s]"), prog, strerror(errno));
 	    /*NOTREACHED*/
 	}
 	if(dup2(outpipe[1], 1) == -1) {
-	    error("error [spawn %s: dup2 out: %s]", prog, strerror(errno));
+	    error(_("error [spawn %s: dup2 out: %s]"), prog, strerror(errno));
 	    /*NOTREACHED*/
 	}
 	if(dup2(errpipe[1], 2) == -1) {
-	    error("error [spawn %s: dup2 err: %s]", prog, strerror(errno));
+	    error(_("error [spawn %s: dup2 err: %s]"), prog, strerror(errno));
 	    /*NOTREACHED*/
 	}
 
@@ -213,19 +219,25 @@ pipespawnv_passwd(
 	    for (i = 0; env[i] != NULL; i++)
 		(void)i; /* make lint happy and do nothing */	
 	    newenv = (char **)alloc((i + 1 + 1) * SIZEOF(*newenv));
-	    snprintf(number, SIZEOF(number), "%d", passwdpipe[0]);
+	    g_snprintf(number, SIZEOF(number), "%d", passwdpipe[0]);
 	    newenv[0] = vstralloc(passwdvar, "=", number, NULL);
 	    for(i = 0; env[i] != NULL; i++)
 	    	newenv[i + 1] = env[i];
 	    newenv[i + 1] = NULL;
 	    amfree(env);
 	    env = newenv;
+	    safe_fd(passwdpipe[0], 1);
+	} else {
+	    safe_fd(-1, 0);
 	}
 
+	if (need_root)
+	    become_root();
 	execve(prog, my_argv, env);
 	e = strerror(errno);
-	error("error [exec %s: %s]", prog, e);
+	error(_("error [exec %s: %s]"), prog, e);
 	/*NOTREACHED*/
     }
+    amfree(cmdline);
     return pid;
 }