X-Git-Url: https://git.gag.com/?a=blobdiff_plain;f=altosui%2FAltosSerial.java;h=111bd77170fc5514107c4ef75f0ca050a84c4a9a;hb=a9dae18a664f70b668159487015e61be7f776926;hp=88b38bb176f01ad00db321de36fb698d2c14019c;hpb=97517ee585462c2d355f23f999fb8d9ebd908ec1;p=fw%2Faltos

diff --git a/altosui/AltosSerial.java b/altosui/AltosSerial.java
index 88b38bb1..111bd771 100644
--- a/altosui/AltosSerial.java
+++ b/altosui/AltosSerial.java
@@ -137,18 +137,19 @@ public class AltosSerial implements Runnable {
 	boolean	timeout_started = false;
 
 	private void stop_timeout_dialog() {
-		System.out.printf("stop_timeout_dialog\n");
-		Runnable r = new Runnable() {
-				public void run() {
-					if (timeout_dialog != null)
+		if (timeout_started) {
+			timeout_started = false;
+			Runnable r = new Runnable() {
+					public void run() {
 						timeout_dialog.setVisible(false);
-				}
-			};
-		SwingUtilities.invokeLater(r);
+					}
+				};
+			SwingUtilities.invokeLater(r);
+		}
 	}
 
 	private void start_timeout_dialog_internal() {
-		System.out.printf("Creating timeout dialog\n");
+
 		Object[] options = { "Cancel" };
 
 		JOptionPane	pane = new JOptionPane();
@@ -165,15 +166,14 @@ public class AltosSerial implements Runnable {
 			return;
 		if (options[0].equals(o))
 			abort = true;
+		timeout_dialog.dispose();
+		timeout_dialog = null;
 	}
 
 	private boolean check_timeout() {
 		if (!timeout_started && frame != null) {
-			timeout_started = true;
-			System.out.printf("Starting timeout dialog\n");
-			if (SwingUtilities.isEventDispatchThread()) {
-				start_timeout_dialog_internal();
-			} else {
+			if (!SwingUtilities.isEventDispatchThread()) {
+				timeout_started = true;
 				Runnable r = new Runnable() {
 						public void run() {
 							start_timeout_dialog_internal();
@@ -191,7 +191,7 @@ public class AltosSerial implements Runnable {
 
 		int timeout = 100;
 		if (remote)
-			timeout = 300;
+			timeout = 500;
 		do {
 			try {
 				Thread.sleep(timeout);
@@ -208,16 +208,26 @@ public class AltosSerial implements Runnable {
 	}
 
 	public String get_reply() throws InterruptedException {
+		if (SwingUtilities.isEventDispatchThread())
+			System.out.printf("Uh-oh, reading serial device from swing thread\n");
 		flush_output();
 		AltosLine line = reply_queue.take();
 		return line.line;
 	}
 
+	int	in_reply;
+
 	public String get_reply(int timeout) throws InterruptedException {
+		boolean	can_cancel = true;
+		++in_reply;
+
+		if (SwingUtilities.isEventDispatchThread()) {
+			can_cancel = false;
+			System.out.printf("Uh-oh, reading serial device from swing thread\n");
+		}
 		flush_output();
-		if (remote) {
-			timeout = 300;
-			System.out.printf("Doing remote timout\n");
+		if (remote && can_cancel) {
+			timeout = 500;
 		}
 		abort = false;
 		timeout_started = false;
@@ -225,10 +235,13 @@ public class AltosSerial implements Runnable {
 			AltosLine line = reply_queue.poll(timeout, TimeUnit.MILLISECONDS);
 			if (line != null) {
 				stop_timeout_dialog();
+				--in_reply;
 				return line.line;
 			}
-			if (!remote || check_timeout())
+			if (!remote || !can_cancel || check_timeout()) {
+				--in_reply;
 				return null;
+			}
 		}
 	}
 
@@ -244,6 +257,9 @@ public class AltosSerial implements Runnable {
 	}
 
 	public void close() {
+		if (in_reply != 0)
+			System.out.printf("Uh-oh. Closing active serial device\n");
+
 		if (altos != null) {
 			libaltos.altos_close(altos);
 		}
@@ -362,7 +378,6 @@ public class AltosSerial implements Runnable {
 		try {
 			flush_input();
 		} finally {
-			System.out.printf("Sending tilde\n");
 			printf ("~\n");
 			flush_output();
 		}