mem_ap: fix a potential memory leak in mem_ap_target_create()
[fw/openocd] / src / target / smp.c
index 66dbfec16c8f634b95395c7c3732a539c637f3e2..bdf81a0eeb3df88069a1ef94aa7daf2dfeeba808 100644 (file)
@@ -13,9 +13,7 @@
  *   GNU General Public License for more details.                          *
  *                                                                         *
  *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
 
 /* packet j :smp status request */
 int gdb_read_smp_packet(struct connection *connection,
-               char *packet, int packet_size)
+               char const *packet, int packet_size)
 {
        struct target *target = get_target_from_connection(connection);
-       uint32_t len = sizeof(int32_t);
-       uint8_t *buffer;
-       char *hex_buffer;
        int retval = ERROR_OK;
        if (target->smp) {
                if (strncmp(packet, "jc", 2) == 0) {
-                       hex_buffer = malloc(len * 2 + 1);
-                       buffer = (uint8_t *)&target->gdb_service->core[0];
-                       int pkt_len = hexify(hex_buffer, (char *)buffer, len, len * 2 + 1);
+                       const uint32_t len = sizeof(target->gdb_service->core[0]);
+                       char hex_buffer[len * 2 + 1];
+                       uint8_t buffer[len];
+                       buf_set_u32(buffer, 0, len * 8, target->gdb_service->core[0]);
+                       size_t pkt_len = hexify(hex_buffer, buffer, sizeof(buffer),
+                               sizeof(hex_buffer));
 
                        retval = gdb_put_packet(connection, hex_buffer, pkt_len);
-                       free(hex_buffer);
                }
        } else
                retval = gdb_put_packet(connection, "E01", 3);
@@ -79,7 +76,7 @@ int gdb_read_smp_packet(struct connection *connection,
 
 /* J :  smp set request */
 int gdb_write_smp_packet(struct connection *connection,
-               char *packet, int packet_size)
+               char const *packet, int packet_size)
 {
        struct target *target = get_target_from_connection(connection);
        char *separator;