target: document possibly unreachable target in deinit_target()

[fw/openocd] / src / target / smp.c

diff --git a/src/target/smp.c b/src/target/smp.c
index 94c4da5a88510ed8a78e899599ebd7a378e29185..569abd7860a4f632a6de652042583173a7cb3b12 100644 (file)
--- a/src/target/smp.c
+++ b/src/target/smp.c
@@ -28,6 +28,7 @@
 #include "smp.h"
 #include "helper/binarybuffer.h"
 
+/* DEPRECATED: gdb_read_smp_packet/gdb_write_smp_packet to be removed      */
 /*  implementation of new packet in gdb interface for smp feature          */
 /*                                                                         */
 /*   j : smp  status request                                               */
@@ -53,11 +54,15 @@
 /*  maint packet jc                                                        */
 
 /* packet j :smp status request */
+#define DEPRECATED_MSG "DEPRECATED: This method is deprecated in favor of the hwthread pseudo RTOS"
 int gdb_read_smp_packet(struct connection *connection,
                char const *packet, int packet_size)
 {
        struct target *target = get_target_from_connection(connection);
        int retval = ERROR_OK;
+
+       LOG_WARNING(DEPRECATED_MSG);
+
        if (target->smp) {
                if (strncmp(packet, "jc", 2) == 0) {
                        const uint32_t len = sizeof(target->gdb_service->core[0]);
@@ -83,6 +88,8 @@ int gdb_write_smp_packet(struct connection *connection,
        int coreid = 0;
        int retval = ERROR_OK;
 
+       LOG_WARNING(DEPRECATED_MSG);
+
        /* skip command character */
        if (target->smp) {
                if (strncmp(packet, "Jc", 2) == 0) {
@@ -111,18 +118,18 @@ COMMAND_HANDLER(default_handle_smp_command)
        }
 
        if (!strcmp(CMD_ARGV[0], "on")) {
-               foreach_smp_target(head, target->head)
+               foreach_smp_target(head, target->smp_targets)
                        head->target->smp = 1;
 
                return ERROR_OK;
        }
 
        if (!strcmp(CMD_ARGV[0], "off")) {
-               foreach_smp_target(head, target->head)
+               foreach_smp_target(head, target->smp_targets)
                        head->target->smp = 0;
 
                /* fixes the target display to the debugger */
-               if (target->head)
+               if (!list_empty(target->smp_targets))
                        target->gdb_service->target = target;
 
                return ERROR_OK;
@@ -135,9 +142,7 @@ COMMAND_HANDLER(handle_smp_gdb_command)
 {
        struct target *target = get_current_target(CMD_CTX);
        int retval = ERROR_OK;
-       struct target_list *head;
-       head = target->head;
-       if (head != (struct target_list *)NULL) {
+       if (!list_empty(target->smp_targets)) {
                if (CMD_ARGC == 1) {
                        int coreid = 0;
                        COMMAND_PARSE_NUMBER(int, CMD_ARGV[0], coreid);