openocd: src/target: replace the GPL-2.0-or-later license tag
[fw/openocd] / src / target / arm920t.c
index 41d64733693188d9320ec8ed16a84b3f7065987a..7b5fa81e67095a777b6c3a7f871fc80d8d056f7e 100644 (file)
@@ -1,22 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
 
 /***************************************************************************
  *   Copyright (C) 2005 by Dominic Rath                                    *
  *   Dominic.Rath@gmx.de                                                   *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -96,7 +83,7 @@ static int arm920t_read_cp15_physical(struct target *target,
        retval = arm_jtag_scann(jtag_info, 0xf, TAP_IDLE);
        if (retval != ERROR_OK)
                return retval;
-       retval = arm_jtag_set_instr(jtag_info, jtag_info->intest_instr, NULL, TAP_IDLE);
+       retval = arm_jtag_set_instr(jtag_info->tap, jtag_info->intest_instr, NULL, TAP_IDLE);
        if (retval != ERROR_OK)
                return retval;
 
@@ -151,7 +138,7 @@ static int arm920t_write_cp15_physical(struct target *target,
        retval = arm_jtag_scann(jtag_info, 0xf, TAP_IDLE);
        if (retval != ERROR_OK)
                return retval;
-       retval = arm_jtag_set_instr(jtag_info, jtag_info->intest_instr, NULL, TAP_IDLE);
+       retval = arm_jtag_set_instr(jtag_info->tap, jtag_info->intest_instr, NULL, TAP_IDLE);
        if (retval != ERROR_OK)
                return retval;
 
@@ -204,7 +191,7 @@ static int arm920t_execute_cp15(struct target *target, uint32_t cp15_opcode,
        retval = arm_jtag_scann(jtag_info, 0xf, TAP_IDLE);
        if (retval != ERROR_OK)
                return retval;
-       retval = arm_jtag_set_instr(jtag_info, jtag_info->intest_instr, NULL, TAP_IDLE);
+       retval = arm_jtag_set_instr(jtag_info->tap, jtag_info->intest_instr, NULL, TAP_IDLE);
        if (retval != ERROR_OK)
                return retval;
 
@@ -247,8 +234,8 @@ static int arm920t_read_cp15_interpreted(struct target *target,
        uint32_t cp15_opcode, uint32_t address, uint32_t *value)
 {
        struct arm *arm = target_to_arm(target);
-       uint32_t *regs_p[1];
-       uint32_t regs[2];
+       uint32_t *regs_p[16];
+       uint32_t regs[16];
        uint32_t cp15c15 = 0x0;
        struct reg *r = arm->core_cache->reg_list;
 
@@ -285,8 +272,8 @@ static int arm920t_read_cp15_interpreted(struct target *target,
                return ERROR_FAIL;
        }
 
-       r[0].dirty = 1;
-       r[1].dirty = 1;
+       r[0].dirty = true;
+       r[1].dirty = true;
 
        return ERROR_OK;
 }
@@ -297,7 +284,7 @@ int arm920t_write_cp15_interpreted(struct target *target,
 {
        uint32_t cp15c15 = 0x0;
        struct arm *arm = target_to_arm(target);
-       uint32_t regs[2];
+       uint32_t regs[16];
        struct reg *r = arm->core_cache->reg_list;
 
        /* load value, address into R0, R1 */
@@ -329,8 +316,8 @@ int arm920t_write_cp15_interpreted(struct target *target,
                return ERROR_FAIL;
        }
 
-       r[0].dirty = 1;
-       r[1].dirty = 1;
+       r[0].dirty = true;
+       r[1].dirty = true;
 
        return ERROR_OK;
 }
@@ -486,7 +473,7 @@ int arm920t_post_debug_entry(struct target *target)
 /* EXPORTED to FA256 */
 void arm920t_pre_restore_context(struct target *target)
 {
-       uint32_t cp15c15;
+       uint32_t cp15c15 = 0;
        struct arm920t_common *arm920t = target_to_arm920(target);
 
        /* restore i/d fault status and address register */
@@ -509,11 +496,11 @@ void arm920t_pre_restore_context(struct target *target)
 
 static const char arm920_not[] = "target is not an ARM920";
 
-static int arm920t_verify_pointer(struct command_context *cmd_ctx,
+static int arm920t_verify_pointer(struct command_invocation *cmd,
        struct arm920t_common *arm920t)
 {
        if (arm920t->common_magic != ARM920T_COMMON_MAGIC) {
-               command_print(cmd_ctx, arm920_not);
+               command_print(cmd, arm920_not);
                return ERROR_TARGET_INVALID;
        }
 
@@ -555,7 +542,7 @@ static int arm920_mmu(struct target *target, int *enabled)
 }
 
 static int arm920_virt2phys(struct target *target,
-       uint32_t virt, uint32_t *phys)
+       target_addr_t virt, target_addr_t *phys)
 {
        uint32_t cb;
        struct arm920t_common *arm920t = target_to_arm920(target);
@@ -570,7 +557,7 @@ static int arm920_virt2phys(struct target *target,
 }
 
 /** Reads a buffer, in the specified word size, with current MMU settings. */
-int arm920t_read_memory(struct target *target, uint32_t address,
+int arm920t_read_memory(struct target *target, target_addr_t address,
        uint32_t size, uint32_t count, uint8_t *buffer)
 {
        int retval;
@@ -582,7 +569,7 @@ int arm920t_read_memory(struct target *target, uint32_t address,
 
 
 static int arm920t_read_phys_memory(struct target *target,
-       uint32_t address, uint32_t size,
+       target_addr_t address, uint32_t size,
        uint32_t count, uint8_t *buffer)
 {
        struct arm920t_common *arm920t = target_to_arm920(target);
@@ -592,7 +579,7 @@ static int arm920t_read_phys_memory(struct target *target,
 }
 
 static int arm920t_write_phys_memory(struct target *target,
-       uint32_t address, uint32_t size,
+       target_addr_t address, uint32_t size,
        uint32_t count, const uint8_t *buffer)
 {
        struct arm920t_common *arm920t = target_to_arm920(target);
@@ -602,7 +589,7 @@ static int arm920t_write_phys_memory(struct target *target,
 }
 
 /** Writes a buffer, in the specified word size, with current MMU settings. */
-int arm920t_write_memory(struct target *target, uint32_t address,
+int arm920t_write_memory(struct target *target, target_addr_t address,
        uint32_t size, uint32_t count, const uint8_t *buffer)
 {
        int retval;
@@ -753,8 +740,8 @@ int arm920t_soft_reset_halt(struct target *target)
        if (retval != ERROR_OK)
                return retval;
 
-       long long then = timeval_ms();
-       int timeout;
+       int64_t then = timeval_ms();
+       bool timeout;
        while (!(timeout = ((timeval_ms()-then) > 1000))) {
                if (buf_get_u32(dbg_stat->value, EICE_DBG_STATUS_DBGACK, 1) == 0) {
                        embeddedice_read_reg(dbg_stat);
@@ -783,12 +770,12 @@ int arm920t_soft_reset_halt(struct target *target)
        cpsr &= ~0xff;
        cpsr |= 0xd3;
        arm_set_cpsr(arm, cpsr);
-       arm->cpsr->dirty = 1;
+       arm->cpsr->dirty = true;
 
        /* start fetching from 0x0 */
        buf_set_u32(arm->pc->value, 0, 32, 0x0);
-       arm->pc->dirty = 1;
-       arm->pc->valid = 1;
+       arm->pc->dirty = true;
+       arm->pc->valid = true;
 
        arm920t_disable_mmu_caches(target, 1, 1, 1);
        arm920t->armv4_5_mmu.mmu_enabled = 0;
@@ -801,11 +788,11 @@ int arm920t_soft_reset_halt(struct target *target)
 /* FIXME remove forward decls */
 static int arm920t_mrc(struct target *target, int cpnum,
                uint32_t op1, uint32_t op2,
-               uint32_t CRn, uint32_t CRm,
+               uint32_t crn, uint32_t crm,
                uint32_t *value);
 static int arm920t_mcr(struct target *target, int cpnum,
                uint32_t op1, uint32_t op2,
-               uint32_t CRn, uint32_t CRm,
+               uint32_t crn, uint32_t crm,
                uint32_t value);
 
 static int arm920t_init_arch_info(struct target *target,
@@ -823,6 +810,7 @@ static int arm920t_init_arch_info(struct target *target,
 
        arm7_9->post_debug_entry = arm920t_post_debug_entry;
        arm7_9->pre_restore_context = arm920t_pre_restore_context;
+       arm7_9->write_memory = arm920t_write_memory;
 
        arm920t->armv4_5_mmu.armv4_5_cache.ctype = -1;
        arm920t->armv4_5_mmu.get_ttb = arm920t_get_ttb;
@@ -853,6 +841,16 @@ static int arm920t_target_create(struct target *target, Jim_Interp *interp)
        return arm920t_init_arch_info(target, arm920t, target->tap);
 }
 
+static void arm920t_deinit_target(struct target *target)
+{
+       struct arm *arm = target_to_arm(target);
+       struct arm920t_common *arm920t = target_to_arm920(target);
+
+       arm7_9_deinit(target);
+       arm_free_reg_cache(arm);
+       free(arm920t);
+}
+
 COMMAND_HANDLER(arm920t_handle_read_cache_command)
 {
        int retval = ERROR_OK;
@@ -864,13 +862,13 @@ COMMAND_HANDLER(arm920t_handle_read_cache_command)
        uint32_t cp15_ctrl, cp15_ctrl_saved;
        uint32_t regs[16];
        uint32_t *regs_p[16];
-       uint32_t C15_C_D_Ind, C15_C_I_Ind;
+       uint32_t c15_c_d_ind, c15_c_i_ind;
        int i;
        FILE *output;
        int segment, index_t;
        struct reg *r;
 
-       retval = arm920t_verify_pointer(CMD_CTX, arm920t);
+       retval = arm920t_verify_pointer(CMD, arm920t);
        if (retval != ERROR_OK)
                return retval;
 
@@ -878,7 +876,7 @@ COMMAND_HANDLER(arm920t_handle_read_cache_command)
                return ERROR_COMMAND_SYNTAX_ERROR;
 
        output = fopen(CMD_ARGV[0], "w");
-       if (output == NULL) {
+       if (!output) {
                LOG_DEBUG("error opening cache content file");
                return ERROR_OK;
        }
@@ -924,7 +922,7 @@ COMMAND_HANDLER(arm920t_handle_read_cache_command)
 
                /* read current victim */
                arm920t_read_cp15_physical(target,
-                       CP15PHYS_DCACHE_IDX, &C15_C_D_Ind);
+                       CP15PHYS_DCACHE_IDX, &c15_c_d_ind);
 
                /* clear interpret mode */
                cp15c15 &= ~0x1;
@@ -983,7 +981,7 @@ COMMAND_HANDLER(arm920t_handle_read_cache_command)
                }
 
                /* Ra: r0 = index(31:26):SBZ(25:8):segment(7:5):SBZ(4:0) */
-               regs[0] = 0x0 | (segment << 5) | (C15_C_D_Ind << 26);
+               regs[0] = 0x0 | (segment << 5) | (c15_c_d_ind << 26);
                arm9tdmi_write_core_regs(target, 0x1, regs);
 
                /* set interpret mode */
@@ -1025,7 +1023,7 @@ COMMAND_HANDLER(arm920t_handle_read_cache_command)
 
                /* read current victim */
                arm920t_read_cp15_physical(target, CP15PHYS_ICACHE_IDX,
-                       &C15_C_I_Ind);
+                       &c15_c_i_ind);
 
                /* clear interpret mode */
                cp15c15 &= ~0x1;
@@ -1083,7 +1081,7 @@ COMMAND_HANDLER(arm920t_handle_read_cache_command)
                }
 
                /* Ra: r0 = index(31:26):SBZ(25:8):segment(7:5):SBZ(4:0) */
-               regs[0] = 0x0 | (segment << 5) | (C15_C_D_Ind << 26);
+               regs[0] = 0x0 | (segment << 5) | (c15_c_d_ind << 26);
                arm9tdmi_write_core_regs(target, 0x1, regs);
 
                /* set interpret mode */
@@ -1104,7 +1102,7 @@ COMMAND_HANDLER(arm920t_handle_read_cache_command)
        /* restore CP15 MMU and Cache settings */
        arm920t_write_cp15_physical(target, CP15PHYS_CTRL, cp15_ctrl_saved);
 
-       command_print(CMD_CTX, "cache content successfully output to %s",
+       command_print(CMD, "cache content successfully output to %s",
                CMD_ARGV[0]);
 
        fclose(output);
@@ -1147,12 +1145,12 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
        uint32_t *regs_p[16];
        int i;
        FILE *output;
-       uint32_t Dlockdown, Ilockdown;
+       uint32_t d_lockdown, i_lockdown;
        struct arm920t_tlb_entry d_tlb[64], i_tlb[64];
        int victim;
        struct reg *r;
 
-       retval = arm920t_verify_pointer(CMD_CTX, arm920t);
+       retval = arm920t_verify_pointer(CMD, arm920t);
        if (retval != ERROR_OK)
                return retval;
 
@@ -1160,7 +1158,7 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
                return ERROR_COMMAND_SYNTAX_ERROR;
 
        output = fopen(CMD_ARGV[0], "w");
-       if (output == NULL) {
+       if (!output) {
                LOG_DEBUG("error opening mmu content file");
                return ERROR_OK;
        }
@@ -1204,13 +1202,13 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
        retval = jtag_execute_queue();
        if (retval != ERROR_OK)
                return retval;
-       Dlockdown = regs[1];
+       d_lockdown = regs[1];
 
        for (victim = 0; victim < 64; victim += 8) {
                /* new lockdown value: base[31:26]:victim[25:20]:SBZ[19:1]:p[0]
                 * base remains unchanged, victim goes through entries 0 to 63
                 */
-               regs[1] = (Dlockdown & 0xfc000000) | (victim << 20);
+               regs[1] = (d_lockdown & 0xfc000000) | (victim << 20);
                arm9tdmi_write_core_regs(target, 0x2, regs);
 
                /* set interpret mode */
@@ -1247,7 +1245,7 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
                /* new lockdown value: base[31:26]:victim[25:20]:SBZ[19:1]:p[0]
                 * base remains unchanged, victim goes through entries 0 to 63
                 */
-               regs[1] = (Dlockdown & 0xfc000000) | (victim << 20);
+               regs[1] = (d_lockdown & 0xfc000000) | (victim << 20);
                arm9tdmi_write_core_regs(target, 0x2, regs);
 
                /* set interpret mode */
@@ -1283,7 +1281,7 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
        }
 
        /* restore D TLB lockdown */
-       regs[1] = Dlockdown;
+       regs[1] = d_lockdown;
        arm9tdmi_write_core_regs(target, 0x2, regs);
 
        /* Write D TLB lockdown */
@@ -1310,13 +1308,13 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
        retval = jtag_execute_queue();
        if (retval != ERROR_OK)
                return retval;
-       Ilockdown = regs[1];
+       i_lockdown = regs[1];
 
        for (victim = 0; victim < 64; victim += 8) {
                /* new lockdown value: base[31:26]:victim[25:20]:SBZ[19:1]:p[0]
                 * base remains unchanged, victim goes through entries 0 to 63
                 */
-               regs[1] = (Ilockdown & 0xfc000000) | (victim << 20);
+               regs[1] = (i_lockdown & 0xfc000000) | (victim << 20);
                arm9tdmi_write_core_regs(target, 0x2, regs);
 
                /* set interpret mode */
@@ -1353,7 +1351,7 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
                /* new lockdown value: base[31:26]:victim[25:20]:SBZ[19:1]:p[0]
                 * base remains unchanged, victim goes through entries 0 to 63
                 */
-               regs[1] = (Dlockdown & 0xfc000000) | (victim << 20);
+               regs[1] = (d_lockdown & 0xfc000000) | (victim << 20);
                arm9tdmi_write_core_regs(target, 0x2, regs);
 
                /* set interpret mode */
@@ -1389,7 +1387,7 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
        }
 
        /* restore I TLB lockdown */
-       regs[1] = Ilockdown;
+       regs[1] = i_lockdown;
        arm9tdmi_write_core_regs(target, 0x2, regs);
 
        /* Write I TLB lockdown */
@@ -1416,7 +1414,7 @@ COMMAND_HANDLER(arm920t_handle_read_mmu_command)
                        (i_tlb[i].cam & 0x20) ? "(valid)" : "(invalid)");
        }
 
-       command_print(CMD_CTX, "mmu content successfully output to %s",
+       command_print(CMD, "mmu content successfully output to %s",
                CMD_ARGV[0]);
 
        fclose(output);
@@ -1452,12 +1450,12 @@ COMMAND_HANDLER(arm920t_handle_cp15_command)
        struct target *target = get_current_target(CMD_CTX);
        struct arm920t_common *arm920t = target_to_arm920(target);
 
-       retval = arm920t_verify_pointer(CMD_CTX, arm920t);
+       retval = arm920t_verify_pointer(CMD, arm920t);
        if (retval != ERROR_OK)
                return retval;
 
        if (target->state != TARGET_HALTED) {
-               command_print(CMD_CTX, "target must be stopped for "
+               command_print(CMD, "target must be stopped for "
                        "\"%s\" command", CMD_NAME);
                return ERROR_OK;
        }
@@ -1473,7 +1471,7 @@ COMMAND_HANDLER(arm920t_handle_cp15_command)
                        uint32_t value;
                        retval = arm920t_read_cp15_physical(target, address, &value);
                        if (retval != ERROR_OK) {
-                               command_print(CMD_CTX,
+                               command_print(CMD,
                                        "couldn't access reg %i", address);
                                return ERROR_OK;
                        }
@@ -1481,7 +1479,7 @@ COMMAND_HANDLER(arm920t_handle_cp15_command)
                        if (retval != ERROR_OK)
                                return retval;
 
-                       command_print(CMD_CTX, "%i: %8.8" PRIx32,
+                       command_print(CMD, "%i: %8.8" PRIx32,
                                address, value);
                } else if (CMD_ARGC == 2)   {
                        uint32_t value;
@@ -1489,12 +1487,12 @@ COMMAND_HANDLER(arm920t_handle_cp15_command)
                        retval = arm920t_write_cp15_physical(target,
                                        address, value);
                        if (retval != ERROR_OK) {
-                               command_print(CMD_CTX,
+                               command_print(CMD,
                                        "couldn't access reg %i", address);
                                /* REVISIT why lie? "return retval"? */
                                return ERROR_OK;
                        }
-                       command_print(CMD_CTX, "%i: %8.8" PRIx32,
+                       command_print(CMD, "%i: %8.8" PRIx32,
                                address, value);
                }
        }
@@ -1502,98 +1500,24 @@ COMMAND_HANDLER(arm920t_handle_cp15_command)
        return ERROR_OK;
 }
 
-COMMAND_HANDLER(arm920t_handle_cp15i_command)
-{
-       int retval;
-       struct target *target = get_current_target(CMD_CTX);
-       struct arm920t_common *arm920t = target_to_arm920(target);
-
-       retval = arm920t_verify_pointer(CMD_CTX, arm920t);
-       if (retval != ERROR_OK)
-               return retval;
-
-
-       if (target->state != TARGET_HALTED) {
-               command_print(CMD_CTX, "target must be stopped for "
-                       "\"%s\" command", CMD_NAME);
-               return ERROR_OK;
-       }
-
-       /* one argument, read a register.
-        * two arguments, write it.
-        */
-       if (CMD_ARGC >= 1) {
-               uint32_t opcode;
-               COMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], opcode);
-
-               if (CMD_ARGC == 1) {
-                       uint32_t value;
-                       retval = arm920t_read_cp15_interpreted(target,
-                                       opcode, 0x0, &value);
-                       if (retval != ERROR_OK) {
-                               command_print(CMD_CTX,
-                                       "couldn't execute %8.8" PRIx32,
-                                       opcode);
-                               /* REVISIT why lie? "return retval"? */
-                               return ERROR_OK;
-                       }
-
-                       command_print(CMD_CTX, "%8.8" PRIx32 ": %8.8" PRIx32,
-                               opcode, value);
-               } else if (CMD_ARGC == 2) {
-                       uint32_t value;
-                       COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], value);
-                       retval = arm920t_write_cp15_interpreted(target,
-                                       opcode, value, 0);
-                       if (retval != ERROR_OK) {
-                               command_print(CMD_CTX,
-                                       "couldn't execute %8.8" PRIx32,
-                                       opcode);
-                               /* REVISIT why lie? "return retval"? */
-                               return ERROR_OK;
-                       }
-                       command_print(CMD_CTX, "%8.8" PRIx32 ": %8.8" PRIx32,
-                               opcode, value);
-               } else if (CMD_ARGC == 3) {
-                       uint32_t value;
-                       COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], value);
-                       uint32_t address;
-                       COMMAND_PARSE_NUMBER(u32, CMD_ARGV[2], address);
-                       retval = arm920t_write_cp15_interpreted(target,
-                                       opcode, value, address);
-                       if (retval != ERROR_OK) {
-                               command_print(CMD_CTX,
-                                       "couldn't execute %8.8" PRIx32, opcode);
-                               /* REVISIT why lie? "return retval"? */
-                               return ERROR_OK;
-                       }
-                       command_print(CMD_CTX, "%8.8" PRIx32 ": %8.8" PRIx32
-                               " %8.8" PRIx32, opcode, value, address);
-               }
-       } else
-               return ERROR_COMMAND_SYNTAX_ERROR;
-
-       return ERROR_OK;
-}
-
 COMMAND_HANDLER(arm920t_handle_cache_info_command)
 {
        int retval;
        struct target *target = get_current_target(CMD_CTX);
        struct arm920t_common *arm920t = target_to_arm920(target);
 
-       retval = arm920t_verify_pointer(CMD_CTX, arm920t);
+       retval = arm920t_verify_pointer(CMD, arm920t);
        if (retval != ERROR_OK)
                return retval;
 
-       return armv4_5_handle_cache_info_command(CMD_CTX,
+       return armv4_5_handle_cache_info_command(CMD,
                &arm920t->armv4_5_mmu.armv4_5_cache);
 }
 
 
 static int arm920t_mrc(struct target *target, int cpnum,
        uint32_t op1, uint32_t op2,
-       uint32_t CRn, uint32_t CRm,
+       uint32_t crn, uint32_t crm,
        uint32_t *value)
 {
        if (cpnum != 15) {
@@ -1603,13 +1527,13 @@ static int arm920t_mrc(struct target *target, int cpnum,
 
        /* read "to" r0 */
        return arm920t_read_cp15_interpreted(target,
-               ARMV4_5_MRC(cpnum, op1, 0, CRn, CRm, op2),
+               ARMV4_5_MRC(cpnum, op1, 0, crn, crm, op2),
                0, value);
 }
 
 static int arm920t_mcr(struct target *target, int cpnum,
        uint32_t op1, uint32_t op2,
-       uint32_t CRn, uint32_t CRm,
+       uint32_t crn, uint32_t crm,
        uint32_t value)
 {
        if (cpnum != 15) {
@@ -1619,7 +1543,7 @@ static int arm920t_mcr(struct target *target, int cpnum,
 
        /* write "from" r0 */
        return arm920t_write_cp15_interpreted(target,
-               ARMV4_5_MCR(cpnum, op1, 0, CRn, CRm, op2),
+               ARMV4_5_MCR(cpnum, op1, 0, crn, crm, op2),
                0, value);
 }
 
@@ -1631,15 +1555,6 @@ static const struct command_registration arm920t_exec_command_handlers[] = {
                .help = "display/modify cp15 register",
                .usage = "regnum [value]",
        },
-       {
-               .name = "cp15i",
-               .handler = arm920t_handle_cp15i_command,
-               .mode = COMMAND_EXEC,
-               /* prefer using less error-prone "arm mcr" or "arm mrc" */
-               .help = "display/modify cp15 register using ARM opcode"
-                       " (DEPRECATED)",
-               .usage = "instruction [value [address]]",
-       },
        {
                .name = "cache_info",
                .handler = arm920t_handle_cache_info_command,
@@ -1694,17 +1609,16 @@ struct target_type arm920t_target = {
        .deassert_reset = arm7_9_deassert_reset,
        .soft_reset_halt = arm920t_soft_reset_halt,
 
+       .get_gdb_arch = arm_get_gdb_arch,
        .get_gdb_reg_list = arm_get_gdb_reg_list,
 
        .read_memory = arm920t_read_memory,
-       .write_memory = arm920t_write_memory,
+       .write_memory = arm7_9_write_memory_opt,
        .read_phys_memory = arm920t_read_phys_memory,
        .write_phys_memory = arm920t_write_phys_memory,
        .mmu = arm920_mmu,
        .virt2phys = arm920_virt2phys,
 
-       .bulk_write_memory = arm7_9_bulk_write_memory,
-
        .checksum_memory = arm_checksum_memory,
        .blank_check_memory = arm_blank_check_memory,
 
@@ -1718,6 +1632,7 @@ struct target_type arm920t_target = {
        .commands = arm920t_command_handlers,
        .target_create = arm920t_target_create,
        .init_target = arm9tdmi_init_target,
+       .deinit_target = arm920t_deinit_target,
        .examine = arm7_9_examine,
        .check_reset = arm7_9_check_reset,
 };