int devBus =0;
int devAddr=0;
+ /* @TODO: Reading a environment variable in a usb open function is not very nice, this
+ should be refactored and moved into the CLI tools, and instead of giving USB_BUS:USB_ADDR a real stlink
+ serial string should be passed to this function. Probably people are using this but this is very odd because
+ as programmer can change to multiple busses and it is better to detect them based on serial. */
char *device = getenv("STLINK_DEVICE");
if (device) {
char *c = strchr(device,':');
(unsigned char *)sl->serial, sizeof(sl->serial));
libusb_close(handle);
- if (sl->serial_size < 0)
- continue;
- if (serial == NULL)
+ if ((serial == NULL) || (*serial == 0))
break;
+
+ if (sl->serial_size < 0)
+ continue;
+
if (memcmp(serial, &sl->serial, sl->serial_size) == 0)
break;
}
if (libusb_claim_interface(slu->usb_handle, 0)) {
- WLOG("libusb_claim_interface() failed\n");
+ WLOG("Stlink usb device found, but unable to claim (probably already in use?)\n");
goto on_libusb_error;
}
WLOG("failed to get libusb device descriptor\n");
break;
}
- libusb_get_string_descriptor_ascii(handle, desc.iSerialNumber, (unsigned char *)&serial, sizeof(serial));
+
+ ret = libusb_get_string_descriptor_ascii(handle, desc.iSerialNumber, (unsigned char *)&serial, sizeof(serial));
+ if (ret < 0)
+ *serial = NULL;
+
libusb_close(handle);
stlink_t *sl = NULL;