fix jtag_add_callback() args. The first argument is nothing special, it's just anothe...
[fw/openocd] / src / pld / virtex2.c
index 5a0694218d80b716477cbf1a73658dae2a10c00c..1f063a0ad925dc0b89c61d3ed84ca3965ff8bc27 100644 (file)
 #endif
 
 #include "virtex2.h"
-
-#include "pld.h"
 #include "xilinx_bit.h"
-#include "command.h"
-#include "log.h"
-#include "jtag.h"
+#include "pld.h"
 
-#include <stdlib.h>
 
-int virtex2_register_commands(struct command_context_s *cmd_ctx);
-int virtex2_pld_device_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, struct pld_device_s *pld_device);
-int virtex2_load(struct pld_device_s *pld_device, char *filename);
+static int virtex2_register_commands(struct command_context_s *cmd_ctx);
+static int virtex2_pld_device_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, struct pld_device_s *pld_device);
+static int virtex2_load(struct pld_device_s *pld_device, char *filename);
 
 pld_driver_t virtex2_pld =
 {
@@ -43,9 +38,9 @@ pld_driver_t virtex2_pld =
        .load = virtex2_load,
 };
 
-int virtex2_set_instr(jtag_tap_t *tap, u32 new_instr)
+static int virtex2_set_instr(jtag_tap_t *tap, uint32_t new_instr)
 {
-       if (tap==NULL)
+       if (tap == NULL)
                return ERROR_FAIL;
 
        if (buf_get_u32(tap->cur_instr, 0, tap->ir_length) != new_instr)
@@ -56,14 +51,9 @@ int virtex2_set_instr(jtag_tap_t *tap, u32 new_instr)
                field.num_bits = tap->ir_length;
                field.out_value = calloc(CEIL(field.num_bits, 8), 1);
                buf_set_u32(field.out_value, 0, field.num_bits, new_instr);
-
                field.in_value = NULL;
 
-
-               field.in_handler = NULL;
-
-
-               jtag_add_ir_scan(1, &field, TAP_IDLE);
+               jtag_add_ir_scan(1, &field, jtag_set_end_state(TAP_IDLE));
 
                free(field.out_value);
        }
@@ -71,11 +61,12 @@ int virtex2_set_instr(jtag_tap_t *tap, u32 new_instr)
        return ERROR_OK;
 }
 
-int virtex2_send_32(struct pld_device_s *pld_device, int num_words, u32 *words)
+static int virtex2_send_32(struct pld_device_s *pld_device,
+               int num_words, uint32_t *words)
 {
        virtex2_pld_device_t *virtex2_info = pld_device->driver_priv;
        scan_field_t scan_field;
-       u8 *values;
+       uint8_t *values;
        int i;
 
        values = malloc(num_words * 4);
@@ -84,22 +75,27 @@ int virtex2_send_32(struct pld_device_s *pld_device, int num_words, u32 *words)
        scan_field.num_bits = num_words * 32;
        scan_field.out_value = values;
        scan_field.in_value = NULL;
-       scan_field.in_handler = NULL;
 
        for (i = 0; i < num_words; i++)
                buf_set_u32(values + 4 * i, 0, 32, flip_u32(*words++, 32));
 
        virtex2_set_instr(virtex2_info->tap, 0x5); /* CFG_IN */
 
-       jtag_add_dr_scan(1, &scan_field, TAP_DRPAUSE);
+       jtag_add_dr_scan(1, &scan_field, jtag_set_end_state(TAP_DRPAUSE));
 
        free(values);
 
        return ERROR_OK;
 }
 
+static __inline__ void virtexflip32(jtag_callback_data_t arg)
+{
+  uint8_t *in=(uint8_t *)arg;
+       *((uint32_t *)in) = flip_u32(le_to_h_u32(in), 32);
+}
 
-int virtex2_receive_32(struct pld_device_s *pld_device, int num_words, u32 *words)
+static int virtex2_receive_32(struct pld_device_s *pld_device,
+               int num_words, uint32_t *words)
 {
        virtex2_pld_device_t *virtex2_info = pld_device->driver_priv;
        scan_field_t scan_field;
@@ -107,25 +103,27 @@ int virtex2_receive_32(struct pld_device_s *pld_device, int num_words, u32 *word
        scan_field.tap = virtex2_info->tap;
        scan_field.num_bits = 32;
        scan_field.out_value = NULL;
-       u8 tmp[4];
-       scan_field.in_value = tmp;
-       scan_field.in_handler = NULL;
+       scan_field.in_value = NULL;
 
        virtex2_set_instr(virtex2_info->tap, 0x4); /* CFG_OUT */
 
        while (num_words--)
        {
-               jtag_add_dr_scan_now(1, &scan_field, TAP_DRPAUSE);
+               scan_field.in_value = (uint8_t *)words;
+
+               jtag_add_dr_scan(1, &scan_field, jtag_set_end_state(TAP_DRPAUSE));
 
-               *words++=flip_u32(le_to_h_u32(tmp), 32);
+               jtag_add_callback(virtexflip32, (jtag_callback_data_t)words);
+
+               words++;;
        }
 
        return ERROR_OK;
 }
 
-int virtex2_read_stat(struct pld_device_s *pld_device, u32 *status)
+static int virtex2_read_stat(struct pld_device_s *pld_device, uint32_t *status)
 {
-       u32 data[5];
+       uint32_t data[5];
 
        jtag_add_tlr();
 
@@ -145,27 +143,21 @@ int virtex2_read_stat(struct pld_device_s *pld_device, u32 *status)
        return ERROR_OK;
 }
 
-int virtex2_load(struct pld_device_s *pld_device, char *filename)
+static int virtex2_load(struct pld_device_s *pld_device, char *filename)
 {
        virtex2_pld_device_t *virtex2_info = pld_device->driver_priv;
        xilinx_bit_file_t bit_file;
        int retval;
        unsigned int i;
-
        scan_field_t field;
 
        field.tap = virtex2_info->tap;
-
        field.in_value = NULL;
 
-
-       field.in_handler = NULL;
-
-
        if ((retval = xilinx_read_bit_file(&bit_file, filename)) != ERROR_OK)
                return retval;
 
-       jtag_add_end_state(TAP_IDLE);
+       jtag_set_end_state(TAP_IDLE);
        virtex2_set_instr(virtex2_info->tap, 0xb); /* JPROG_B */
        jtag_execute_queue();
        jtag_add_sleep(1000);
@@ -179,29 +171,30 @@ int virtex2_load(struct pld_device_s *pld_device, char *filename)
        field.num_bits = bit_file.length * 8;
        field.out_value = bit_file.data;
 
-       jtag_add_dr_scan(1, &field, TAP_DRPAUSE);
+       jtag_add_dr_scan(1, &field, jtag_set_end_state(TAP_DRPAUSE));
        jtag_execute_queue();
 
        jtag_add_tlr();
 
-       jtag_add_end_state(TAP_IDLE);
+       jtag_set_end_state(TAP_IDLE);
        virtex2_set_instr(virtex2_info->tap, 0xc); /* JSTART */
-       jtag_add_runtest(13, TAP_IDLE);
+       jtag_add_runtest(13, jtag_set_end_state(TAP_IDLE));
        virtex2_set_instr(virtex2_info->tap, 0x3f); /* BYPASS */
        virtex2_set_instr(virtex2_info->tap, 0x3f); /* BYPASS */
        virtex2_set_instr(virtex2_info->tap, 0xc); /* JSTART */
-       jtag_add_runtest(13, TAP_IDLE);
+       jtag_add_runtest(13, jtag_set_end_state(TAP_IDLE));
        virtex2_set_instr(virtex2_info->tap, 0x3f); /* BYPASS */
        jtag_execute_queue();
 
        return ERROR_OK;
 }
 
-int virtex2_handle_read_stat_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
+static int virtex2_handle_read_stat_command(struct command_context_s *cmd_ctx,
+               char *cmd, char **args, int argc)
 {
        pld_device_t *device;
        virtex2_pld_device_t *virtex2_info;
-       u32 status;
+       uint32_t status;
 
        if (argc < 1)
        {
@@ -225,7 +218,7 @@ int virtex2_handle_read_stat_command(struct command_context_s *cmd_ctx, char *cm
        return ERROR_OK;
 }
 
-int virtex2_register_commands(struct command_context_s *cmd_ctx)
+static int virtex2_register_commands(struct command_context_s *cmd_ctx)
 {
        command_t *virtex2_cmd = register_command(cmd_ctx, NULL, "virtex2", NULL, COMMAND_ANY, "virtex2 specific commands");
 
@@ -235,7 +228,8 @@ int virtex2_register_commands(struct command_context_s *cmd_ctx)
        return ERROR_OK;
 }
 
-int virtex2_pld_device_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, struct pld_device_s *pld_device)
+static int virtex2_pld_device_command(struct command_context_s *cmd_ctx,
+               char *cmd, char **args, int argc, struct pld_device_s *pld_device)
 {
        jtag_tap_t *tap;
 
@@ -247,8 +241,8 @@ int virtex2_pld_device_command(struct command_context_s *cmd_ctx, char *cmd, cha
                return ERROR_PLD_DEVICE_INVALID;
        }
 
-       tap = jtag_TapByString( args[1] );
-       if( tap == NULL ){
+       tap = jtag_tap_by_string(args[1]);
+       if (tap == NULL) {
                command_print( cmd_ctx, "Tap: %s does not exist", args[1] );
                return ERROR_OK;
        }