* .version: bumped version number to 2.4.5
[fw/sdcc] / src / pic16 / ralloc.c
index c589bb41b4e50c32a68909b5f4ab559cde865fcc..0fec45041ddb85bb4eeb038038336b8081022444 100644 (file)
@@ -37,6 +37,9 @@
 #define STRCASECMP strcasecmp
 #endif
 
+//#define USE_ONSTACK
+
+
 /*-----------------------------------------------------------------*/
 /* At this point we start getting processor specific although      */
 /* some routines are non-processor specific & can be reused when   */
@@ -48,7 +51,6 @@
 
 regs *pic16_typeRegWithIdx (int idx, int type, int fixed);
 extern void genpic16Code (iCode *);
-extern void pic16_assignConfigWordValue(int address, int value);
 
 /* Global data */
 static struct
@@ -74,18 +76,25 @@ set *pic16_dynProcessorRegs=NULL;
 set *pic16_dynDirectRegs=NULL;
 set *pic16_dynDirectBitRegs=NULL;
 set *pic16_dynInternalRegs=NULL;
+set *pic16_dynAccessRegs=NULL;
 
-static hTab  *dynDirectRegNames= NULL;
+static hTab *dynDirectRegNames=NULL;
+static hTab *dynAllocRegNames=NULL;
+static hTab *dynProcRegNames=NULL;
+static hTab *dynAccessRegNames=NULL;
 //static hTab  *regHash = NULL;    /* a hash table containing ALL registers */
 
+extern set *sectNames;
+
 set *pic16_rel_udata=NULL;     /* relocatable uninitialized registers */
 set *pic16_fix_udata=NULL;     /* absolute uninitialized registers */
 set *pic16_equ_data=NULL;      /* registers used by equates */
 set *pic16_int_regs=NULL;      /* internal registers placed in access bank 0 to 0x7f */
+set *pic16_acs_udata=NULL;     /* access bank variables */
 
 set *pic16_builtin_functions=NULL;
 
-static int dynrIdx=0x10;               //0x20;         // starting temporary register rIdx
+static int dynrIdx=0x00;               //0x20;         // starting temporary register rIdx
 static int rDirectIdx=0;
 
 int pic16_nRegs = 128;   // = sizeof (regspic16) / sizeof (regs);
@@ -361,8 +370,6 @@ regs* newReg(short type, short pc_type, int rIdx, char *name, int size, int alia
 
        dReg->isFree = 0;
        dReg->wasUsed = 1;
-
-//     dReg->isMapped = 0;
        dReg->isEmitted = 0;
 
        if(type == REG_SFR) {
@@ -375,8 +382,8 @@ regs* newReg(short type, short pc_type, int rIdx, char *name, int size, int alia
                dReg->accessBank = 0;
        }
 
-//     fprintf(stderr,"newReg: %s, rIdx = 0x%02x\taccess= %d\n",dReg->name,rIdx, dReg->accessBank);
-       
+//     fprintf(stderr,"newReg: %s, rIdx = 0x%02x\taccess= %d\tregop= %p\n",dReg->name,rIdx, dReg->accessBank, refop);
+
        dReg->size = size;
        dReg->alias = alias;
        dReg->reg_alias = NULL;
@@ -394,7 +401,7 @@ regs* newReg(short type, short pc_type, int rIdx, char *name, int size, int alia
 /* regWithIdx - Search through a set of registers that matches idx */
 /*-----------------------------------------------------------------*/
 static regs *
-regWithIdx (set *dRegs, int idx, int fixed)
+regWithIdx (set *dRegs, int idx, unsigned fixed)
 {
   regs *dReg;
 
@@ -457,6 +464,8 @@ pic16_allocProcessorRegister(int rIdx, char * name, short po_type, int alias)
        reg->wasUsed = 0;               // we do not know if they are going to be used at all
        reg->accessBank = 1;            // implicit add access Bank
 
+       hTabAddItem(&dynProcRegNames, regname2key(reg->name), reg);
+
   return addSet(&pic16_dynProcessorRegs, reg);
 }
 
@@ -470,10 +479,10 @@ pic16_allocInternalRegister(int rIdx, char * name, short po_type, int alias)
 
 //  fprintf(stderr,"%s:%d: %s  %s addr =0x%x\n",__FILE__, __LINE__, __FUNCTION__, name, rIdx);
 
-  if(reg) {
-    reg->wasUsed = 0;
-    return addSet(&pic16_dynInternalRegs,reg);
-  }
+    if(reg) {
+      reg->wasUsed = 0;
+      return addSet(&pic16_dynInternalRegs,reg);
+    }
 
   return NULL;
 }
@@ -493,13 +502,21 @@ allocReg (short type)
        /* try to reuse some unused registers */
        reg = regFindFree( pic16_dynAllocRegs );
 
+       if(reg) {
+//             fprintf(stderr, "%s: found FREE register %s\n", __FILE__, reg->name);
+       }
+
        if(!reg) {
                reg = newReg(REG_GPR, PO_GPR_TEMP, dynrIdx++, NULL, 1, 0, NULL);
-               addSet(&pic16_dynAllocRegs, reg);
+//             addSet(&pic16_dynAllocRegs, reg);
        }
+
+       addSet(&pic16_dynAllocRegs, reg);
+       hTabAddItem(&dynAllocRegNames, regname2key(reg->name), reg);
+
        reg->isFree=0;
 
-//     debugLog ("%s of type %s\n", __FUNCTION__, debugLogRegType (type));
+       debugLog ("%s of type %s for register rIdx: %d (0x%x)\n", __FUNCTION__, debugLogRegType (type), dynrIdx-1, dynrIdx-1);
 
 //     fprintf(stderr,"%s:%d: %s\t%s addr= 0x%x\trIdx= 0x%02x isFree: %d\n",
 //             __FILE__, __LINE__, __FUNCTION__, reg->name, reg->address, reg->rIdx, reg->isFree);
@@ -507,6 +524,7 @@ allocReg (short type)
        if(reg) {
                reg->accessBank = 1;    /* this is a temporary register alloc in accessBank */
                reg->isLocal = 1;       /* this is a local frame register */
+//             reg->wasUsed = 1;
        }
        
        if (currFunc) {
@@ -542,6 +560,7 @@ pic16_dirregWithName (char *name)
   while(reg) {
 
     if(STRCASECMP(reg->name, name) == 0) {
+//     fprintf(stderr, "%s:%d: FOUND name = %s\thash = %d\n", __FUNCTION__, __LINE__, reg->name, hkey);
       return(reg);
     }
 
@@ -552,12 +571,129 @@ pic16_dirregWithName (char *name)
   return NULL; // name wasn't found in the hash table
 }
 
-static int IS_CONFIG_ADDRESS(int address)
+/*-----------------------------------------------------------------*/
+/* pic16_allocregWithName - search for register by name                    */
+/*-----------------------------------------------------------------*/
+regs *
+pic16_allocregWithName (char *name)
 {
+  int hkey;
+  regs *reg;
+
+  if(!name)
+    return NULL;
+
+  /* hash the name to get a key */
+
+  hkey = regname2key(name);
+
+//     fprintf(stderr, "%s:%d: name = %s\thash = %d\n", __FUNCTION__, __LINE__, name, hkey);
+
+  reg = hTabFirstItemWK(dynAllocRegNames, hkey);
+
+  while(reg) {
+
+    if(STRCASECMP(reg->name, name) == 0) {
+      return(reg);
+    }
+
+    reg = hTabNextItemWK (dynAllocRegNames);
+  
+  }
+
+  return NULL; // name wasn't found in the hash table
 
-  return address >= 0x300000 && address <= 0x300000d;
 }
 
+
+/*-----------------------------------------------------------------*/
+/* pic16_procregWithName - search for register by name                    */
+/*-----------------------------------------------------------------*/
+regs *
+pic16_procregWithName (char *name)
+{
+  int hkey;
+  regs *reg;
+
+  if(!name)
+    return NULL;
+
+  /* hash the name to get a key */
+
+  hkey = regname2key(name);
+
+//     fprintf(stderr, "%s:%d: name = %s\thash = %d\n", __FUNCTION__, __LINE__, name, hkey);
+
+  reg = hTabFirstItemWK(dynProcRegNames, hkey);
+
+  while(reg) {
+
+    if(STRCASECMP(reg->name, name) == 0) {
+      return(reg);
+    }
+
+    reg = hTabNextItemWK (dynProcRegNames);
+  
+  }
+
+  return NULL; // name wasn't found in the hash table
+
+}
+
+/*-----------------------------------------------------------------*/
+/* pic16_accessregWithName - search for register by name           */
+/*-----------------------------------------------------------------*/
+regs *
+pic16_accessregWithName (char *name)
+{
+  int hkey;
+  regs *reg;
+
+  if(!name)
+    return NULL;
+
+  /* hash the name to get a key */
+
+  hkey = regname2key(name);
+
+//     fprintf(stderr, "%s:%d: name = %s\thash = %d\n", __FUNCTION__, __LINE__, name, hkey);
+
+  reg = hTabFirstItemWK(dynAccessRegNames, hkey);
+
+  while(reg) {
+
+    if(STRCASECMP(reg->name, name) == 0) {
+      return(reg);
+    }
+
+    reg = hTabNextItemWK (dynAccessRegNames);
+  
+  }
+
+  return NULL; // name wasn't found in the hash table
+
+}
+
+regs *pic16_regWithName(char *name)
+{
+  regs *reg;
+
+       reg = pic16_dirregWithName( name );
+       if(reg)return reg;
+       
+       reg = pic16_procregWithName( name );
+       if(reg)return reg;
+       
+       reg = pic16_allocregWithName( name );
+       if(reg)return reg;
+
+       reg = pic16_accessregWithName( name );
+       if(reg)return reg;
+       
+  return NULL;
+}
+
+
 /*-----------------------------------------------------------------*/
 /* pic16_allocDirReg - allocates register of given type                  */
 /*-----------------------------------------------------------------*/
@@ -575,16 +711,50 @@ pic16_allocDirReg (operand *op )
 
        name = OP_SYMBOL (op)->rname[0] ? OP_SYMBOL (op)->rname : OP_SYMBOL (op)->name;
 
-       if(!SPEC_OCLS( OP_SYM_ETYPE(op))) {                                                                     // patch 13
-               if(pic16_debug_verbose)                                                                         //
-               {                                                                                               //
-                       fprintf(stderr, "%s:%d symbol %s(r:%s) is not assigned to a memmap\n", __FILE__, __LINE__,      //
-                               OP_SYMBOL(op)->name, OP_SYMBOL(op)->rname);                                                             //
-               }                                                                                               //
-               return NULL;                                                                                    //
-       }                                                                                                       // patch 13
 
-       debugLog ("%s symbol name %s\n", __FUNCTION__,name);
+       if(!SPEC_OCLS( OP_SYM_ETYPE(op))) {
+#if 1
+               if(pic16_debug_verbose)
+               {
+                       fprintf(stderr, "%s:%d symbol %s(r:%s) is not assigned to a memmap\n", __FILE__, __LINE__,
+                               OP_SYMBOL(op)->name, OP_SYMBOL(op)->rname);
+               }
+#endif
+               return NULL;
+       }
+
+       if(!IN_DIRSPACE( SPEC_OCLS( OP_SYM_ETYPE(op)))
+               || !IN_FARSPACE(SPEC_OCLS( OP_SYM_ETYPE(op))) ) {
+
+#if 0
+               if(pic16_debug_verbose) {
+                       fprintf(stderr, "dispace:%d farspace:%d codespace:%d regspace:%d stack:%d eeprom: %d regparm: %d isparm: %d\n",
+                               IN_DIRSPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
+                               IN_FARSPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
+                               IN_CODESPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
+                               IN_REGSP( SPEC_OCLS( OP_SYM_ETYPE(op))),
+                               IN_STACK( OP_SYM_ETYPE(op)),
+                               SPEC_OCLS(OP_SYM_ETYPE(op)) == eeprom,
+                               IS_REGPARM(OP_SYM_ETYPE(op)),
+                               IS_PARM(op));
+
+                       fprintf(stderr, "%s:%d symbol %s NOT in dirspace\n", __FILE__, __LINE__,
+                       OP_SYMBOL(op)->name);
+               }
+#endif
+
+       }
+
+
+
+       if (IS_CODE ( OP_SYM_ETYPE(op)) ) {
+//             fprintf(stderr, "%s:%d sym: %s in codespace\n", __FUNCTION__, __LINE__, OP_SYMBOL(op)->name);
+               return NULL;
+       }
+
+       if(IS_ITEMP(op))return NULL;
+       
+       debugLog ("%s:%d symbol name %s\n", __FUNCTION__, __LINE__, name);
 //     fprintf(stderr, "%s symbol name %s\n", __FUNCTION__,name);
 
        {
@@ -612,27 +782,8 @@ pic16_allocDirReg (operand *op )
                debugAopGet(NULL, op);
        }
 
-       if (IS_CODE ( OP_SYM_ETYPE(op)) )
-               return NULL;
-
-       /* First, search the hash table to see if there is a register with this name */
-       if (SPEC_ABSA ( OP_SYM_ETYPE(op)) && !(IS_BITVAR (OP_SYM_ETYPE(op))) ) {
-               reg=NULL;
-//             reg = regWithIdx (pic16_dynProcessorRegs, SPEC_ADDR ( OP_SYM_ETYPE(op)), 1);
 
-#if 0
-               if(!reg) 
-                       fprintf(stderr,"%s:%d: ralloc %s is at fixed address but not a processor reg, addr=0x%x\n",
-                                       __FUNCTION__, __LINE__, name, SPEC_ADDR ( OP_SYM_ETYPE(op)));
-               else
-                       fprintf(stderr,"%s:%d: ralloc %s at fixed address has already been declared, addr=0x%x\n",
-                                       __FUNCTION__, __LINE__, name, SPEC_ADDR ( OP_SYM_ETYPE(op)));
-#endif
-       } else {
-//             fprintf(stderr,"ralloc:%d %s \n", __LINE__,name);
-    
-               reg = pic16_dirregWithName(name);
-       }
+       reg = pic16_dirregWithName(name);
 
        if(!reg) {
          int address = 0;
@@ -647,69 +798,74 @@ pic16_allocDirReg (operand *op )
                /* Register wasn't found in hash, so let's create
                 * a new one and put it in the hash table AND in the 
                 * dynDirectRegNames set */
-               if(IN_CODESPACE( SPEC_OCLS( OP_SYM_ETYPE(op)))) {
-                       if(pic16_debug_verbose)
-                               fprintf(stderr, "%s:%d symbol %s in codespace\n", __FILE__, __LINE__,
-                                       OP_SYMBOL(op)->name);
+               if(IS_CODE(OP_SYM_ETYPE(op)) || IN_CODESPACE( SPEC_OCLS( OP_SYM_ETYPE(op)))) {
                        debugLog("%s:%d sym: %s in codespace\n", __FUNCTION__, __LINE__, OP_SYMBOL(op)->name);
                  return NULL;
                }
 
-               if(!IS_CONFIG_ADDRESS(address)) {
-//                     fprintf(stderr,"%s:allocating new reg %s\n",__FUNCTION__, name);
 
-                       /* this is an error, why added? -- VR */
-//                     if(SPEC_SCLS(OP_SYM_ETYPE(op)))regtype = REG_SFR;
+#if 0
+               if(OP_SYMBOL(op)->onStack) {
+                       fprintf(stderr, "%s:%d onStack %s offset: %d\n", __FILE__, __LINE__,
+                               OP_SYMBOL(op)->name, OP_SYMBOL(op)->stack);
+               }
+#endif
 
-                       if(OP_SYMBOL(op)->onStack) {
-//                             fprintf(stderr, "%s:%d onStack %s\n", __FILE__, __LINE__, OP_SYMBOL(op)->name);
-                               OP_SYMBOL(op)->onStack = 0;
-                               SPEC_OCLS(OP_SYM_ETYPE(op)) = data;
-                               regtype = REG_GPR;
-                       }
+               if(!IN_DIRSPACE( SPEC_OCLS( OP_SYM_ETYPE(op)))
+                       || !IN_FARSPACE(SPEC_OCLS( OP_SYM_ETYPE(op))) ) {
 
-                       if(!IN_DIRSPACE( SPEC_OCLS( OP_SYM_ETYPE(op)))) {                                               // patch 13
-                               if(pic16_debug_verbose)                                                                 //
-                               {                                                                                       //
-                                       fprintf(stderr, "dispace:%d farspace:%d codespace:%d regspace:%d stack:%d\n",
-                                               IN_DIRSPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
-                                               IN_FARSPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
-                                               IN_CODESPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
-                                               IN_REGSP( SPEC_OCLS( OP_SYM_ETYPE(op))),
-                                               IN_STACK( OP_SYM_ETYPE(op)));
-
-                                       fprintf(stderr, "%s:%d symbol %s NOT in dirspace\n", __FILE__, __LINE__,        //
-                                               OP_SYMBOL(op)->name);                                                   //
-                               }                                                                                       //
-//                             return NULL;                                                                            //
-                       }                                                                                               // patch 13
-
-                       reg = newReg(regtype, PO_DIR, rDirectIdx++, name,getSize (OP_SYMBOL (op)->type),0, op);
-                       debugLog ("%d  -- added %s to hash, size = %d\n", __LINE__, name,reg->size);
-
-//                     hTabAddItem(&dynDirectRegNames, regname2key(name), reg);        /* commented out */
-
-//                     if (SPEC_ABSA ( OP_SYM_ETYPE(op)) ) {
-//                             fprintf(stderr, " ralloc.c at fixed address: %s - changing to REG_SFR\n",name);
-//                             reg->type = REG_SFR;
-//                     }
-
-                       if (IS_BITVAR (OP_SYM_ETYPE(op))) {
-//                             fprintf(stderr, "%s:%d adding %s in bit registers\n", __FILE__, __LINE__, reg->name);
-                               addSet(&pic16_dynDirectBitRegs, reg);
-                               reg->isBitField = 1;
-                       } else {
-//                             fprintf(stderr, "%s:%d adding %s in direct registers\n", __FILE__, __LINE__, reg->name);
-//                             addSet(&pic16_dynDirectRegs, reg);
-                               checkAddReg(&pic16_dynDirectRegs, reg);
+#if 0
+                       if(pic16_debug_verbose)
+                       {
+                               fprintf(stderr, "dispace:%d farspace:%d codespace:%d regspace:%d stack:%d eeprom: %d\n",
+                                       IN_DIRSPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
+                                       IN_FARSPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
+                                       IN_CODESPACE( SPEC_OCLS( OP_SYM_ETYPE(op))),
+                                       IN_REGSP( SPEC_OCLS( OP_SYM_ETYPE(op))),
+                                       IN_STACK( OP_SYM_ETYPE(op)),
+                                       SPEC_OCLS(OP_SYM_ETYPE(op)) == eeprom);
+
+                                       fprintf(stderr, "%s:%d symbol %s NOT in dirspace\n", __FILE__, __LINE__,
+                                       OP_SYMBOL(op)->name);
                        }
-       
+#endif
+               }
+
+               reg = newReg(regtype, PO_DIR, rDirectIdx++, name,getSize (OP_SYMBOL (op)->type),0, op);
+               debugLog ("%d  -- added %s to hash, size = %d\n", __LINE__, name,reg->size);
+
+               if( SPEC_SCLS( OP_SYM_ETYPE( op ) ) == S_REGISTER ) {
+                       fprintf(stderr, "%s:%d symbol %s is declared as register\n", __FILE__, __LINE__,
+                               name);
+                               
+                       reg->accessBank = 1;
+                       checkAddReg(&pic16_dynAccessRegs, reg);
+                       hTabAddItem(&dynAccessRegNames, regname2key(name), reg);
+                       
+                 return (reg);
+               }
+
+
+//             if (SPEC_ABSA ( OP_SYM_ETYPE(op)) ) {
+//                     fprintf(stderr, " ralloc.c at fixed address: %s - changing to REG_SFR\n",name);
+//                     reg->type = REG_SFR;
+//             }
+
+               if (IS_BITVAR (OP_SYM_ETYPE(op))) {
+//                     fprintf(stderr, "%s:%d adding %s in bit registers\n", __FILE__, __LINE__, reg->name);
+                       addSet(&pic16_dynDirectBitRegs, reg);
+                       reg->isBitField = 1;
                } else {
-                       debugLog ("  -- %s is declared at address 0x30000x\n",name);
-                       fprintf(stderr, "  -- %s is declared at address 0x30000x\n",name);
-       
-                 return NULL;
+//                     fprintf(stderr, "%s:%d adding %s in direct registers\n", __FILE__, __LINE__, reg->name);
+//                     addSet(&pic16_dynDirectRegs, reg);
+
+                       checkAddReg(&pic16_dynDirectRegs, reg);
                }
+       
+       } else {
+//             debugLog ("  -- %s is declared at address 0x30000x\n",name);
+         return (reg);                 /* This was NULL before, but since we found it
+                                        * why not just return it?! */
        }
 
        if (SPEC_ABSA ( OP_SYM_ETYPE(op)) ) {
@@ -731,7 +887,7 @@ pic16_allocDirReg (operand *op )
 /* pic16_allocRegByName - allocates register of given type                  */
 /*-----------------------------------------------------------------*/
 regs *
-pic16_allocRegByName (char *name, int size)
+pic16_allocRegByName (char *name, int size, operand *op)
 {
 
   regs *reg;
@@ -749,11 +905,13 @@ pic16_allocRegByName (char *name, int size)
     /* Register wasn't found in hash, so let's create
      * a new one and put it in the hash table AND in the 
      * dynDirectRegNames set */
-    //fprintf (stderr,"%s symbol name %s\n", __FUNCTION__,name);
-    reg = newReg(REG_GPR, PO_DIR, rDirectIdx++, name,size,0, NULL);
+
+       fprintf (stderr,"%s:%d symbol name %s\tregop= %p\n", __FUNCTION__, __LINE__, name, op);
+
+    reg = newReg(REG_GPR, PO_DIR, rDirectIdx++, name,size,0, op);
 
     debugLog ("%d  -- added %s to hash, size = %d\n", __LINE__, name,reg->size);
-    //fprintf(stderr, "  -- added %s to hash, size = %d\n", name,reg->size);
+       //fprintf(stderr, "  -- added %s to hash, size = %d\n", name,reg->size);
 
     //hTabAddItem(&dynDirectRegNames, regname2key(name), reg); /* initially commented out */
     addSet(&pic16_dynDirectRegs, reg);
@@ -794,7 +952,7 @@ regs *pic16_typeRegWithIdx (int idx, int type, int fixed)
     }
     break;
   case REG_SFR:
-    if( (dReg = regWithIdx ( pic16_dynProcessorRegs, idx, fixed)) != NULL ) {
+    if( (dReg = regWithIdx ( pic16_dynProcessorRegs, idx, 1)) != NULL ) {
       debugLog ("Found a Processor Register!\n");
       return dReg;
     }
@@ -823,8 +981,10 @@ pic16_regWithIdx (int idx)
   if( (dReg = pic16_typeRegWithIdx(idx,REG_SFR,0)) != NULL)
     return dReg;
 
+#if 0
   if( (dReg = pic16_typeRegWithIdx(idx,REG_STK,0)) != NULL)
     return dReg;
+#endif
 
   return NULL;
 }
@@ -846,7 +1006,7 @@ pic16_allocWithIdx (int idx)
     debugLog ("Found a Dynamic Register!\n");
   } else if( (dReg = regWithIdx ( pic16_dynStackRegs, idx,0)) != NULL ) {
     debugLog ("Found a Stack Register!\n");
-  } else if( (dReg = regWithIdx ( pic16_dynProcessorRegs, idx,0)) != NULL ) {
+  } else if( (dReg = regWithIdx ( pic16_dynProcessorRegs, idx,1)) != NULL ) {
     debugLog ("Found a Processor Register!\n");
     fprintf(stderr, "Found a processor register! %s\n", dReg->name);
   } else if( (dReg = regWithIdx ( pic16_dynInternalRegs, idx,0)) != NULL ) {
@@ -972,11 +1132,15 @@ static void writeSetUsedRegs(FILE *of, set *dRegs)
 extern void pic16_groupRegistersInSection(set *regset);
 
 extern void pic16_dump_equates(FILE *of, set *equs);
+extern void pic16_dump_access(FILE *of, set *section);
 //extern void pic16_dump_map(void);
-extern void pic16_dump_section(FILE *of, set *section, int fix);
+extern void pic16_dump_usection(FILE *of, set *section, int fix);
+extern void pic16_dump_isection(FILE *of, set *section, int fix);
 extern void pic16_dump_int_registers(FILE *of, set *section);
 extern void pic16_dump_idata(FILE *of, set *idataSymSet);
 
+extern void pic16_dump_gsection(FILE *of, set *sections);
+
 static void packBits(set *bregs)
 {
   set *regset;
@@ -1039,137 +1203,56 @@ static void packBits(set *bregs)
       
 }
 
-
-
-#if 0
-static void bitEQUs(FILE *of, set *bregs)
-{
-  regs *breg,*bytereg;
-  int bit_no=0;
-
-  //fprintf(stderr," %s\n",__FUNCTION__);
-  for (breg = setFirstItem(bregs) ; breg ;
-       breg = setNextItem(bregs)) {
-
-    //fprintf(stderr,"bit reg: %s\n",breg->name);
-
-    bytereg = breg->reg_alias;
-    if(bytereg)
-      fprintf (of, "%s\tEQU\t( (%s<<3)+%d)\n",
-              breg->name,
-              bytereg->name,
-              breg->rIdx & 0x0007);
-
-    else {
-      fprintf(stderr, "bit field is not assigned to a register\n");
-      fprintf (of, "%s\tEQU\t( (bitfield%d<<3)+%d)\n",
-              breg->name,
-              bit_no>>3,
-              bit_no & 0x0007);
-
-      bit_no++;
-    }
-  }
-      
-}
-
-static void aliasEQUs(FILE *of, set *fregs, int use_rIdx)
-{
-  regs *reg;
-
-
-  for (reg = setFirstItem(fregs) ; reg ;
-       reg = setNextItem(fregs)) {
-
-    if(!reg->isEmitted && reg->wasUsed) {
-      if(use_rIdx) {
-        if (reg->type != REG_SFR) {
-         fprintf (of, "%s\tEQU\t0x%03x\n",
-                  reg->name,
-                  reg->rIdx);
-        }
-      }
-      else
-       fprintf (of, "%s\tEQU\t0x%03x\n",
-                reg->name,
-                reg->address);
-    }
-  }
-      
-}
-#endif
-
 void pic16_writeUsedRegs(FILE *of) 
 {
        packBits(pic16_dynDirectBitRegs);
 
+//     fprintf(stderr, "%s: pic16_dynAllocRegs\n", __FUNCTION__);
        pic16_groupRegistersInSection(pic16_dynAllocRegs);
+
+//     fprintf(stderr, "%s: pic16_dynInternalRegs\n", __FUNCTION__);
        pic16_groupRegistersInSection(pic16_dynInternalRegs);
+
+//     fprintf(stderr, "%s: pic16_dynStackRegs\n", __FUNCTION__);
        pic16_groupRegistersInSection(pic16_dynStackRegs);
+
+//     fprintf(stderr, "%s: pic16_dynDirectRegs\n", __FUNCTION__);
        pic16_groupRegistersInSection(pic16_dynDirectRegs);
+
+//     fprintf(stderr, "%s: pic16_dynDirectBitsRegs\n", __FUNCTION__);
        pic16_groupRegistersInSection(pic16_dynDirectBitRegs);
+
+//     fprintf(stderr, "%s: pic16_dynProcessorRegs\n", __FUNCTION__);
        pic16_groupRegistersInSection(pic16_dynProcessorRegs);
        
+//     fprintf(stderr, "%s: pic16_dynAccessRegs\n", __FUNCTION__);
+       pic16_groupRegistersInSection(pic16_dynAccessRegs);
        
-#if 0
-       pic16_assignFixedRegisters(pic16_dynAllocRegs);
-       pic16_assignFixedRegisters(pic16_dynStackRegs);
-       pic16_assignFixedRegisters(pic16_dynDirectRegs);
-       pic16_assignFixedRegisters(pic16_dynProcessorRegs);
-
-       pic16_assignRelocatableRegisters(pic16_dynDirectBitRegs, 0);
-       pic16_assignRelocatableRegisters(pic16_dynInternalRegs,0);
-       pic16_assignRelocatableRegisters(pic16_dynAllocRegs,0);
-       pic16_assignRelocatableRegisters(pic16_dynStackRegs,0);
-       pic16_assignRelocatableRegisters(pic16_dynDirectRegs,0);
-#endif
-
-//     pic16_dump_map();
-//     pic16_dump_cblock(of);
-
        /* dump equates */
        pic16_dump_equates(of, pic16_equ_data);
 
+//     pic16_dump_esection(of, pic16_rel_eedata, 0);
+//     pic16_dump_esection(of, pic16_fix_eedata, 0);
+
+       /* dump access bank symbols */
+       pic16_dump_access(of, pic16_acs_udata);
+
        /* dump initialised data */
-       pic16_dump_idata(of, idataSymSet);
+       pic16_dump_isection(of, rel_idataSymSet, 0);
+       pic16_dump_isection(of, fix_idataSymSet, 1);
 
        /* dump internal registers */
        pic16_dump_int_registers(of, pic16_int_regs);
        
+       /* dump generic section variables */
+       pic16_dump_gsection(of, sectNames);
+
        /* dump other variables */
-       pic16_dump_section(of, pic16_rel_udata, 0);
-       pic16_dump_section(of, pic16_fix_udata, 1);
+       pic16_dump_usection(of, pic16_rel_udata, 0);
+       pic16_dump_usection(of, pic16_fix_udata, 1);
        
 }
 
-#if 0
-/*-----------------------------------------------------------------*/
-/* allDefsOutOfRange - all definitions are out of a range          */
-/*-----------------------------------------------------------------*/
-static bool
-allDefsOutOfRange (bitVect * defs, int fseq, int toseq)
-{
-  int i;
-
-  debugLog ("%s\n", __FUNCTION__);
-  if (!defs)
-    return TRUE;
-
-  for (i = 0; i < defs->size; i++)
-    {
-      iCode *ic;
-
-      if (bitVectBitValue (defs, i) &&
-         (ic = hTabItemWithKey (iCodehTab, i)) &&
-         (ic->seq >= fseq && ic->seq <= toseq))
-
-       return FALSE;
-
-    }
-
-  return TRUE;
-}
-#endif
 
 /*-----------------------------------------------------------------*/
 /* computeSpillable - given a point find the spillable live ranges */
@@ -1654,7 +1737,9 @@ selectSpil (iCode * ic, eBBlock * ebp, symbol * forSym)
 
       /* check if there are any live ranges that not
          used in the remainder of the block */
-      if (!_G.blockSpil && (selectS = liveRangesWith (lrcs, notUsedInRemaining, ebp, ic)))
+      if (!_G.blockSpil &&
+          !isiCodeInFunctionCall (ic) &&       
+          (selectS = liveRangesWith (lrcs, notUsedInRemaining, ebp, ic)))
        {
          sym = leastUsedLR (selectS);
          if (!sym->remat)
@@ -1890,6 +1975,13 @@ deassignLRs (iCode * ic, eBBlock * ebp)
       if (!bitVectBitValue (_G.regAssigned, sym->key))
        continue;
 
+      /* special case for shifting: there is a case where shift count
+       * can be allocated in the same register as the result, so do not
+       * free right registers if same as result registers, cause genShiftLeft
+       * will fail -- VR */
+       if(ic->op == LEFT_OP)
+         continue;
+
       /* special case check if this is an IFX &
          the privious one was a pop and the 
          previous one was not spilt then keep track
@@ -1920,6 +2012,7 @@ deassignLRs (iCode * ic, eBBlock * ebp)
              (result = OP_SYMBOL (IC_RESULT (ic))) &&  /* has a result */
              result->liveTo > ic->seq &&       /* and will live beyond this */
              result->liveTo <= ebp->lSeq &&    /* does not go beyond this block */
+             result->liveFrom == ic->seq &&    /* does not start before here */
              result->regType == sym->regType &&        /* same register types */
              result->nRegs &&  /* which needs registers */
              !result->isspilt &&       /* and does not already have them */
@@ -2109,6 +2202,15 @@ serialRegAssign (eBBlock ** ebbs, int count)
 
          debugLog ("  op: %s\n", decodeOp (ic->op));
 
+               if(IC_RESULT(ic) && !IS_ITEMP( IC_RESULT(ic)))
+                       pic16_allocDirReg(IC_RESULT(ic));
+
+               if(IC_LEFT(ic) && !IS_ITEMP( IC_LEFT(ic)))
+                       pic16_allocDirReg(IC_LEFT(ic));
+
+               if(IC_RIGHT(ic) && !IS_ITEMP( IC_RIGHT(ic)))
+                       pic16_allocDirReg(IC_RIGHT(ic));
+
          /* if this is an ipop that means some live
             range will have to be assigned again */
          if (ic->op == IPOP)
@@ -2174,6 +2276,17 @@ serialRegAssign (eBBlock ** ebbs, int count)
 
                }
 
+             /* If the live range preceeds the point of definition 
+                then ideally we must take into account registers that 
+                have been allocated after sym->liveFrom but freed
+                before ic->seq. This is complicated, so spill this
+                symbol instead and let fillGaps handle the allocation. */
+             if (sym->liveFrom < ic->seq)
+               {
+                   spillThis (sym);
+                   continue;                 
+               }
+
              /* if it has a spillocation & is used less than
                 all other live ranges then spill this */
                if (willCS) {
@@ -2211,7 +2324,7 @@ serialRegAssign (eBBlock ** ebbs, int count)
              /* else we assign registers to it */
              _G.regAssigned = bitVectSetBit (_G.regAssigned, sym->key);
 
-             debugLog ("  %d - \n", __LINE__);
+             debugLog ("  %d - nRegs: %d\n", __LINE__, sym->nRegs);
              if(debugF) 
                bitVectDebugOn(_G.regAssigned, debugF);
 
@@ -2582,11 +2695,13 @@ regTypeNum ()
 
        if (ptrPseudoSymSafe (sym, ic)) {
           
+         symbol *psym;
+         
          debugLog ("  %d - \n", __LINE__);
              
          /* create a psuedo symbol & force a spil */
          //X symbol *psym = newSymbol (rematStr (OP_SYMBOL (IC_LEFT (ic))), 1);
-         symbol *psym = rematStr (OP_SYMBOL (IC_LEFT (ic)));
+         psym = rematStr (OP_SYMBOL (IC_LEFT (ic)));
          psym->type = sym->type;
          psym->etype = sym->etype;
          psym->psbase = ptrBaseRematSym (OP_SYMBOL (IC_LEFT (ic)));
@@ -2777,32 +2892,8 @@ packRegsForAssign (iCode * ic, eBBlock * ebp)
   debugAopGet ("  left:", IC_LEFT (ic));
   debugAopGet ("  right:", IC_RIGHT (ic));
 
-  /* if this is at an absolute address, then get the address. */
-  if (SPEC_ABSA ( OP_SYM_ETYPE(IC_RESULT(ic))) ) {
-    if(IS_CONFIG_ADDRESS( SPEC_ADDR ( OP_SYM_ETYPE(IC_RESULT(ic))))) {
-      debugLog ("  %d - found config word declaration\n", __LINE__);
-      if(IS_VALOP(IC_RIGHT(ic))) {
-       debugLog ("  setting config word to %x\n", 
-                 (int) floatFromVal (IC_RIGHT(ic)->operand.valOperand));
-       fprintf(stderr, "  setting config word to %x\n", 
-                 (int) floatFromVal (IC_RIGHT(ic)->operand.valOperand));
-       pic16_assignConfigWordValue(  SPEC_ADDR ( OP_SYM_ETYPE(IC_RESULT(ic))),
-                               (int) floatFromVal (IC_RIGHT(ic)->operand.valOperand));
-      }
-
+//     fprintf(stderr, "%s:%d symbol = %s\n", __FILE__, __LINE__, OP_SYMBOL( IC_RESULT(ic))->name);
 
-       debugLog(" %d\n", __LINE__);
-
-      /* remove the assignment from the iCode chain. */
-
-      remiCodeFromeBBlock (ebp, ic);
-      bitVectUnSetBit(OP_SYMBOL(IC_RESULT(ic))->defs,ic->key);
-      hTabDeleteItem (&iCodehTab, ic->key, ic, DELETE_ITEM, NULL);
-
-      return 1;
-
-    }
-  }
        debugLog(" %d - actuall processing\n", __LINE__ );
 
   if (!IS_ITEMP (IC_RESULT (ic))) {
@@ -2810,12 +2901,6 @@ packRegsForAssign (iCode * ic, eBBlock * ebp)
     debugLog ("  %d - result is not temp\n", __LINE__);
   }
 
-#if 0
-  if (IC_LEFT (ic) && !IS_ITEMP (IC_LEFT (ic))) {
-    debugLog ("  %d - left is not temp, allocating\n", __LINE__);
-    pic16_allocDirReg(IC_LEFT (ic));
-  }
-#endif
 
 /* See BUGLOG0001 - VR */
 #if 1
@@ -2867,21 +2952,6 @@ packRegsForAssign (iCode * ic, eBBlock * ebp)
 
        debugLog("%d\tSearching for iTempNN\n", __LINE__);
 
-#if 0
-       if(IS_TRUE_SYMOP( IC_RESULT(dic))) {
-               debugLog("%d - dic result is a TRUE_SYMOP\n", __LINE__);
-               debugAopGet(" result is ", IC_RESULT(dic));
-       }
-       if(IS_TRUE_SYMOP( IC_LEFT(dic))) {
-               debugLog("%d - dic left is a SYMOP\n", __LINE__);
-               debugAopGet("   left is ", IC_LEFT(dic));
-       }
-       if(IS_TRUE_SYMOP( IC_RIGHT(dic))) {
-               debugLog("%d - dic right is a SYMOP\n", __LINE__);
-               debugAopGet("  right is ", IC_RIGHT(dic));
-       }
-#endif
-
       if (IS_TRUE_SYMOP (IC_RESULT (dic)) &&
          IS_OP_VOLATILE (IC_RESULT (dic)))
        {
@@ -2890,27 +2960,6 @@ packRegsForAssign (iCode * ic, eBBlock * ebp)
          break;
        }
 
-#if 0
-      if (IS_TRUE_SYMOP( IC_RIGHT (dic)) &&
-               IS_OP_VOLATILE (IC_RIGHT(dic)))
-       {
-         debugLog ("  %d - dic right is VOLATILE\n", __LINE__);
-         dic = NULL;
-         break;
-       }
-#endif
-
-#if 0
-      if (IS_TRUE_SYMOP( IC_LEFT (dic)) &&
-               IS_OP_VOLATILE (IC_LEFT(dic)))
-       {
-         debugLog ("  %d - dic left is VOLATILE\n", __LINE__);
-         dic = NULL;
-         break;
-       }
-#endif
-
-
 #if 1
       if( IS_SYMOP( IC_RESULT(dic)) &&
        IS_BITFIELD( OP_SYMBOL(IC_RESULT(dic))->etype ) ) {
@@ -2988,14 +3037,6 @@ packRegsForAssign (iCode * ic, eBBlock * ebp)
   if (OP_SYMBOL (IC_RESULT (ic))->onStack ||
       OP_SYMBOL (IC_RESULT (ic))->iaccess)
     {
-
-#if 0
-       /* clear the onStack flag, the port doesn't support it yet! FIXME */
-       if(OP_SYMBOL(IC_RESULT(ic))->onStack)
-               OP_SYMBOL(IC_RESULT(ic))->onStack = 0;
-#endif
-       
-
       /* the operation has only one symbol
          operator then we can pack */
       if ((IC_LEFT (dic) && !IS_SYMOP (IC_LEFT (dic))) ||
@@ -3092,12 +3133,6 @@ findAssignToSym (operand * op, iCode * ic)
          if ((ic->op == '+' || ic->op == '-') &&
              OP_SYMBOL (IC_RIGHT (dic))->onStack)
            {
-
-#if 0
-               if(OP_SYMBOL(IC_RESULT(ic))->onStack)
-                       OP_SYMBOL(IC_RESULT(ic))->onStack = 0;
-#endif
-
              if (IC_RESULT (ic)->key != IC_RIGHT (dic)->key &&
                  IC_LEFT (ic)->key != IC_RIGHT (dic)->key &&
                  IC_RIGHT (ic)->key != IC_RIGHT (dic)->key)
@@ -4115,9 +4150,10 @@ pic16_assignRegisters (eBBlock ** ebbs, int count)
   /* and serially allocate registers */
   serialRegAssign (ebbs, count);
 
-//  debugLog ("ebbs after serialRegAssign:\n");
-//  dumpEbbsToDebug (ebbs, count);
-
+#if 0
+  debugLog ("ebbs after serialRegAssign:\n");
+  dumpEbbsToDebug (ebbs, count);
+#endif
 
   //pic16_freeAllRegs();