openocd: fix SPDX tag format for files .c
[fw/openocd] / src / jtag / drivers / ulink.c
index 82663392c68e1819d238d0fc7a1fd26570bc0706..fd29f126e2de769c9d33b28bec6e43532b797b3e 100644 (file)
@@ -1,21 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
 /***************************************************************************
- *   Copyright (C) 2011 by Martin Schmoelzer                               *
+ *   Copyright (C) 2011-2013 by Martin Schmoelzer                          *
  *   <martin.schmoelzer@student.tuwien.ac.at>                              *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
 #endif
 
 #include <math.h>
+#include "helper/system.h"
 #include <jtag/interface.h>
 #include <jtag/commands.h>
 #include <target/image.h>
-#include "usb_common.h"
+#include <libusb.h>
+#include "libusb_helper.h"
 #include "OpenULINK/include/msgtypes.h"
 
 /** USB Vendor ID of ULINK device in unconfigured state (no firmware loaded
 /** USB interface number */
 #define USB_INTERFACE            0
 
-/** libusb timeout in ms */
-#define USB_TIMEOUT              5000
-
 /** Delay (in microseconds) to wait while EZ-USB performs ReNumeration. */
 #define ULINK_RENUMERATION_DELAY 1500000
 
 /** Default location of OpenULINK firmware image. */
-#define ULINK_FIRMWARE_FILE      PKGLIBDIR "/OpenULINK/ulink_firmware.hex"
+#define ULINK_FIRMWARE_FILE      PKGDATADIR "/OpenULINK/ulink_firmware.hex"
 
 /** Maximum size of a single firmware section. Entire EZ-USB code space = 8kB */
 #define SECTION_BUFFERSIZE       8192
@@ -123,14 +109,14 @@ enum ulink_delay_type {
  * The last command sets #needs_postprocessing to true.
  */
 struct ulink_cmd {
-       uint8_t id;             /* /< ULINK command ID */
+       uint8_t id;                     /**< ULINK command ID */
 
-       uint8_t *payload_out;   /* /< OUT direction payload data */
-       uint8_t payload_out_size;       /* /< OUT direction payload size for this command */
+       uint8_t *payload_out;           /**< OUT direction payload data */
+       uint8_t payload_out_size;       /**< OUT direction payload size for this command */
 
-       uint8_t *payload_in_start;      /* /< Pointer to first element of IN payload array */
-       uint8_t *payload_in;    /* /< Pointer where IN payload shall be stored */
-       uint8_t payload_in_size;/* /< IN direction payload size for this command */
+       uint8_t *payload_in_start;      /**< Pointer to first element of IN payload array */
+       uint8_t *payload_in;            /**< Pointer where IN payload shall be stored */
+       uint8_t payload_in_size;        /**< IN direction payload size for this command */
 
        /** Indicates if this command needs post-processing */
        bool needs_postprocessing;
@@ -141,60 +127,60 @@ struct ulink_cmd {
        /** Pointer to corresponding OpenOCD command for post-processing */
        struct jtag_command *cmd_origin;
 
-       struct ulink_cmd *next; /* /< Pointer to next command (linked list) */
+       struct ulink_cmd *next;         /**< Pointer to next command (linked list) */
 };
 
 /** Describes one driver instance */
 struct ulink {
-       struct usb_dev_handle *usb_handle;
+       struct libusb_context *libusb_ctx;
+       struct libusb_device_handle *usb_device_handle;
        enum ulink_type type;
 
-       int delay_scan_in;      /* /< Delay value for SCAN_IN commands */
-       int delay_scan_out;     /* /< Delay value for SCAN_OUT commands */
-       int delay_scan_io;      /* /< Delay value for SCAN_IO commands */
-       int delay_clock_tck;    /* /< Delay value for CLOCK_TMS commands */
-       int delay_clock_tms;    /* /< Delay value for CLOCK_TCK commands */
+       unsigned int ep_in;             /**< IN endpoint number */
+       unsigned int ep_out;            /**< OUT endpoint number */
+
+       int delay_scan_in;      /**< Delay value for SCAN_IN commands */
+       int delay_scan_out;     /**< Delay value for SCAN_OUT commands */
+       int delay_scan_io;      /**< Delay value for SCAN_IO commands */
+       int delay_clock_tck;    /**< Delay value for CLOCK_TMS commands */
+       int delay_clock_tms;    /**< Delay value for CLOCK_TCK commands */
 
-       int commands_in_queue;  /* /< Number of commands in queue */
-       struct ulink_cmd *queue_start;  /* /< Pointer to first command in queue */
-       struct ulink_cmd *queue_end;    /* /< Pointer to last command in queue */
+       int commands_in_queue;          /**< Number of commands in queue */
+       struct ulink_cmd *queue_start;  /**< Pointer to first command in queue */
+       struct ulink_cmd *queue_end;    /**< Pointer to last command in queue */
 };
 
 /**************************** Function Prototypes *****************************/
 
 /* USB helper functions */
-int ulink_usb_open(struct ulink **device);
-int ulink_usb_close(struct ulink **device);
+static int ulink_usb_open(struct ulink **device);
+static int ulink_usb_close(struct ulink **device);
 
 /* ULINK MCU (Cypress EZ-USB) specific functions */
-int ulink_cpu_reset(struct ulink *device, char reset_bit);
-int ulink_load_firmware_and_renumerate(struct ulink **device, char *filename,
+static int ulink_cpu_reset(struct ulink *device, unsigned char reset_bit);
+static int ulink_load_firmware_and_renumerate(struct ulink **device, const char *filename,
                uint32_t delay);
-int ulink_load_firmware(struct ulink *device, char *filename);
-int ulink_write_firmware_section(struct ulink *device,
+static int ulink_load_firmware(struct ulink *device, const char *filename);
+static int ulink_write_firmware_section(struct ulink *device,
                struct image *firmware_image, int section_index);
 
 /* Generic helper functions */
-void ulink_print_signal_states(uint8_t input_signals, uint8_t output_signals);
+static void ulink_print_signal_states(uint8_t input_signals, uint8_t output_signals);
 
 /* OpenULINK command generation helper functions */
-int ulink_allocate_payload(struct ulink_cmd *ulink_cmd, int size,
+static int ulink_allocate_payload(struct ulink_cmd *ulink_cmd, int size,
                enum ulink_payload_direction direction);
 
 /* OpenULINK command queue helper functions */
-int ulink_get_queue_size(struct ulink *device,
+static int ulink_get_queue_size(struct ulink *device,
                enum ulink_payload_direction direction);
-void ulink_clear_queue(struct ulink *device);
-int ulink_append_queue(struct ulink *device, struct ulink_cmd *ulink_cmd);
-int ulink_execute_queued_commands(struct ulink *device, int timeout);
-
-#ifdef _DEBUG_JTAG_IO_
-const char *ulink_cmd_id_string(uint8_t id);
-void ulink_print_command(struct ulink_cmd *ulink_cmd);
-void ulink_print_queue(struct ulink *device);
-#endif
+static void ulink_clear_queue(struct ulink *device);
+static int ulink_append_queue(struct ulink *device, struct ulink_cmd *ulink_cmd);
+static int ulink_execute_queued_commands(struct ulink *device, int timeout);
+
+static void ulink_print_queue(struct ulink *device);
 
-int ulink_append_scan_cmd(struct ulink *device,
+static int ulink_append_scan_cmd(struct ulink *device,
                enum scan_type scan_type,
                int scan_size_bits,
                uint8_t *tdi,
@@ -206,42 +192,41 @@ int ulink_append_scan_cmd(struct ulink *device,
                uint8_t tms_sequence_end,
                struct jtag_command *origin,
                bool postprocess);
-int ulink_append_clock_tms_cmd(struct ulink *device, uint8_t count,
+static int ulink_append_clock_tms_cmd(struct ulink *device, uint8_t count,
                uint8_t sequence);
-int ulink_append_clock_tck_cmd(struct ulink *device, uint16_t count);
-int ulink_append_get_signals_cmd(struct ulink *device);
-int ulink_append_set_signals_cmd(struct ulink *device, uint8_t low,
+static int ulink_append_clock_tck_cmd(struct ulink *device, uint16_t count);
+static int ulink_append_get_signals_cmd(struct ulink *device);
+static int ulink_append_set_signals_cmd(struct ulink *device, uint8_t low,
                uint8_t high);
-int ulink_append_sleep_cmd(struct ulink *device, uint32_t us);
-int ulink_append_configure_tck_cmd(struct ulink *device,
+static int ulink_append_sleep_cmd(struct ulink *device, uint32_t us);
+static int ulink_append_configure_tck_cmd(struct ulink *device,
                int delay_scan_in,
                int delay_scan_out,
                int delay_scan_io,
                int delay_tck,
                int delay_tms);
-int ulink_append_led_cmd(struct ulink *device, uint8_t led_state);
-int ulink_append_test_cmd(struct ulink *device);
+static int __attribute__((unused)) ulink_append_led_cmd(struct ulink *device, uint8_t led_state);
+static int ulink_append_test_cmd(struct ulink *device);
 
 /* OpenULINK TCK frequency helper functions */
-int ulink_calculate_delay(enum ulink_delay_type type, long f, int *delay);
-int ulink_calculate_frequency(enum ulink_delay_type type, int delay, long *f);
+static int ulink_calculate_delay(enum ulink_delay_type type, long f, int *delay);
 
 /* Interface between OpenULINK and OpenOCD */
 static void ulink_set_end_state(tap_state_t endstate);
-int ulink_queue_statemove(struct ulink *device);
+static int ulink_queue_statemove(struct ulink *device);
 
-int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd);
-int ulink_queue_tlr_reset(struct ulink *device, struct jtag_command *cmd);
-int ulink_queue_runtest(struct ulink *device, struct jtag_command *cmd);
-int ulink_queue_reset(struct ulink *device, struct jtag_command *cmd);
-int ulink_queue_pathmove(struct ulink *device, struct jtag_command *cmd);
-int ulink_queue_sleep(struct ulink *device, struct jtag_command *cmd);
-int ulink_queue_stableclocks(struct ulink *device, struct jtag_command *cmd);
+static int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd);
+static int ulink_queue_tlr_reset(struct ulink *device, struct jtag_command *cmd);
+static int ulink_queue_runtest(struct ulink *device, struct jtag_command *cmd);
+static int ulink_queue_reset(struct ulink *device, struct jtag_command *cmd);
+static int ulink_queue_pathmove(struct ulink *device, struct jtag_command *cmd);
+static int ulink_queue_sleep(struct ulink *device, struct jtag_command *cmd);
+static int ulink_queue_stableclocks(struct ulink *device, struct jtag_command *cmd);
 
-int ulink_post_process_scan(struct ulink_cmd *ulink_cmd);
-int ulink_post_process_queue(struct ulink *device);
+static int ulink_post_process_scan(struct ulink_cmd *ulink_cmd);
+static int ulink_post_process_queue(struct ulink *device);
 
-/* JTAG driver functions (registered in struct jtag_interface) */
+/* adapter driver functions */
 static int ulink_execute_queue(void);
 static int ulink_khz(int khz, int *jtag_speed);
 static int ulink_speed(int speed);
@@ -251,37 +236,50 @@ static int ulink_quit(void);
 
 /****************************** Global Variables ******************************/
 
-struct ulink *ulink_handle;
+static struct ulink *ulink_handle;
 
 /**************************** USB helper functions ****************************/
 
 /**
- * Opens the ULINK device and claims its USB interface.
+ * Opens the ULINK device
+ *
+ * Currently, only the original ULINK is supported
  *
  * @param device pointer to struct ulink identifying ULINK driver instance.
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_usb_open(struct ulink **device)
+static int ulink_usb_open(struct ulink **device)
 {
-       int ret;
-       struct usb_dev_handle *usb_handle;
+       ssize_t num_devices, i;
+       bool found;
+       struct libusb_device **usb_devices;
+       struct libusb_device_descriptor usb_desc;
+       struct libusb_device_handle *usb_device_handle;
 
-       /* Currently, only original ULINK is supported */
-       uint16_t vids[] = { ULINK_VID, 0 };
-       uint16_t pids[] = { ULINK_PID, 0 };
+       num_devices = libusb_get_device_list((*device)->libusb_ctx, &usb_devices);
 
-       ret = jtag_usb_open(vids, pids, &usb_handle);
+       if (num_devices <= 0)
+               return ERROR_FAIL;
 
-       if (ret != ERROR_OK)
-               return ret;
+       found = false;
+       for (i = 0; i < num_devices; i++) {
+               if (libusb_get_device_descriptor(usb_devices[i], &usb_desc) != 0)
+                       continue;
+               else if (usb_desc.idVendor == ULINK_VID && usb_desc.idProduct == ULINK_PID) {
+                       found = true;
+                       break;
+               }
+       }
 
-       ret = usb_claim_interface(usb_handle, 0);
+       if (!found)
+               return ERROR_FAIL;
 
-       if (ret != 0)
-               return ret;
+       if (libusb_open(usb_devices[i], &usb_device_handle) != 0)
+               return ERROR_FAIL;
+       libusb_free_device_list(usb_devices, 1);
 
-       (*device)->usb_handle = usb_handle;
+       (*device)->usb_device_handle = usb_device_handle;
        (*device)->type = ULINK_1;
 
        return ERROR_OK;
@@ -294,15 +292,14 @@ int ulink_usb_open(struct ulink **device)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_usb_close(struct ulink **device)
+static int ulink_usb_close(struct ulink **device)
 {
-       if (usb_release_interface((*device)->usb_handle, 0) != 0)
+       if (libusb_release_interface((*device)->usb_device_handle, 0) != 0)
                return ERROR_FAIL;
 
-       if (usb_close((*device)->usb_handle) != 0)
-               return ERROR_FAIL;
+       libusb_close((*device)->usb_device_handle);
 
-       (*device)->usb_handle = NULL;
+       (*device)->usb_device_handle = NULL;
 
        return ERROR_OK;
 }
@@ -318,13 +315,13 @@ int ulink_usb_close(struct ulink **device)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_cpu_reset(struct ulink *device, char reset_bit)
+static int ulink_cpu_reset(struct ulink *device, unsigned char reset_bit)
 {
        int ret;
 
-       ret = usb_control_msg(device->usb_handle,
-                       (USB_ENDPOINT_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE),
-                       REQUEST_FIRMWARE_LOAD, CPUCS_REG, 0, &reset_bit, 1, USB_TIMEOUT);
+       ret = libusb_control_transfer(device->usb_device_handle,
+                       (LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),
+                       REQUEST_FIRMWARE_LOAD, CPUCS_REG, 0, &reset_bit, 1, LIBUSB_TIMEOUT_MS);
 
        /* usb_control_msg() returns the number of bytes transferred during the
         * DATA stage of the control transfer - must be exactly 1 in this case! */
@@ -345,8 +342,8 @@ int ulink_cpu_reset(struct ulink *device, char reset_bit)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_load_firmware_and_renumerate(struct ulink **device,
-       char *filename, uint32_t delay)
+static int ulink_load_firmware_and_renumerate(struct ulink **device,
+       const char *filename, uint32_t delay)
 {
        int ret;
 
@@ -381,10 +378,10 @@ int ulink_load_firmware_and_renumerate(struct ulink **device,
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_load_firmware(struct ulink *device, char *filename)
+static int ulink_load_firmware(struct ulink *device, const char *filename)
 {
        struct image ulink_firmware_image;
-       int ret, i;
+       int ret;
 
        ret = ulink_cpu_reset(device, CPU_RESET);
        if (ret != ERROR_OK) {
@@ -393,7 +390,7 @@ int ulink_load_firmware(struct ulink *device, char *filename)
        }
 
        ulink_firmware_image.base_address = 0;
-       ulink_firmware_image.base_address_set = 0;
+       ulink_firmware_image.base_address_set = false;
 
        ret = image_open(&ulink_firmware_image, filename, "ihex");
        if (ret != ERROR_OK) {
@@ -402,7 +399,7 @@ int ulink_load_firmware(struct ulink *device, char *filename)
        }
 
        /* Download all sections in the image to ULINK */
-       for (i = 0; i < ulink_firmware_image.num_sections; i++) {
+       for (unsigned int i = 0; i < ulink_firmware_image.num_sections; i++) {
                ret = ulink_write_firmware_section(device, &ulink_firmware_image, i);
                if (ret != ERROR_OK)
                        return ret;
@@ -430,7 +427,7 @@ int ulink_load_firmware(struct ulink *device, char *filename)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_write_firmware_section(struct ulink *device,
+static int ulink_write_firmware_section(struct ulink *device,
        struct image *firmware_image, int section_index)
 {
        uint16_t addr, size, bytes_remaining, chunk_size;
@@ -445,9 +442,6 @@ int ulink_write_firmware_section(struct ulink *device,
        LOG_DEBUG("section %02i at addr 0x%04x (size 0x%04x)", section_index, addr,
                size);
 
-       if (data == NULL)
-               return ERROR_FAIL;
-
        /* Copy section contents to local buffer */
        ret = image_read_section(firmware_image, section_index, 0, size, data,
                        &size_read);
@@ -467,10 +461,10 @@ int ulink_write_firmware_section(struct ulink *device,
                else
                        chunk_size = bytes_remaining;
 
-               ret = usb_control_msg(device->usb_handle,
-                               (USB_ENDPOINT_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE),
-                               REQUEST_FIRMWARE_LOAD, addr, FIRMWARE_ADDR, (char *)data_ptr,
-                               chunk_size, USB_TIMEOUT);
+               ret = libusb_control_transfer(device->usb_device_handle,
+                               (LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),
+                               REQUEST_FIRMWARE_LOAD, addr, FIRMWARE_ADDR, (unsigned char *)data_ptr,
+                               chunk_size, LIBUSB_TIMEOUT_MS);
 
                if (ret != (int)chunk_size) {
                        /* Abort if libusb sent less data than requested */
@@ -493,7 +487,7 @@ int ulink_write_firmware_section(struct ulink *device,
  * @param input_signals input signal states as returned by CMD_GET_SIGNALS
  * @param output_signals output signal states as returned by CMD_GET_SIGNALS
  */
-void ulink_print_signal_states(uint8_t input_signals, uint8_t output_signals)
+static void ulink_print_signal_states(uint8_t input_signals, uint8_t output_signals)
 {
        LOG_INFO("ULINK signal states: TDI: %i, TDO: %i, TMS: %i, TCK: %i, TRST: %i,"
                " SRST: %i",
@@ -501,8 +495,8 @@ void ulink_print_signal_states(uint8_t input_signals, uint8_t output_signals)
                (input_signals  & SIGNAL_TDO   ? 1 : 0),
                (output_signals & SIGNAL_TMS   ? 1 : 0),
                (output_signals & SIGNAL_TCK   ? 1 : 0),
-               (output_signals & SIGNAL_TRST  ? 0 : 1),/* TRST and RESET are inverted */
-               (output_signals & SIGNAL_RESET ? 0 : 1));       /* by hardware */
+               (output_signals & SIGNAL_TRST  ? 0 : 1),        /* Inverted by hardware */
+               (output_signals & SIGNAL_RESET ? 0 : 1));       /* Inverted by hardware */
 }
 
 /**************** OpenULINK command generation helper functions ***************/
@@ -516,21 +510,21 @@ void ulink_print_signal_states(uint8_t input_signals, uint8_t output_signals)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_allocate_payload(struct ulink_cmd *ulink_cmd, int size,
+static int ulink_allocate_payload(struct ulink_cmd *ulink_cmd, int size,
        enum ulink_payload_direction direction)
 {
        uint8_t *payload;
 
        payload = calloc(size, sizeof(uint8_t));
 
-       if (payload == NULL) {
+       if (!payload) {
                LOG_ERROR("Could not allocate OpenULINK command payload: out of memory");
                return ERROR_FAIL;
        }
 
        switch (direction) {
            case PAYLOAD_DIRECTION_OUT:
-                   if (ulink_cmd->payload_out != NULL) {
+                   if (ulink_cmd->payload_out) {
                            LOG_ERROR("BUG: Duplicate payload allocation for OpenULINK command");
                            free(payload);
                            return ERROR_FAIL;
@@ -540,7 +534,7 @@ int ulink_allocate_payload(struct ulink_cmd *ulink_cmd, int size,
                    }
                    break;
            case PAYLOAD_DIRECTION_IN:
-                   if (ulink_cmd->payload_in_start != NULL) {
+                   if (ulink_cmd->payload_in_start) {
                            LOG_ERROR("BUG: Duplicate payload allocation for OpenULINK command");
                            free(payload);
                            return ERROR_FAIL;
@@ -570,13 +564,13 @@ int ulink_allocate_payload(struct ulink_cmd *ulink_cmd, int size,
  * @return the number of bytes currently stored in the queue for the specified
  *  direction.
  */
-int ulink_get_queue_size(struct ulink *device,
+static int ulink_get_queue_size(struct ulink *device,
        enum ulink_payload_direction direction)
 {
        struct ulink_cmd *current = device->queue_start;
        int sum = 0;
 
-       while (current != NULL) {
+       while (current) {
                switch (direction) {
                    case PAYLOAD_DIRECTION_OUT:
                            sum += current->payload_out_size + 1;       /* + 1 byte for Command ID */
@@ -596,15 +590,13 @@ int ulink_get_queue_size(struct ulink *device,
  * Clear the OpenULINK command queue.
  *
  * @param device pointer to struct ulink identifying ULINK driver instance.
- * @return on success: ERROR_OK
- * @return on failure: ERROR_FAIL
  */
-void ulink_clear_queue(struct ulink *device)
+static void ulink_clear_queue(struct ulink *device)
 {
        struct ulink_cmd *current = device->queue_start;
        struct ulink_cmd *next = NULL;
 
-       while (current != NULL) {
+       while (current) {
                /* Save pointer to next element */
                next = current->next;
 
@@ -641,10 +633,10 @@ void ulink_clear_queue(struct ulink *device)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_queue(struct ulink *device, struct ulink_cmd *ulink_cmd)
+static int ulink_append_queue(struct ulink *device, struct ulink_cmd *ulink_cmd)
 {
        int newsize_out, newsize_in;
-       int ret;
+       int ret = ERROR_OK;
 
        newsize_out = ulink_get_queue_size(device, PAYLOAD_DIRECTION_OUT) + 1
                + ulink_cmd->payload_out_size;
@@ -656,18 +648,16 @@ int ulink_append_queue(struct ulink *device, struct ulink_cmd *ulink_cmd)
        if ((newsize_out > 64) || (newsize_in > 64)) {
                /* New command does not fit. Execute all commands in queue before starting
                 * new queue with the current command as first entry. */
-               ret = ulink_execute_queued_commands(device, USB_TIMEOUT);
-               if (ret != ERROR_OK)
-                       return ret;
+               ret = ulink_execute_queued_commands(device, LIBUSB_TIMEOUT_MS);
 
-               ret = ulink_post_process_queue(device);
-               if (ret != ERROR_OK)
-                       return ret;
+               if (ret == ERROR_OK)
+                       ret = ulink_post_process_queue(device);
 
-               ulink_clear_queue(device);
+               if (ret == ERROR_OK)
+                       ulink_clear_queue(device);
        }
 
-       if (device->queue_start == NULL) {
+       if (!device->queue_start) {
                /* Queue was empty */
                device->commands_in_queue = 1;
 
@@ -681,25 +671,28 @@ int ulink_append_queue(struct ulink *device, struct ulink_cmd *ulink_cmd)
                device->queue_end = ulink_cmd;
        }
 
-       return ERROR_OK;
+       if (ret != ERROR_OK)
+               ulink_clear_queue(device);
+
+       return ret;
 }
 
 /**
  * Sends all queued OpenULINK commands to the ULINK for execution.
  *
  * @param device pointer to struct ulink identifying ULINK driver instance.
+ * @param timeout
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_execute_queued_commands(struct ulink *device, int timeout)
+static int ulink_execute_queued_commands(struct ulink *device, int timeout)
 {
        struct ulink_cmd *current;
-       int ret, i, index_out, index_in, count_out, count_in;
+       int ret, i, index_out, index_in, count_out, count_in, transferred;
        uint8_t buffer[64];
 
-#ifdef _DEBUG_JTAG_IO_
-       ulink_print_queue(device);
-#endif
+       if (LOG_LEVEL_IS(LOG_LVL_DEBUG_IO))
+               ulink_print_queue(device);
 
        index_out = 0;
        count_out = 0;
@@ -719,20 +712,20 @@ int ulink_execute_queued_commands(struct ulink *device, int timeout)
        }
 
        /* Send packet to ULINK */
-       ret = usb_bulk_write(device->usb_handle, (2 | USB_ENDPOINT_OUT),
-                       (char *)buffer, count_out, timeout);
-       if (ret < 0)
+       ret = libusb_bulk_transfer(device->usb_device_handle, device->ep_out,
+                       (unsigned char *)buffer, count_out, &transferred, timeout);
+       if (ret != 0)
                return ERROR_FAIL;
-       if (ret != count_out)
+       if (transferred != count_out)
                return ERROR_FAIL;
 
        /* Wait for response if commands contain IN payload data */
        if (count_in > 0) {
-               ret = usb_bulk_read(device->usb_handle, (2 | USB_ENDPOINT_IN),
-                               (char *)buffer, 64, timeout);
-               if (ret < 0)
+               ret = libusb_bulk_transfer(device->usb_device_handle, device->ep_in,
+                               (unsigned char *)buffer, 64, &transferred, timeout);
+               if (ret != 0)
                        return ERROR_FAIL;
-               if (ret != count_in)
+               if (transferred != count_in)
                        return ERROR_FAIL;
 
                /* Write back IN payload data */
@@ -748,71 +741,51 @@ int ulink_execute_queued_commands(struct ulink *device, int timeout)
        return ERROR_OK;
 }
 
-#ifdef _DEBUG_JTAG_IO_
-
 /**
  * Convert an OpenULINK command ID (\a id) to a human-readable string.
  *
  * @param id the OpenULINK command ID.
  * @return the corresponding human-readable string.
  */
-const char *ulink_cmd_id_string(uint8_t id)
+static const char *ulink_cmd_id_string(uint8_t id)
 {
        switch (id) {
-           case CMD_SCAN_IN:
-                   return "CMD_SCAN_IN";
-                   break;
-           case CMD_SLOW_SCAN_IN:
-                   return "CMD_SLOW_SCAN_IN";
-                   break;
-           case CMD_SCAN_OUT:
-                   return "CMD_SCAN_OUT";
-                   break;
-           case CMD_SLOW_SCAN_OUT:
-                   return "CMD_SLOW_SCAN_OUT";
-                   break;
-           case CMD_SCAN_IO:
-                   return "CMD_SCAN_IO";
-                   break;
-           case CMD_SLOW_SCAN_IO:
-                   return "CMD_SLOW_SCAN_IO";
-                   break;
-           case CMD_CLOCK_TMS:
-                   return "CMD_CLOCK_TMS";
-                   break;
-           case CMD_SLOW_CLOCK_TMS:
-                   return "CMD_SLOW_CLOCK_TMS";
-                   break;
-           case CMD_CLOCK_TCK:
-                   return "CMD_CLOCK_TCK";
-                   break;
-           case CMD_SLOW_CLOCK_TCK:
-                   return "CMD_SLOW_CLOCK_TCK";
-                   break;
-           case CMD_SLEEP_US:
-                   return "CMD_SLEEP_US";
-                   break;
-           case CMD_SLEEP_MS:
-                   return "CMD_SLEEP_MS";
-                   break;
-           case CMD_GET_SIGNALS:
-                   return "CMD_GET_SIGNALS";
-                   break;
-           case CMD_SET_SIGNALS:
-                   return "CMD_SET_SIGNALS";
-                   break;
-           case CMD_CONFIGURE_TCK_FREQ:
-                   return "CMD_CONFIGURE_TCK_FREQ";
-                   break;
-           case CMD_SET_LEDS:
-                   return "CMD_SET_LEDS";
-                   break;
-           case CMD_TEST:
-                   return "CMD_TEST";
-                   break;
-           default:
-                   return "CMD_UNKNOWN";
-                   break;
+       case CMD_SCAN_IN:
+               return "CMD_SCAN_IN";
+       case CMD_SLOW_SCAN_IN:
+               return "CMD_SLOW_SCAN_IN";
+       case CMD_SCAN_OUT:
+               return "CMD_SCAN_OUT";
+       case CMD_SLOW_SCAN_OUT:
+               return "CMD_SLOW_SCAN_OUT";
+       case CMD_SCAN_IO:
+               return "CMD_SCAN_IO";
+       case CMD_SLOW_SCAN_IO:
+               return "CMD_SLOW_SCAN_IO";
+       case CMD_CLOCK_TMS:
+               return "CMD_CLOCK_TMS";
+       case CMD_SLOW_CLOCK_TMS:
+               return "CMD_SLOW_CLOCK_TMS";
+       case CMD_CLOCK_TCK:
+               return "CMD_CLOCK_TCK";
+       case CMD_SLOW_CLOCK_TCK:
+               return "CMD_SLOW_CLOCK_TCK";
+       case CMD_SLEEP_US:
+               return "CMD_SLEEP_US";
+       case CMD_SLEEP_MS:
+               return "CMD_SLEEP_MS";
+       case CMD_GET_SIGNALS:
+               return "CMD_GET_SIGNALS";
+       case CMD_SET_SIGNALS:
+               return "CMD_SET_SIGNALS";
+       case CMD_CONFIGURE_TCK_FREQ:
+               return "CMD_CONFIGURE_TCK_FREQ";
+       case CMD_SET_LEDS:
+               return "CMD_SET_LEDS";
+       case CMD_TEST:
+               return "CMD_TEST";
+       default:
+               return "CMD_UNKNOWN";
        }
 }
 
@@ -821,7 +794,7 @@ const char *ulink_cmd_id_string(uint8_t id)
  *
  * @param ulink_cmd pointer to OpenULINK command.
  */
-void ulink_print_command(struct ulink_cmd *ulink_cmd)
+static void ulink_print_command(struct ulink_cmd *ulink_cmd)
 {
        int i;
 
@@ -839,7 +812,7 @@ void ulink_print_command(struct ulink_cmd *ulink_cmd)
  *
  * @param device pointer to struct ulink identifying ULINK driver instance.
  */
-void ulink_print_queue(struct ulink *device)
+static void ulink_print_queue(struct ulink *device)
 {
        struct ulink_cmd *current;
 
@@ -849,8 +822,6 @@ void ulink_print_queue(struct ulink *device)
                ulink_print_command(current);
 }
 
-#endif /* _DEBUG_JTAG_IO_ */
-
 /**
  * Perform JTAG scan
  *
@@ -881,7 +852,7 @@ void ulink_print_queue(struct ulink *device)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_scan_cmd(struct ulink *device, enum scan_type scan_type,
+static int ulink_append_scan_cmd(struct ulink *device, enum scan_type scan_type,
        int scan_size_bits, uint8_t *tdi, uint8_t *tdo_start, uint8_t *tdo,
        uint8_t tms_count_start, uint8_t tms_sequence_start, uint8_t tms_count_end,
        uint8_t tms_sequence_end, struct jtag_command *origin, bool postprocess)
@@ -890,7 +861,7 @@ int ulink_append_scan_cmd(struct ulink *device, enum scan_type scan_type,
        int ret, i, scan_size_bytes;
        uint8_t bits_last_byte;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        /* Check size of command. USB buffer can hold 64 bytes, 1 byte is command ID,
@@ -982,13 +953,13 @@ int ulink_append_scan_cmd(struct ulink *device, enum scan_type scan_type,
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_clock_tms_cmd(struct ulink *device, uint8_t count,
+static int ulink_append_clock_tms_cmd(struct ulink *device, uint8_t count,
        uint8_t sequence)
 {
        struct ulink_cmd *cmd = calloc(1, sizeof(struct ulink_cmd));
        int ret;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        if (device->delay_clock_tms < 0)
@@ -1019,12 +990,12 @@ int ulink_append_clock_tms_cmd(struct ulink *device, uint8_t count,
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_clock_tck_cmd(struct ulink *device, uint16_t count)
+static int ulink_append_clock_tck_cmd(struct ulink *device, uint16_t count)
 {
        struct ulink_cmd *cmd = calloc(1, sizeof(struct ulink_cmd));
        int ret;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        if (device->delay_clock_tck < 0)
@@ -1052,12 +1023,12 @@ int ulink_append_clock_tck_cmd(struct ulink *device, uint16_t count)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_get_signals_cmd(struct ulink *device)
+static int ulink_append_get_signals_cmd(struct ulink *device)
 {
        struct ulink_cmd *cmd = calloc(1, sizeof(struct ulink_cmd));
        int ret;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        cmd->id = CMD_GET_SIGNALS;
@@ -1091,13 +1062,13 @@ int ulink_append_get_signals_cmd(struct ulink *device)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_set_signals_cmd(struct ulink *device, uint8_t low,
+static int ulink_append_set_signals_cmd(struct ulink *device, uint8_t low,
        uint8_t high)
 {
        struct ulink_cmd *cmd = calloc(1, sizeof(struct ulink_cmd));
        int ret;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        cmd->id = CMD_SET_SIGNALS;
@@ -1124,12 +1095,12 @@ int ulink_append_set_signals_cmd(struct ulink *device, uint8_t low,
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_sleep_cmd(struct ulink *device, uint32_t us)
+static int ulink_append_sleep_cmd(struct ulink *device, uint32_t us)
 {
        struct ulink_cmd *cmd = calloc(1, sizeof(struct ulink_cmd));
        int ret;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        cmd->id = CMD_SLEEP_US;
@@ -1160,13 +1131,13 @@ int ulink_append_sleep_cmd(struct ulink *device, uint32_t us)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_configure_tck_cmd(struct ulink *device, int delay_scan_in,
+static int ulink_append_configure_tck_cmd(struct ulink *device, int delay_scan_in,
        int delay_scan_out, int delay_scan_io, int delay_tck, int delay_tms)
 {
        struct ulink_cmd *cmd = calloc(1, sizeof(struct ulink_cmd));
        int ret;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        cmd->id = CMD_CONFIGURE_TCK_FREQ;
@@ -1222,12 +1193,12 @@ int ulink_append_configure_tck_cmd(struct ulink *device, int delay_scan_in,
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_led_cmd(struct ulink *device, uint8_t led_state)
+static int ulink_append_led_cmd(struct ulink *device, uint8_t led_state)
 {
        struct ulink_cmd *cmd = calloc(1, sizeof(struct ulink_cmd));
        int ret;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        cmd->id = CMD_SET_LEDS;
@@ -1252,12 +1223,12 @@ int ulink_append_led_cmd(struct ulink *device, uint8_t led_state)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_append_test_cmd(struct ulink *device)
+static int ulink_append_test_cmd(struct ulink *device)
 {
        struct ulink_cmd *cmd = calloc(1, sizeof(struct ulink_cmd));
        int ret;
 
-       if (cmd == NULL)
+       if (!cmd)
                return ERROR_FAIL;
 
        cmd->id = CMD_TEST;
@@ -1287,7 +1258,7 @@ int ulink_append_test_cmd(struct ulink *device)
  *   1. Maximum possible frequency without any artificial delay
  *   2. Variable frequency with artificial linear delay loop
  *
- * To set the ULINK to maximum frequency, it is only neccessary to use the
+ * To set the ULINK to maximum frequency, it is only necessary to use the
  * corresponding command IDs. To set the ULINK to a lower frequency, the
  * delay loop top values have to be calculated first. Then, a
  * CMD_CONFIGURE_TCK_FREQ command needs to be sent to the ULINK device.
@@ -1308,7 +1279,7 @@ int ulink_append_test_cmd(struct ulink *device)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_calculate_delay(enum ulink_delay_type type, long f, int *delay)
+static int ulink_calculate_delay(enum ulink_delay_type type, long f, int *delay)
 {
        float t, x, x_ceil;
 
@@ -1366,16 +1337,14 @@ int ulink_calculate_delay(enum ulink_delay_type type, long f, int *delay)
  *
  * @param type for which command to calculate the delay value.
  * @param delay delay value for which to calculate the resulting TCK frequency.
- * @param f where to store the resulting TCK frequency.
- * @return on success: ERROR_OK
- * @return on failure: ERROR_FAIL
+ * @return the resulting TCK frequency
  */
-int ulink_calculate_frequency(enum ulink_delay_type type, int delay, long *f)
+static long ulink_calculate_frequency(enum ulink_delay_type type, int delay)
 {
-       float t, f_float, f_rounded;
+       float t, f_float;
 
        if (delay > 255)
-               return ERROR_FAIL;
+               return 0;
 
        switch (type) {
            case DELAY_CLOCK_TCK:
@@ -1409,15 +1378,11 @@ int ulink_calculate_frequency(enum ulink_delay_type type, int delay, long *f)
                            t = (float)(4E-6) * (float)(delay) + (float)(1.3132E-5);
                    break;
            default:
-                   return ERROR_FAIL;
-                   break;
+                   return 0;
        }
 
        f_float = 1.0 / t;
-       f_rounded = roundf(f_float);
-       *f = (long)f_rounded;
-
-       return ERROR_OK;
+       return roundf(f_float);
 }
 
 /******************* Interface between OpenULINK and OpenOCD ******************/
@@ -1445,7 +1410,7 @@ static void ulink_set_end_state(tap_state_t endstate)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_queue_statemove(struct ulink *device)
+static int ulink_queue_statemove(struct ulink *device)
 {
        uint8_t tms_sequence, tms_count;
        int ret;
@@ -1474,7 +1439,7 @@ int ulink_queue_statemove(struct ulink *device)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd)
+static int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd)
 {
        uint32_t scan_size_bits, scan_size_bytes, bits_last_scan;
        uint32_t scans_max_payload, bytecount;
@@ -1510,7 +1475,7 @@ int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd)
        if ((type == SCAN_IN) || (type == SCAN_IO)) {
                tdo_buffer_start = calloc(sizeof(uint8_t), scan_size_bytes);
 
-               if (tdo_buffer_start == NULL)
+               if (!tdo_buffer_start)
                        return ERROR_FAIL;
 
                tdo_buffer = tdo_buffer_start;
@@ -1588,9 +1553,9 @@ int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd)
                        bytecount -= 58;
 
                        /* Update TDI and TDO buffer pointers */
-                       if (tdi_buffer_start != NULL)
+                       if (tdi_buffer_start)
                                tdi_buffer += 58;
-                       if (tdo_buffer_start != NULL)
+                       if (tdo_buffer_start)
                                tdo_buffer += 58;
                } else if (bytecount == 58) {   /* Full scan, no further scans */
                        tms_count_end = last_tms_count;
@@ -1632,6 +1597,7 @@ int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd)
 
                if (ret != ERROR_OK) {
                        free(tdi_buffer_start);
+                       free(tdo_buffer_start);
                        return ret;
                }
        }
@@ -1652,7 +1618,7 @@ int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_queue_tlr_reset(struct ulink *device, struct jtag_command *cmd)
+static int ulink_queue_tlr_reset(struct ulink *device, struct jtag_command *cmd)
 {
        int ret;
 
@@ -1675,7 +1641,7 @@ int ulink_queue_tlr_reset(struct ulink *device, struct jtag_command *cmd)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_queue_runtest(struct ulink *device, struct jtag_command *cmd)
+static int ulink_queue_runtest(struct ulink *device, struct jtag_command *cmd)
 {
        int ret;
 
@@ -1702,11 +1668,12 @@ int ulink_queue_runtest(struct ulink *device, struct jtag_command *cmd)
 /**
  * Execute a JTAG_RESET command
  *
+ * @param device
  * @param cmd pointer to the command that shall be executed.
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_queue_reset(struct ulink *device, struct jtag_command *cmd)
+static int ulink_queue_reset(struct ulink *device, struct jtag_command *cmd)
 {
        uint8_t low = 0, high = 0;
 
@@ -1732,7 +1699,7 @@ int ulink_queue_reset(struct ulink *device, struct jtag_command *cmd)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_queue_pathmove(struct ulink *device, struct jtag_command *cmd)
+static int ulink_queue_pathmove(struct ulink *device, struct jtag_command *cmd)
 {
        int ret, i, num_states, batch_size, state_count;
        tap_state_t *path;
@@ -1791,7 +1758,7 @@ int ulink_queue_pathmove(struct ulink *device, struct jtag_command *cmd)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_queue_sleep(struct ulink *device, struct jtag_command *cmd)
+static int ulink_queue_sleep(struct ulink *device, struct jtag_command *cmd)
 {
        /* IMPORTANT! Due to the time offset in command execution introduced by
         * command queueing, this needs to be implemented in the ULINK device */
@@ -1804,7 +1771,7 @@ int ulink_queue_sleep(struct ulink *device, struct jtag_command *cmd)
  * @param device pointer to struct ulink identifying ULINK driver instance.
  * @param cmd pointer to the command that shall be executed.
  */
-int ulink_queue_stableclocks(struct ulink *device, struct jtag_command *cmd)
+static int ulink_queue_stableclocks(struct ulink *device, struct jtag_command *cmd)
 {
        int ret;
        unsigned num_cycles;
@@ -1849,7 +1816,7 @@ int ulink_queue_stableclocks(struct ulink *device, struct jtag_command *cmd)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_post_process_scan(struct ulink_cmd *ulink_cmd)
+static int ulink_post_process_scan(struct ulink_cmd *ulink_cmd)
 {
        struct jtag_command *cmd = ulink_cmd->cmd_origin;
        int ret;
@@ -1880,7 +1847,7 @@ int ulink_post_process_scan(struct ulink_cmd *ulink_cmd)
  * @return on success: ERROR_OK
  * @return on failure: ERROR_FAIL
  */
-int ulink_post_process_queue(struct ulink *device)
+static int ulink_post_process_queue(struct ulink *device)
 {
        struct ulink_cmd *current;
        struct jtag_command *openocd_cmd;
@@ -1888,12 +1855,12 @@ int ulink_post_process_queue(struct ulink *device)
 
        current = device->queue_start;
 
-       while (current != NULL) {
+       while (current) {
                openocd_cmd = current->cmd_origin;
 
                /* Check if a corresponding OpenOCD command is stored for this
                 * OpenULINK command */
-               if ((current->needs_postprocessing == true) && (openocd_cmd != NULL)) {
+               if ((current->needs_postprocessing == true) && (openocd_cmd)) {
                        switch (openocd_cmd->type) {
                            case JTAG_SCAN:
                                    ret = ulink_post_process_scan(current);
@@ -1979,7 +1946,7 @@ static int ulink_execute_queue(void)
        }
 
        if (ulink_handle->commands_in_queue > 0) {
-               ret = ulink_execute_queued_commands(ulink_handle, USB_TIMEOUT);
+               ret = ulink_execute_queued_commands(ulink_handle, LIBUSB_TIMEOUT_MS);
                if (ret != ERROR_OK)
                        return ret;
 
@@ -2052,31 +2019,21 @@ static int ulink_khz(int khz, int *jtag_speed)
                        return ret;
        }
 
-#ifdef _DEBUG_JTAG_IO_
-       long f_tck, f_tms, f_scan_in, f_scan_out, f_scan_io;
-
-       ulink_calculate_frequency(DELAY_CLOCK_TCK, ulink_handle->delay_clock_tck,
-               &f_tck);
-       ulink_calculate_frequency(DELAY_CLOCK_TMS, ulink_handle->delay_clock_tms,
-               &f_tms);
-       ulink_calculate_frequency(DELAY_SCAN_IN, ulink_handle->delay_scan_in,
-               &f_scan_in);
-       ulink_calculate_frequency(DELAY_SCAN_OUT, ulink_handle->delay_scan_out,
-               &f_scan_out);
-       ulink_calculate_frequency(DELAY_SCAN_IO, ulink_handle->delay_scan_io,
-               &f_scan_io);
-
-       DEBUG_JTAG_IO("ULINK TCK setup: delay_tck      = %i (%li Hz),",
-               ulink_handle->delay_clock_tck, f_tck);
-       DEBUG_JTAG_IO("                 delay_tms      = %i (%li Hz),",
-               ulink_handle->delay_clock_tms, f_tms);
-       DEBUG_JTAG_IO("                 delay_scan_in  = %i (%li Hz),",
-               ulink_handle->delay_scan_in, f_scan_in);
-       DEBUG_JTAG_IO("                 delay_scan_out = %i (%li Hz),",
-               ulink_handle->delay_scan_out, f_scan_out);
-       DEBUG_JTAG_IO("                 delay_scan_io  = %i (%li Hz),",
-               ulink_handle->delay_scan_io, f_scan_io);
-#endif
+       LOG_DEBUG_IO("ULINK TCK setup: delay_tck      = %i (%li Hz),",
+               ulink_handle->delay_clock_tck,
+               ulink_calculate_frequency(DELAY_CLOCK_TCK, ulink_handle->delay_clock_tck));
+       LOG_DEBUG_IO("                 delay_tms      = %i (%li Hz),",
+               ulink_handle->delay_clock_tms,
+               ulink_calculate_frequency(DELAY_CLOCK_TMS, ulink_handle->delay_clock_tms));
+       LOG_DEBUG_IO("                 delay_scan_in  = %i (%li Hz),",
+               ulink_handle->delay_scan_in,
+               ulink_calculate_frequency(DELAY_SCAN_IN, ulink_handle->delay_scan_in));
+       LOG_DEBUG_IO("                 delay_scan_out = %i (%li Hz),",
+               ulink_handle->delay_scan_out,
+               ulink_calculate_frequency(DELAY_SCAN_OUT, ulink_handle->delay_scan_out));
+       LOG_DEBUG_IO("                 delay_scan_io  = %i (%li Hz),",
+               ulink_handle->delay_scan_io,
+               ulink_calculate_frequency(DELAY_SCAN_IO, ulink_handle->delay_scan_io));
 
        /* Configure the ULINK device with the new delay values */
        ret = ulink_append_configure_tck_cmd(ulink_handle,
@@ -2142,17 +2099,17 @@ static int ulink_speed_div(int speed, int *khz)
  */
 static int ulink_init(void)
 {
-       int ret;
+       int ret, transferred;
        char str_manufacturer[20];
        bool download_firmware = false;
-       uint8_t *dummy;
+       unsigned char *dummy;
        uint8_t input_signals, output_signals;
 
        ulink_handle = calloc(1, sizeof(struct ulink));
-       if (ulink_handle == NULL)
+       if (!ulink_handle)
                return ERROR_FAIL;
 
-       usb_init();
+       libusb_init(&ulink_handle->libusb_ctx);
 
        ret = ulink_usb_open(&ulink_handle);
        if (ret != ERROR_OK) {
@@ -2163,7 +2120,7 @@ static int ulink_init(void)
        }
 
        /* Get String Descriptor to determine if firmware needs to be loaded */
-       ret = usb_get_string_simple(ulink_handle->usb_handle, 1, str_manufacturer, 20);
+       ret = libusb_get_string_descriptor_ascii(ulink_handle->usb_device_handle, 1, (unsigned char *)str_manufacturer, 20);
        if (ret < 0) {
                /* Could not get descriptor -> Unconfigured or original Keil firmware */
                download_firmware = true;
@@ -2187,6 +2144,12 @@ static int ulink_init(void)
        } else
                LOG_INFO("ULINK device is already running OpenULINK firmware");
 
+       /* Get OpenULINK USB IN/OUT endpoints and claim the interface */
+       ret = jtag_libusb_choose_interface(ulink_handle->usb_device_handle,
+               &ulink_handle->ep_in, &ulink_handle->ep_out, -1, -1, -1, -1);
+       if (ret != ERROR_OK)
+               return ret;
+
        /* Initialize OpenULINK command queue */
        ulink_clear_queue(ulink_handle);
 
@@ -2202,12 +2165,12 @@ static int ulink_init(void)
                 * shut down by the user via Ctrl-C. Try to retrieve this Bulk IN packet. */
                dummy = calloc(64, sizeof(uint8_t));
 
-               ret = usb_bulk_read(ulink_handle->usb_handle, (2 | USB_ENDPOINT_IN),
-                               (char *)dummy, 64, 200);
+               ret = libusb_bulk_transfer(ulink_handle->usb_device_handle, ulink_handle->ep_in,
+                               dummy, 64, &transferred, 200);
 
                free(dummy);
 
-               if (ret < 0) {
+               if (ret != 0 || transferred == 0) {
                        /* Bulk IN transfer failed -> unrecoverable error condition */
                        LOG_ERROR("Cannot communicate with ULINK device. Disconnect ULINK from "
                                "the USB port and re-connect, then re-run OpenOCD");
@@ -2224,14 +2187,17 @@ static int ulink_init(void)
        }
        ulink_clear_queue(ulink_handle);
 
-       ulink_append_get_signals_cmd(ulink_handle);
-       ulink_execute_queued_commands(ulink_handle, 200);
+       ret = ulink_append_get_signals_cmd(ulink_handle);
+       if (ret == ERROR_OK)
+               ret = ulink_execute_queued_commands(ulink_handle, 200);
 
-       /* Post-process the single CMD_GET_SIGNALS command */
-       input_signals = ulink_handle->queue_start->payload_in[0];
-       output_signals = ulink_handle->queue_start->payload_in[1];
+       if (ret == ERROR_OK) {
+               /* Post-process the single CMD_GET_SIGNALS command */
+               input_signals = ulink_handle->queue_start->payload_in[0];
+               output_signals = ulink_handle->queue_start->payload_in[1];
 
-       ulink_print_signal_states(input_signals, output_signals);
+               ulink_print_signal_states(input_signals, output_signals);
+       }
 
        ulink_clear_queue(ulink_handle);
 
@@ -2268,7 +2234,7 @@ COMMAND_HANDLER(ulink_download_firmware_handler)
        LOG_INFO("Downloading ULINK firmware image %s", CMD_ARGV[0]);
 
        /* Download firmware image in CMD_ARGV[0] */
-       ret = ulink_load_firmware_and_renumerate(&ulink_handle, (char *)CMD_ARGV[0],
+       ret = ulink_load_firmware_and_renumerate(&ulink_handle, CMD_ARGV[0],
                        ULINK_RENUMERATION_DELAY);
 
        return ret;
@@ -2276,9 +2242,9 @@ COMMAND_HANDLER(ulink_download_firmware_handler)
 
 /*************************** Command Registration **************************/
 
-static const struct command_registration ulink_command_handlers[] = {
+static const struct command_registration ulink_subcommand_handlers[] = {
        {
-               .name = "ulink_download_firmware",
+               .name = "download_firmware",
                .handler = &ulink_download_firmware_handler,
                .mode = COMMAND_EXEC,
                .help = "download firmware image to ULINK device",
@@ -2287,17 +2253,31 @@ static const struct command_registration ulink_command_handlers[] = {
        COMMAND_REGISTRATION_DONE,
 };
 
-struct jtag_interface ulink_interface = {
-       .name = "ulink",
+static const struct command_registration ulink_command_handlers[] = {
+       {
+               .name = "ulink",
+               .mode = COMMAND_ANY,
+               .help = "perform ulink management",
+               .chain = ulink_subcommand_handlers,
+               .usage = "",
+       },
+       COMMAND_REGISTRATION_DONE
+};
 
-       .commands = ulink_command_handlers,
+static struct jtag_interface ulink_interface = {
+       .execute_queue = ulink_execute_queue,
+};
+
+struct adapter_driver ulink_adapter_driver = {
+       .name = "ulink",
        .transports = jtag_only,
+       .commands = ulink_command_handlers,
 
-       .execute_queue = ulink_execute_queue,
-       .khz = ulink_khz,
+       .init = ulink_init,
+       .quit = ulink_quit,
        .speed = ulink_speed,
+       .khz = ulink_khz,
        .speed_div = ulink_speed_div,
 
-       .init = ulink_init,
-       .quit = ulink_quit
+       .jtag_ops = &ulink_interface,
 };