Fix: Error while reading from USB endpoint
[fw/openocd] / src / jtag / commands.c
index b7b411b1017c48f83dc307c2f5807198f3af8f84..546b12f8bfef0d935018b806895f3c0e9c34c8bc 100644 (file)
  *   Free Software Foundation, Inc.,                                       *
  *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
  ***************************************************************************/
+
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 
+#include <jtag/jtag.h>
 #include "commands.h"
 
-typedef struct cmd_queue_page_s
-{
+struct cmd_queue_page {
        void *address;
        size_t used;
-       struct cmd_queue_page_s *next;
-} cmd_queue_page_t;
+       struct cmd_queue_page *next;
+};
 
 #define CMD_QUEUE_PAGE_SIZE (1024 * 1024)
-static cmd_queue_page_t *cmd_queue_pages = NULL;
+static struct cmd_queue_page *cmd_queue_pages;
 
-jtag_command_t *jtag_command_queue = NULL;
-static jtag_command_t **next_command_pointer = &jtag_command_queue;
+struct jtag_command *jtag_command_queue;
+static struct jtag_command **next_command_pointer = &jtag_command_queue;
 
-void jtag_queue_command(jtag_command_t * cmd)
+void jtag_queue_command(struct jtag_command *cmd)
 {
-       // this command goes on the end, so ensure the queue terminates
+       /* this command goes on the end, so ensure the queue terminates */
        cmd->next = NULL;
 
-       jtag_command_t **last_cmd = next_command_pointer;
+       struct jtag_command **last_cmd = next_command_pointer;
        assert(NULL != last_cmd);
        assert(NULL == *last_cmd);
        *last_cmd = cmd;
 
-       // store location where the next command pointer will be stored
+       /* store location where the next command pointer will be stored */
        next_command_pointer = &cmd->next;
 }
 
-voidcmd_queue_alloc(size_t size)
+void *cmd_queue_alloc(size_t size)
 {
-       cmd_queue_page_t **p_page = &cmd_queue_pages;
+       struct cmd_queue_page **p_page = &cmd_queue_pages;
        int offset;
        uint8_t *t;
 
@@ -95,20 +96,18 @@ void* cmd_queue_alloc(size_t size)
 #define ALIGN_SIZE  (sizeof(union worse_case_align))
 
        /* The alignment process. */
-       size = (size + ALIGN_SIZE -1) & (~(ALIGN_SIZE-1));
+       size = (size + ALIGN_SIZE - 1) & (~(ALIGN_SIZE - 1));
        /* Done... */
 
-       if (*p_page)
-       {
+       if (*p_page) {
                while ((*p_page)->next)
                        p_page = &((*p_page)->next);
                if (CMD_QUEUE_PAGE_SIZE - (*p_page)->used < size)
                        p_page = &((*p_page)->next);
        }
 
-       if (!*p_page)
-       {
-               *p_page = malloc(sizeof(cmd_queue_page_t));
+       if (!*p_page) {
+               *p_page = malloc(sizeof(struct cmd_queue_page));
                (*p_page)->used = 0;
                (*p_page)->address = malloc(CMD_QUEUE_PAGE_SIZE);
                (*p_page)->next = NULL;
@@ -117,17 +116,16 @@ void* cmd_queue_alloc(size_t size)
        offset = (*p_page)->used;
        (*p_page)->used += size;
 
-       t=(uint8_t *)((*p_page)->address);
+       t = (uint8_t *)((*p_page)->address);
        return t + offset;
 }
 
-void cmd_queue_free(void)
+static void cmd_queue_free(void)
 {
-       cmd_queue_page_t *page = cmd_queue_pages;
+       struct cmd_queue_page *page = cmd_queue_pages;
 
-       while (page)
-       {
-               cmd_queue_page_t *last = page;
+       while (page) {
+               struct cmd_queue_page *last = page;
                free(page->address);
                page = page->next;
                free(last);
@@ -144,13 +142,12 @@ void jtag_command_queue_reset(void)
        next_command_pointer = &jtag_command_queue;
 }
 
-enum scan_type jtag_scan_type(const scan_command_t *cmd)
+enum scan_type jtag_scan_type(const struct scan_command *cmd)
 {
        int i;
        int type = 0;
 
-       for (i = 0; i < cmd->num_fields; i++)
-       {
+       for (i = 0; i < cmd->num_fields; i++) {
                if (cmd->fields[i].in_value)
                        type |= SCAN_IN;
                if (cmd->fields[i].out_value)
@@ -160,65 +157,60 @@ enum scan_type jtag_scan_type(const scan_command_t *cmd)
        return type;
 }
 
-int jtag_scan_size(const scan_command_t *cmd)
+int jtag_scan_size(const struct scan_command *cmd)
 {
        int bit_count = 0;
        int i;
 
        /* count bits in scan command */
        for (i = 0; i < cmd->num_fields; i++)
-       {
                bit_count += cmd->fields[i].num_bits;
-       }
 
        return bit_count;
 }
 
-int jtag_build_buffer(const scan_command_t *cmd, uint8_t **buffer)
+int jtag_build_buffer(const struct scan_command *cmd, uint8_t **buffer)
 {
        int bit_count = 0;
        int i;
 
        bit_count = jtag_scan_size(cmd);
-       *buffer = calloc(1,CEIL(bit_count, 8));
+       *buffer = calloc(1, DIV_ROUND_UP(bit_count, 8));
 
        bit_count = 0;
 
-#ifdef _DEBUG_JTAG_IO_
-       LOG_DEBUG("%s num_fields: %i", cmd->ir_scan ? "IRSCAN" : "DRSCAN", cmd->num_fields);
-#endif
+       DEBUG_JTAG_IO("%s num_fields: %i",
+                       cmd->ir_scan ? "IRSCAN" : "DRSCAN",
+                       cmd->num_fields);
 
-       for (i = 0; i < cmd->num_fields; i++)
-       {
-               if (cmd->fields[i].out_value)
-               {
+       for (i = 0; i < cmd->num_fields; i++) {
+               if (cmd->fields[i].out_value) {
 #ifdef _DEBUG_JTAG_IO_
-                       char* char_buf = buf_to_str(cmd->fields[i].out_value, (cmd->fields[i].num_bits > DEBUG_JTAG_IOZ) ? DEBUG_JTAG_IOZ : cmd->fields[i].num_bits, 16);
-#endif
-                       buf_set_buf(cmd->fields[i].out_value, 0, *buffer, bit_count, cmd->fields[i].num_bits);
-#ifdef _DEBUG_JTAG_IO_
-                       LOG_DEBUG("fields[%i].out_value[%i]: 0x%s", i, cmd->fields[i].num_bits, char_buf);
+                       char *char_buf = buf_to_str(cmd->fields[i].out_value,
+                               (cmd->fields[i].num_bits > DEBUG_JTAG_IOZ)
+                                       ? DEBUG_JTAG_IOZ
+                                       : cmd->fields[i].num_bits, 16);
+
+                       LOG_DEBUG("fields[%i].out_value[%i]: 0x%s", i,
+                                       cmd->fields[i].num_bits, char_buf);
                        free(char_buf);
 #endif
-               }
-               else
-               {
-#ifdef _DEBUG_JTAG_IO_
-                       LOG_DEBUG("fields[%i].out_value[%i]: NULL", i, cmd->fields[i].num_bits);
-#endif
+                       buf_set_buf(cmd->fields[i].out_value, 0, *buffer,
+                                       bit_count, cmd->fields[i].num_bits);
+               } else {
+                       DEBUG_JTAG_IO("fields[%i].out_value[%i]: NULL",
+                                       i, cmd->fields[i].num_bits);
                }
 
                bit_count += cmd->fields[i].num_bits;
        }
 
-#ifdef _DEBUG_JTAG_IO_
-       //LOG_DEBUG("bit_count totalling: %i",  bit_count );
-#endif
+       /*DEBUG_JTAG_IO("bit_count totalling: %i",  bit_count); */
 
        return bit_count;
 }
 
-int jtag_read_buffer(uint8_t *buffer, const scan_command_t *cmd)
+int jtag_read_buffer(uint8_t *buffer, const struct scan_command *cmd)
 {
        int i;
        int bit_count = 0;
@@ -227,26 +219,28 @@ int jtag_read_buffer(uint8_t *buffer, const scan_command_t *cmd)
        /* we return ERROR_OK, unless a check fails, or a handler reports a problem */
        retval = ERROR_OK;
 
-       for (i = 0; i < cmd->num_fields; i++)
-       {
+       for (i = 0; i < cmd->num_fields; i++) {
                /* if neither in_value nor in_handler
                 * are specified we don't have to examine this field
                 */
-               if (cmd->fields[i].in_value)
-               {
+               if (cmd->fields[i].in_value) {
                        int num_bits = cmd->fields[i].num_bits;
-                       uint8_t *captured = buf_set_buf(buffer, bit_count, malloc(CEIL(num_bits, 8)), 0, num_bits);
+                       uint8_t *captured = buf_set_buf(buffer, bit_count,
+                                       malloc(DIV_ROUND_UP(num_bits, 8)), 0, num_bits);
 
 #ifdef _DEBUG_JTAG_IO_
-                       char *char_buf = buf_to_str(captured, (num_bits > DEBUG_JTAG_IOZ) ? DEBUG_JTAG_IOZ : num_bits, 16);
-                       LOG_DEBUG("fields[%i].in_value[%i]: 0x%s", i, num_bits, char_buf);
+                       char *char_buf = buf_to_str(captured,
+                                       (num_bits > DEBUG_JTAG_IOZ)
+                                               ? DEBUG_JTAG_IOZ
+                                               : num_bits, 16);
+
+                       LOG_DEBUG("fields[%i].in_value[%i]: 0x%s",
+                                       i, num_bits, char_buf);
                        free(char_buf);
 #endif
 
                        if (cmd->fields[i].in_value)
-                       {
                                buf_cpy(captured, cmd->fields[i].in_value, num_bits);
-                       }
 
                        free(captured);
                }
@@ -255,5 +249,3 @@ int jtag_read_buffer(uint8_t *buffer, const scan_command_t *cmd)
 
        return retval;
 }
-
-