binarybuffer: Remove unnecessary cast and fix hidden "bug"

[fw/openocd] / src / helper / binarybuffer.h

diff --git a/src/helper/binarybuffer.h b/src/helper/binarybuffer.h
index 5b86c5f4d38a077240c17d33be64982bb12dd2b0..9c20bcd59c8802a6599ebb52f11a7f6857c071a7 100644 (file)
--- a/src/helper/binarybuffer.h
+++ b/src/helper/binarybuffer.h
@@ -42,7 +42,7 @@
 static inline void buf_set_u32(void *_buffer,
        unsigned first, unsigned num, uint32_t value)
 {
-       uint8_t *buffer = (uint8_t *)_buffer;
+       uint8_t *buffer = _buffer;
 
        if ((num == 32) && (first == 0)) {
                buffer[3] = (value >> 24) & 0xff;
@@ -71,7 +71,7 @@ static inline void buf_set_u32(void *_buffer,
 static inline void buf_set_u64(void *_buffer,
        unsigned first, unsigned num, uint64_t value)
 {
-       uint8_t *buffer = (uint8_t *)_buffer;
+       uint8_t *buffer = _buffer;
 
        if ((num == 32) && (first == 0)) {
                buffer[3] = (value >> 24) & 0xff;
@@ -109,7 +109,7 @@ static inline void buf_set_u64(void *_buffer,
 static inline uint32_t buf_get_u32(const void *_buffer,
        unsigned first, unsigned num)
 {
-       uint8_t *buffer = (uint8_t *)_buffer;
+       const uint8_t *buffer = _buffer;
 
        if ((num == 32) && (first == 0)) {
                return (((uint32_t)buffer[3]) << 24) |
@@ -138,7 +138,7 @@ static inline uint32_t buf_get_u32(const void *_buffer,
 static inline uint64_t buf_get_u64(const void *_buffer,
        unsigned first, unsigned num)
 {
-       uint8_t *buffer = (uint8_t *)_buffer;
+       const uint8_t *buffer = _buffer;
 
        if ((num == 32) && (first == 0)) {
                return 0 + ((((uint32_t)buffer[3]) << 24) |   /* Note - zero plus is to avoid a checkpatch bug */