target/xtensa: fix clang analyzer warning

[fw/openocd] / src / hello.c

diff --git a/src/hello.c b/src/hello.c
index 25938bcf88d75e5a45c2f07e5237a32823519e78..db6774eaa350f74a14331194a1e5f54e9ed68ff9 100644 (file)
--- a/src/hello.c
+++ b/src/hello.c
@@ -1,18 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
 /***************************************************************************
  *   Copyright (C) 2009 Zachary T Welch <zw@superlucidity.net>             *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -88,8 +77,8 @@ COMMAND_HANDLER(handle_hello_command)
 {
        const char *sep, *name;
        int retval = CALL_COMMAND_HANDLER(handle_hello_args, &sep, &name);
-       if (ERROR_OK == retval)
-               command_print(CMD_CTX, "Greetings%s%s!", sep, name);
+       if (retval == ERROR_OK)
+               command_print(CMD, "Greetings%s%s!", sep, name);
        return retval;
 }
 
@@ -105,8 +94,8 @@ const struct command_registration hello_command_handlers[] = {
                .name = "foo",
                .mode = COMMAND_ANY,
                .help = "example command handler skeleton",
-
                .chain = foo_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };