flash/nor: Use proper data types in driver API

[fw/openocd] / src / flash / nor / renesas_rpchf.c

diff --git a/src/flash/nor/renesas_rpchf.c b/src/flash/nor/renesas_rpchf.c
index 3f03f927557bfde52b920b076232f01fabc3f913..933b6e5205d13c3fe915a0d76292e26ce8689647 100644 (file)
--- a/src/flash/nor/renesas_rpchf.c
+++ b/src/flash/nor/renesas_rpchf.c
@@ -497,7 +497,6 @@ static int rpchf_write(struct flash_bank *bank, const uint8_t *buffer, uint32_t
        int align;      /* number of unaligned bytes */
        uint8_t current_word[CFI_MAX_BUS_WIDTH * 4];    /* word (bus_width size) currently being
                                                         *programmed */
-       int i;
        int retval;
 
        if (bank->target->state != TARGET_HALTED) {
@@ -523,14 +522,13 @@ static int rpchf_write(struct flash_bank *bank, const uint8_t *buffer, uint32_t
                        return retval;
 
                /* replace only bytes that must be written */
-               for (i = align;
-                    (i < bank->bus_width) && (count > 0);
-                    i++, count--)
+               for (unsigned int i = align; (i < bank->bus_width) && (count > 0); i++, count--) {
                        if (cfi_info->data_swap)
                                /* data bytes are swapped (reverse endianness) */
                                current_word[bank->bus_width - i] = *buffer++;
                        else
                                current_word[i] = *buffer++;
+               }
 
                retval = cfi_write_word(bank, current_word, write_p);
                if (retval != ERROR_OK)
@@ -547,12 +545,12 @@ static int rpchf_write(struct flash_bank *bank, const uint8_t *buffer, uint32_t
 
        /* fall back to memory writes */
        while (count >= (uint32_t)bank->bus_width) {
-               int fallback;
+               bool fallback;
                if ((write_p & 0xff) == 0) {
                        LOG_INFO("Programming at 0x%08" PRIx32 ", count 0x%08"
                                PRIx32 " bytes remaining", write_p, count);
                }
-               fallback = 1;
+               fallback = true;
                if ((bufferwsize > 0) && (count >= buffersize) &&
                                !(write_p & buffermask)) {
                        retval = rpchf_write_words(bank, buffer, bufferwsize, write_p);
@@ -560,13 +558,13 @@ static int rpchf_write(struct flash_bank *bank, const uint8_t *buffer, uint32_t
                                buffer += buffersize;
                                write_p += buffersize;
                                count -= buffersize;
-                               fallback = 0;
+                               fallback = false;
                        } else if (retval != ERROR_FLASH_OPER_UNSUPPORTED)
                                return retval;
                }
                /* try the slow way? */
                if (fallback) {
-                       for (i = 0; i < bank->bus_width; i++)
+                       for (unsigned int i = 0; i < bank->bus_width; i++)
                                current_word[i] = *buffer++;
 
                        retval = cfi_write_word(bank, current_word, write_p);
@@ -593,7 +591,7 @@ static int rpchf_write(struct flash_bank *bank, const uint8_t *buffer, uint32_t
                        return retval;
 
                /* replace only bytes that must be written */
-               for (i = 0; (i < bank->bus_width) && (count > 0); i++, count--)
+               for (unsigned int i = 0; (i < bank->bus_width) && (count > 0); i++, count--)
                        if (cfi_info->data_swap)
                                /* data bytes are swapped (reverse endianness) */
                                current_word[bank->bus_width - i] = *buffer++;