flash/stmqspi: minor fixes on coding style

[fw/openocd] / src / flash / nor / fm3.c

diff --git a/src/flash/nor/fm3.c b/src/flash/nor/fm3.c
index f2da2af8ae4481e4f5cd6476032bce93f65ac7f7..fef1797069365e05baa658ae8fdf0c4c66ac4ff9 100644 (file)
--- a/src/flash/nor/fm3.c
+++ b/src/flash/nor/fm3.c
@@ -61,7 +61,7 @@ enum fm3_flash_type {
 struct fm3_flash_bank {
        enum fm3_variant variant;
        enum fm3_flash_type flashtype;
-       int probed;
+       bool probed;
 };
 
 FLASH_BANK_COMMAND_HANDLER(fm3_flash_bank_command)
@@ -132,7 +132,7 @@ FLASH_BANK_COMMAND_HANDLER(fm3_flash_bank_command)
                return ERROR_FLASH_BANK_INVALID;
        }
 
-       fm3_info->probed = 0;
+       fm3_info->probed = false;
 
        return ERROR_OK;
 }
@@ -201,13 +201,14 @@ static int fm3_busy_wait(struct target *target, uint32_t offset, int timeout_ms)
        return retval;
 }
 
-static int fm3_erase(struct flash_bank *bank, int first, int last)
+static int fm3_erase(struct flash_bank *bank, unsigned int first,
+               unsigned int last)
 {
        struct fm3_flash_bank *fm3_info = bank->driver_priv;
        struct target *target = bank->target;
        int retval = ERROR_OK;
        uint32_t u32DummyRead;
-       int sector, odd;
+       int odd;
        uint32_t u32FlashType;
        uint32_t u32FlashSeqAddress1;
        uint32_t u32FlashSeqAddress2;
@@ -260,7 +261,7 @@ static int fm3_erase(struct flash_bank *bank, int first, int last)
                0x00, 0xBE,             /*        BKPT  #0                     */
        };
 
-       LOG_INFO("Fujitsu MB9[A/B]FXXX: Sector Erase ... (%d to %d)", first, last);
+       LOG_INFO("Fujitsu MB9[A/B]FXXX: Sector Erase ... (%u to %u)", first, last);
 
        /* disable HW watchdog */
        retval = target_write_u32(target, 0x40011C00, 0x1ACCE551);
@@ -275,7 +276,7 @@ static int fm3_erase(struct flash_bank *bank, int first, int last)
        if (retval != ERROR_OK)
                return retval;
 
-       /* FASZR = 0x01, Enables CPU Programming Mode (16-bit Flash acccess) */
+       /* FASZR = 0x01, Enables CPU Programming Mode (16-bit Flash access) */
        retval = target_write_u32(target, 0x40000000, 0x0001);
        if (retval != ERROR_OK)
                return retval;
@@ -304,7 +305,7 @@ static int fm3_erase(struct flash_bank *bank, int first, int last)
        init_reg_param(&reg_params[2], "r2", 32, PARAM_OUT); /* offset                          */
 
        /* write code buffer and use Flash sector erase code within fm3                         */
-       for (sector = first ; sector <= last ; sector++) {
+       for (unsigned int sector = first ; sector <= last ; sector++) {
                uint32_t offset = bank->sectors[sector].offset;
 
                for (odd = 0; odd < 2 ; odd++) {
@@ -335,7 +336,7 @@ static int fm3_erase(struct flash_bank *bank, int first, int last)
        destroy_reg_param(&reg_params[1]);
        destroy_reg_param(&reg_params[2]);
 
-       /* FASZR = 0x02, Enables CPU Run Mode (32-bit Flash acccess) */
+       /* FASZR = 0x02, Enables CPU Run Mode (32-bit Flash access) */
        retval = target_write_u32(target, 0x40000000, 0x0002);
        if (retval != ERROR_OK)
                return retval;
@@ -656,7 +657,7 @@ static int fm3_probe(struct flash_bank *bank)
  */
 
        num_pages = 10;                         /* max number of Flash pages for malloc */
-       fm3_info->probed = 0;
+       fm3_info->probed = false;
 
        bank->sectors = malloc(sizeof(struct flash_sector) * num_pages);
        bank->base = 0x00000000;
@@ -796,7 +797,7 @@ static int fm3_probe(struct flash_bank *bank)
                bank->sectors[9].is_protected = -1;
        }
 
-       fm3_info->probed = 1;
+       fm3_info->probed = true;
 
        return ERROR_OK;
 }
@@ -943,8 +944,6 @@ static int fm3_chip_erase(struct flash_bank *bank)
 
 COMMAND_HANDLER(fm3_handle_chip_erase_command)
 {
-       int i;
-
        if (CMD_ARGC < 1)
                return ERROR_COMMAND_SYNTAX_ERROR;
 
@@ -955,12 +954,12 @@ COMMAND_HANDLER(fm3_handle_chip_erase_command)
 
        if (fm3_chip_erase(bank) == ERROR_OK) {
                /* set all sectors as erased */
-               for (i = 0; i < bank->num_sectors; i++)
+               for (unsigned int i = 0; i < bank->num_sectors; i++)
                        bank->sectors[i].is_erased = 1;
 
-               command_print(CMD_CTX, "fm3 chip erase complete");
+               command_print(CMD, "fm3 chip erase complete");
        } else {
-               command_print(CMD_CTX, "fm3 chip erase failed");
+               command_print(CMD, "fm3 chip erase failed");
        }
 
        return ERROR_OK;