Change return value on error.

[fw/openocd] / src / flash / nor / fm3.c

diff --git a/src/flash/nor/fm3.c b/src/flash/nor/fm3.c
index 1e2adf55f27a2631dcf16dbb5c2520ef87283798..78e71d2902cbbf82bade405c871dde9992289711 100644 (file)
--- a/src/flash/nor/fm3.c
+++ b/src/flash/nor/fm3.c
@@ -69,8 +69,7 @@ FLASH_BANK_COMMAND_HANDLER(fm3_flash_bank_command)
 
        if (CMD_ARGC < 6)
        {
-               LOG_WARNING("incomplete flash_bank fm3 configuration");
-               return ERROR_FLASH_BANK_INVALID;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        fm3_info = malloc(sizeof(struct fm3_flash_bank));
@@ -643,7 +642,6 @@ static int fm3_probe(struct flash_bank *bank)
 
        bank->sectors = malloc(sizeof(struct flash_sector) * num_pages);
        bank->base = 0x00000000;
-       num_pages = 2;                          /* start with smallest Flash pages number */
        bank->size = 32 * 1024;         /* bytes */
 
        bank->sectors[0].offset = 0;
@@ -848,8 +846,7 @@ COMMAND_HANDLER(fm3_handle_chip_erase_command)
 
        if (CMD_ARGC < 1)
        {
-               command_print(CMD_CTX, "fm3 chip_erase <bank>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
@@ -876,9 +873,9 @@ COMMAND_HANDLER(fm3_handle_chip_erase_command)
 static const struct command_registration fm3_exec_command_handlers[] = {
        {
                .name = "chip_erase",
+               .usage = "<bank>",
                .handler = fm3_handle_chip_erase_command,
                .mode = COMMAND_EXEC,
-               .usage = "bank_id",
                .help = "Erase entire Flash device.",
        },
        COMMAND_REGISTRATION_DONE