cmd: add missing usage var

[fw/openocd] / src / flash / nor / em357.c

diff --git a/src/flash/nor/em357.c b/src/flash/nor/em357.c
index 8a3cf4c2bbfb309c9028fcf18d06367c32e62d97..2e40601f8aa9b18d2bccdc4676a81ff919a046a6 100644 (file)
--- a/src/flash/nor/em357.c
+++ b/src/flash/nor/em357.c
@@ -104,8 +104,7 @@ FLASH_BANK_COMMAND_HANDLER(em357_flash_bank_command)
 
        if (CMD_ARGC < 6)
        {
-               LOG_WARNING("incomplete flash_bank em357 configuration");
-               return ERROR_FLASH_BANK_INVALID;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        em357_info = malloc(sizeof(struct em357_flash_bank));
@@ -757,10 +756,7 @@ static int em357_auto_probe(struct flash_bank *bank)
 
 static int get_em357_info(struct flash_bank *bank, char *buf, int buf_size)
 {
-       int printed;
-       printed = snprintf(buf, buf_size, "em357\n");
-       buf += printed;
-       buf_size -= printed;
+       snprintf(buf, buf_size, "em357\n");
        return ERROR_OK;
 }
 
@@ -771,8 +767,7 @@ COMMAND_HANDLER(em357_handle_lock_command)
 
        if (CMD_ARGC < 1)
        {
-               command_print(CMD_CTX, "em357 lock <bank>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
@@ -813,12 +808,10 @@ COMMAND_HANDLER(em357_handle_lock_command)
 COMMAND_HANDLER(em357_handle_unlock_command)
 {
        struct target *target = NULL;
-       struct em357_flash_bank *em357_info = NULL;
 
        if (CMD_ARGC < 1)
        {
-               command_print(CMD_CTX, "em357 unlock <bank>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
@@ -826,8 +819,6 @@ COMMAND_HANDLER(em357_handle_unlock_command)
        if (ERROR_OK != retval)
                return retval;
 
-       em357_info = bank->driver_priv;
-
        target = bank->target;
 
        if (target->state != TARGET_HALTED)
@@ -898,8 +889,7 @@ COMMAND_HANDLER(em357_handle_mass_erase_command)
 
        if (CMD_ARGC < 1)
        {
-               command_print(CMD_CTX, "em357 mass_erase <bank>");
-               return ERROR_OK;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        struct flash_bank *bank;
@@ -929,23 +919,23 @@ COMMAND_HANDLER(em357_handle_mass_erase_command)
 static const struct command_registration em357_exec_command_handlers[] = {
        {
                .name = "lock",
+               .usage = "<bank>",
                .handler = em357_handle_lock_command,
                .mode = COMMAND_EXEC,
-               .usage = "bank_id",
                .help = "Lock entire flash device.",
        },
        {
                .name = "unlock",
+               .usage = "<bank>",
                .handler = em357_handle_unlock_command,
                .mode = COMMAND_EXEC,
-               .usage = "bank_id",
                .help = "Unlock entire protected flash device.",
        },
        {
                .name = "mass_erase",
+               .usage = "<bank>",
                .handler = em357_handle_mass_erase_command,
                .mode = COMMAND_EXEC,
-               .usage = "bank_id",
                .help = "Erase entire flash device.",
        },
        COMMAND_REGISTRATION_DONE
@@ -956,6 +946,7 @@ static const struct command_registration em357_command_handlers[] = {
                .name = "em357",
                .mode = COMMAND_ANY,
                .help = "em357 flash command group",
+               .usage = "",
                .chain = em357_exec_command_handlers,
        },
        COMMAND_REGISTRATION_DONE