icode comments need space

[fw/sdcc] / src / SDCCglue.c

diff --git a/src/SDCCglue.c b/src/SDCCglue.c
index 59f82998c0ae74494db1f6ab87f58f442fff2a36..c4ef6f2f5e4ef2f02c53992e1dcbb2b561904220 100644 (file)
--- a/src/SDCCglue.c
+++ b/src/SDCCglue.c
@@ -107,7 +107,6 @@ copyFile (FILE * dest, FILE * src)
 char *
 aopLiteralLong (value * val, int offset, int size)
 {
-       char *rs;
        union {
                float f;
                unsigned char c[4];
@@ -127,17 +126,18 @@ aopLiteralLong (value * val, int offset, int size)
                v >>= (offset * 8);
                switch (size) {
                case 1:
-                       tsprintf (buffer, "!immedbyte", (unsigned int) v & 0xff);
+                       tsprintf (buffer, sizeof(buffer), 
+                                 "!immedbyte", (unsigned int) v & 0xff);
                        break;
                case 2:
-                       tsprintf (buffer, "!immedword", (unsigned int) v & 0xffff);
+                       tsprintf (buffer, sizeof(buffer), 
+                                 "!immedword", (unsigned int) v & 0xffff);
                        break;
                default:
                        /* Hmm.  Too big for now. */
                        assert (0);
                }
-               rs = Safe_calloc (1, strlen (buffer) + 1);
-               return strcpy (rs, buffer);
+               return Safe_strdup (buffer);
        }
 
        /* PENDING: For now size must be 1 */
@@ -146,12 +146,13 @@ aopLiteralLong (value * val, int offset, int size)
        /* it is type float */
        fl.f = (float) floatFromVal (val);
 #ifdef _BIG_ENDIAN
-       tsprintf (buffer, "!immedbyte", fl.c[3 - offset]);
+       tsprintf (buffer, sizeof(buffer), 
+                 "!immedbyte", fl.c[3 - offset]);
 #else
-       tsprintf (buffer, "!immedbyte", fl.c[offset]);
+       tsprintf (buffer, sizeof(buffer), 
+                 "!immedbyte", fl.c[offset]);
 #endif
-       rs = Safe_calloc (1, strlen (buffer) + 1);
-       return strcpy (rs, buffer);
+       return Safe_strdup (buffer);
 }
 
 /*-----------------------------------------------------------------*/
@@ -252,8 +253,8 @@ emitRegularMap (memmap * map, bool addPublics, bool arFlag)
          // create a new "XINIT (CODE)" symbol, that will be emitted later
          newSym=copySymbol (sym);
          SPEC_OCLS(newSym->etype)=xinit;
-         sprintf (newSym->name, "__xinit_%s", sym->name);
-         sprintf (newSym->rname,"__xinit_%s", sym->rname);
+         SNPRINTF (newSym->name, sizeof(newSym->name), "__xinit_%s", sym->name);
+         SNPRINTF (newSym->rname, sizeof(newSym->rname), "__xinit_%s", sym->rname);
          SPEC_CONST(newSym->etype)=1;
          SPEC_STAT(newSym->etype)=1;
          resolveIvalSym(newSym->ival);
@@ -1154,6 +1155,11 @@ emitStaticSeg (memmap * map, FILE * out)
              resolveIvalSym (sym->ival);
              printIval (sym, sym->type, sym->ival, out);
              noAlloc--;
+             // if sym->ival is a string, WE don't need it anymore
+             if (IS_AST_SYM_VALUE(list2expr(sym->ival)) &&
+                 list2val(sym->ival)->sym->isstrlit) {
+               freeStringSymbol(list2val(sym->ival)->sym);
+             }
            }
          else {
              /* allocate space */
@@ -1461,12 +1467,12 @@ glue (void)
   /* -o option overrides default name? */
   if ((noAssemble || options.c1mode) && fullDstFileName)
     {
-      strcpy (scratchFileName, fullDstFileName);
+      strncpyz (scratchFileName, fullDstFileName, PATH_MAX);
     }
   else
     {
-      strcpy (scratchFileName, dstFileName);
-      strcat (scratchFileName, port->assembler.file_ext);
+      strncpyz (scratchFileName, dstFileName, PATH_MAX);
+      strncatz (scratchFileName, port->assembler.file_ext, PATH_MAX);
     }
 
   if (!(asmFile = fopen (scratchFileName, "w")))