Fixing up filters a bit to pass QA tests for all versions.

[debian/gnuradio] / gnuradio-core / src / lib / filter / gri_fir_filter_with_buffer_ccf.cc

diff --git a/gnuradio-core/src/lib/filter/gri_fir_filter_with_buffer_ccf.cc b/gnuradio-core/src/lib/filter/gri_fir_filter_with_buffer_ccf.cc
index e9545549f9dcaee8e0a63dcfc0320f2d65a74090..b2db8ce0a73bd071820a882cdf8ee1942ab2db25 100644 (file)
--- a/gnuradio-core/src/lib/filter/gri_fir_filter_with_buffer_ccf.cc
+++ b/gnuradio-core/src/lib/filter/gri_fir_filter_with_buffer_ccf.cc
@@ -23,8 +23,8 @@
 #ifdef HAVE_CONFIG_H
 #include <config.h>
 #endif
+
 #include <gri_fir_filter_with_buffer_ccf.h>
-#include <cstdio>
 
 gri_fir_filter_with_buffer_ccf::gri_fir_filter_with_buffer_ccf(const std::vector<float> &taps)
 {
@@ -34,48 +34,55 @@ gri_fir_filter_with_buffer_ccf::gri_fir_filter_with_buffer_ccf(const std::vector
 
 gri_fir_filter_with_buffer_ccf::~gri_fir_filter_with_buffer_ccf()
 {
-  free(d_buffer);
+  if(d_buffer != NULL)
+    free(d_buffer);
 }
 
-gr_complex 
-gri_fir_filter_with_buffer_ccf::filter (gr_complex input)
+void
+gri_fir_filter_with_buffer_ccf::set_taps (const std::vector<float> &taps)
 {
-#if 0
-  unsigned int i;
+  d_taps = gr_reverse(taps);
   
-  for(i = ntaps()-1; i > 0; i--) {
-    d_buffer[i] = d_buffer[i-1];
+  if(d_buffer != NULL) {
+    free(d_buffer);
+    d_buffer = NULL;
   }
-  d_buffer[0] = input;
-
-  gr_complex out = d_buffer[0]*d_taps[0];
-  for(i = 1; i < ntaps(); i++) {
-    out += d_buffer[i]*d_taps[i];
-  }
-  return out;
+  
+  // FIXME: memalign this to 16-byte boundaries for SIMD later
+  size_t t = sizeof(gr_complex) * 2 * d_taps.size();
+  d_buffer = (gr_complex*)malloc(t);
+  memset(d_buffer, 0x00, t);
+  d_idx = 0;
+}
 
-#else
+gr_complex
+gri_fir_filter_with_buffer_ccf::filter (gr_complex input)
+{
   unsigned int i;
 
   d_buffer[d_idx] = input;
   d_buffer[d_idx+ntaps()] = input;
+
+  // using the later for the case when ntaps=0;
+  // profiling shows this doesn't make a difference
   //d_idx = (d_idx + 1) % ntaps();
   d_idx++;
-  if(d_idx == ntaps())
+  if(d_idx >= ntaps())
     d_idx = 0;
 
-  gr_complex out = d_buffer[d_idx]*d_taps[0];
-  for(i = 1; i < ntaps(); i++) {
-    out += d_buffer[d_idx + i]*d_taps[i];
+  gr_complex out = 0;
+  for(i = 0; i < ntaps(); i++) {
+    out +=  d_buffer[d_idx + i] * d_taps[i];
   }
-  return out;
-#endif
+  return (gr_complex)out;
 }
 
 void
 gri_fir_filter_with_buffer_ccf::filterN (gr_complex output[],
-                                        const gr_complex input[],
-                                        unsigned long n)
+                const gr_complex input[],
+                unsigned long n)
 {
-
+  for(unsigned long i = 0; i < n; i++) {
+    output[i] = filter(input[i]);
+  }
 }