/*
* Amanda, The Advanced Maryland Automatic Network Disk Archiver
- * Copyright (c) 1991-1998 University of Maryland at College Park
+ * Copyright (c) 1991-1999 University of Maryland at College Park
* All Rights Reserved.
*
* Permission to use, copy, modify, distribute, and sell this software and its
* file named AUTHORS, in the root directory of this distribution.
*/
/*
- * $Id: alloc.c,v 1.17.2.1.4.3.2.3 2002/10/27 14:31:18 martinea Exp $
+ * $Id: alloc.c,v 1.37 2006/07/05 10:41:32 martinea Exp $
*
* Memory allocators with error handling. If the allocation fails,
* errordump() is called, relieving the caller from checking the return
*/
#include "amanda.h"
#include "arglist.h"
+#include "queue.h"
+
+static char *internal_vstralloc(const char *, va_list);
/*
*=====================================================================
* debug_caller_loc -- keep track of all allocation callers
*
- * char *debug_caller_loc(char *file, int line)
+ * const char *debug_caller_loc(const char *file, int line)
*
* entry: file = source file
* line = source line
*=====================================================================
*/
-char *
-debug_caller_loc(file, line)
- char *file;
- int line;
+const char *
+debug_caller_loc(
+ const char *file,
+ int line)
{
+ /*@keep@*/
struct loc_str {
char *str;
- struct loc_str *next;
- };
- static struct loc_str *root = NULL;
- struct loc_str *ls, *ls_last;
- int len;
- int size;
- char *p;
- static char *loc = NULL;
- static int loc_size = 0;
-
- if ((p = strrchr(file, '/')) == NULL) {
- p = file; /* keep the whole name */
- } else {
- p++; /* just the last path element */
- }
-
- len = strlen (p);
- size = len + 1 + NUM_STR_SIZE + 1;
- if (size > loc_size) {
- size = ((size + 64 - 1) / 64) * 64; /* might as well get a bunch */
- /*
- * We should free the previous loc area, but we have marked it
- * as a non-leak and the library considers it an error to free
- * such an area, so we just ignore it. We probably grabbed
- * enough the first time that this will not even happen.
- */
- loc = malloc (size);
- if (loc == NULL) {
- return "??"; /* not much better than abort */
- }
- malloc_mark (loc);
- loc_size = size;
- }
-
- strcpy (loc, p);
- ap_snprintf(loc + len, 1 + NUM_STR_SIZE, "@%d", line);
-
- for (ls_last = NULL, ls = root; ls != NULL; ls_last = ls, ls = ls->next) {
- if (strcmp (loc, ls->str) == 0) {
- break;
+ LIST_ENTRY(loc_str) le;
+ } *ls;
+ static LIST_HEAD(, loc_str) root = LIST_HEAD_INITIALIZER(root);
+ static char loc[256]; /* big enough for filename@lineno */
+ const char *p;
+
+ if ((p = strrchr(file, '/')) != NULL)
+ file = p + 1; /* just the last path element */
+
+ snprintf(loc, SIZEOF(loc), "%s@%d", file, line);
+
+ for (ls = LIST_FIRST(&root); ls != NULL; ls = LIST_NEXT(ls, le)) {
+ if (strcmp(loc, ls->str) == 0) {
+ if (ls != LIST_FIRST(&root)) {
+ /*
+ * This is a repeat and was not at the head of the list.
+ * Unlink it and move it to the front.
+ */
+ LIST_REMOVE(ls, le);
+ LIST_INSERT_HEAD(&root, ls, le);
+ }
+ return (ls->str);
}
}
- if (ls == NULL) {
- /*
- * This is a new entry. Put it at the head of the list.
- */
- ls = malloc (sizeof (*ls));
- if (ls == NULL) {
- return "??"; /* not much better than abort */
- }
- malloc_mark (ls);
- size = strlen (loc) + 1;
- ls->str = malloc (size);
- if (ls->str == NULL) {
- free (ls);
- return "??"; /* not much better than abort */
- }
- malloc_mark (ls->str);
- strcpy (ls->str, loc);
- ls->next = root;
- root = ls;
- } else if (ls_last != NULL) {
- /*
- * This is a repeat and was not at the head of the list.
- * Unlink it and move it to the front.
- */
- ls_last->next = ls->next;
- ls->next = root;
- root = ls;
- } else {
- /*
- * This is a repeat but was already at the head of the list,
- * so nothing else needs to be done.
- */
+ /*
+ * This is a new entry. Put it at the head of the list.
+ */
+ ls = malloc(SIZEOF(*ls));
+ if (ls == NULL)
+ return ("??"); /* not much better than abort */
+ ls->str = malloc(strlen(loc) + 1);
+ if (ls->str == NULL) {
+ free(ls);
+ return ("??"); /* not much better than abort */
}
- return ls->str;
+ strcpy(ls->str, loc);
+ malloc_mark(ls);
+ malloc_mark(ls->str);
+ LIST_INSERT_HEAD(&root, ls, le);
+ return (ls->str);
}
/*
static int saved_line;
int
-debug_alloc_push (s, l)
- char *s;
- int l;
+debug_alloc_push(
+ char *s,
+ int l)
{
debug_alloc_loc_info[debug_alloc_ptr].file = s;
debug_alloc_loc_info[debug_alloc_ptr].line = l;
*/
void
-debug_alloc_pop ()
+debug_alloc_pop(void)
{
debug_alloc_ptr =
(debug_alloc_ptr + DEBUG_ALLOC_SAVE_MAX - 1) % DEBUG_ALLOC_SAVE_MAX;
* alloc - a wrapper for malloc.
*/
void *
-debug_alloc(s, l, size)
- char *s;
- int l;
- size_t size;
+debug_alloc(
+ const char *s,
+ int l,
+ size_t size)
{
void *addr;
malloc_enter(debug_caller_loc(s, l));
addr = (void *)malloc(max(size, 1));
- if(addr == NULL) {
- errordump("%s@%d: memory allocation failed (%u bytes requested)",
+ if (addr == NULL) {
+ errordump("%s@%d: memory allocation failed (" SIZE_T_FMT " bytes requested)",
s ? s : "(unknown)",
s ? l : -1,
- size);
+ (SIZE_T_FMT_TYPE)size);
+ /*NOTREACHED*/
}
malloc_leave(debug_caller_loc(s, l));
return addr;
* newalloc - free existing buffer and then alloc a new one.
*/
void *
-debug_newalloc(s, l, old, size)
- char *s;
- int l;
- void *old;
- size_t size;
+debug_newalloc(
+ const char *s,
+ int l,
+ void *old,
+ size_t size)
{
char *addr;
* Just like strdup()!
*/
char *
-debug_stralloc(s, l, str)
- char *s;
- int l;
- const char *str;
+debug_stralloc(
+ const char *s,
+ int l,
+ const char *str)
{
char *addr;
addr = debug_alloc(s, l, strlen(str) + 1);
strcpy(addr, str);
malloc_leave(debug_caller_loc(s, l));
- return addr;
+ return (addr);
}
+/* vstrextend -- Extends the existing string by appending the other
+ * arguments. */
+/*@ignore@*/
+arglist_function(
+ char *vstrextend,
+ char **, oldstr)
+{
+ char *keep = *oldstr;
+ va_list ap;
+
+ arglist_start(ap, oldstr);
+
+ if (*oldstr == NULL)
+ *oldstr = "";
+ *oldstr = internal_vstralloc(*oldstr, ap);
+ amfree(keep);
+
+ arglist_end(ap);
+ return *oldstr;
+}
+/*@end@*/
/*
* internal_vstralloc - copies up to MAX_STR_ARGS strings into newly
#define MAX_VSTRALLOC_ARGS 32
static char *
-internal_vstralloc(str, argp)
- const char *str;
- va_list argp;
+internal_vstralloc(
+ const char *str,
+ va_list argp)
{
char *next;
char *result;
- int a;
+ int a, b;
size_t total_len;
const char *arg[MAX_VSTRALLOC_ARGS+1];
size_t len[MAX_VSTRALLOC_ARGS+1];
size_t l;
- const char *s;
if (str == NULL) {
- return NULL; /* probably will not happen */
+ errordump("internal_vstralloc: str is NULL");
+ /*NOTREACHED*/
}
a = 0;
continue; /* minor optimisation */
}
if (a >= MAX_VSTRALLOC_ARGS) {
- errordump("%s@%d: more than %d arg%s to vstralloc",
+ errordump("%s@%d: more than %d args to vstralloc",
saved_file ? saved_file : "(unknown)",
saved_file ? saved_line : -1,
- MAX_VSTRALLOC_ARGS,
- (MAX_VSTRALLOC_ARGS == 1) ? "" : "s");
+ MAX_VSTRALLOC_ARGS);
+ /*NOTREACHED*/
}
arg[a] = next;
len[a] = l;
total_len += l;
a++;
}
- arg[a] = NULL;
- len[a] = 0;
- next = result = debug_alloc(saved_file, saved_line, total_len+1);
- for (a = 0; (s = arg[a]) != NULL; a++) {
- memcpy(next, s, len[a]);
- next += len[a];
+ result = debug_alloc(saved_file, saved_line, total_len+1);
+
+ next = result;
+ for (b = 0; b < a; b++) {
+ memcpy(next, arg[b], len[b]);
+ next += len[b];
}
*next = '\0';
/*
* vstralloc - copies multiple strings into newly allocated memory.
*/
-arglist_function(char *debug_vstralloc, const char *, str)
+arglist_function(
+ char *debug_vstralloc,
+ const char *, str)
{
va_list argp;
char *result;
* newstralloc - free existing string and then stralloc a new one.
*/
char *
-debug_newstralloc(s, l, oldstr, newstr)
- char *s;
- int l;
- char *oldstr;
- const char *newstr;
+debug_newstralloc(
+ const char *s,
+ int l,
+ char *oldstr,
+ const char *newstr)
{
char *addr;
addr = debug_stralloc(s, l, newstr);
amfree(oldstr);
malloc_leave(debug_caller_loc(s, l));
- return addr;
+ return (addr);
}
/*
* newvstralloc - free existing string and then vstralloc a new one.
*/
-arglist_function1(char *debug_newvstralloc,
- char *,
- oldstr,
- const char *,
- newstr)
+arglist_function1(
+ char *debug_newvstralloc,
+ char *, oldstr,
+ const char *, newstr)
{
va_list argp;
char *result;
}
-/*
- * sbuf_man - static buffer manager.
- *
- * Manage a bunch of static buffer pointers.
- */
-void *sbuf_man(e_bufs, ptr)
- void *e_bufs; /* XXX - I dont think this is right */
- void *ptr;
-{
- SBUF2_DEF(1) *bufs;
- int slot;
-
- bufs = e_bufs;
-
- /* try and trap bugs */
- assert(bufs->magic == SBUF_MAGIC);
- assert(bufs->max > 0);
-
- /* initialise first time through */
- if(bufs->cur == -1)
- for(slot=0; slot < bufs->max; slot++) {
- bufs->bufp[slot] = (void *)0;
- }
-
- /* calculate the next slot */
- slot = bufs->cur + 1;
- if (slot >= bufs->max) slot = 0;
-
- /* free the previous inhabitant */
- if(bufs->bufp[slot] != (void *)0) free(bufs->bufp[slot]);
-
- /* store the new one */
- bufs->bufp[slot] = ptr;
- bufs->cur = slot;
-
- return ptr;
-}
-
-
/*
* safe_env - build a "safe" environment list.
*/
char **
-safe_env()
+safe_env(void)
{
static char *safe_env_list[] = {
"TZ",
+#ifdef __CYGWIN__
+ "SYSTEMROOT",
+#endif
#ifdef NEED_PATH_ENV
"PATH",
#endif
+ "DISPLAY",
NULL
};
* safe_env_list so our result is always a valid, although possibly
* empty, environment list.
*/
-#define SAFE_ENV_CNT (sizeof(safe_env_list) / sizeof(*safe_env_list))
+#define SAFE_ENV_CNT (size_t)(sizeof(safe_env_list) / sizeof(*safe_env_list))
char **envp = safe_env_list + SAFE_ENV_CNT - 1;
char **p;
char *v;
size_t l1, l2;
- if ((q = (char **)malloc(sizeof(safe_env_list))) != NULL) {
+ if ((q = (char **)malloc(SIZEOF(safe_env_list))) != NULL) {
envp = q;
for (p = safe_env_list; *p != NULL; p++) {
if ((v = getenv(*p)) == NULL) {
*/
int
-debug_amtable_alloc(s, l, table, current, elsize, count, bump, init_func)
- char *s;
- int l;
- void **table;
- int *current;
- size_t elsize;
- int count;
- int bump;
- void (*init_func)(void *);
+debug_amtable_alloc(
+ const char *s,
+ int l,
+ void **table,
+ size_t *current,
+ size_t elsize,
+ size_t count,
+ int bump,
+ void (*init_func)(void *))
{
void *table_new;
- int table_count_new;
- int i;
+ size_t table_count_new;
+ size_t i;
if (count >= *current) {
table_count_new = ((count + bump) / bump) * bump;
*/
void
-amtable_free(table, current)
- void **table;
- int *current;
+amtable_free(
+ void **table,
+ size_t *current)
{
amfree(*table);
*current = 0;