Merge commit '42b2e5ca519766e37ce6941ba4faecc9691cc403' into upstream

[debian/openrocket] / android / src / net / sf / openrocket / android / filebrowser / SimpleFileBrowser.java

diff --git a/android/src/net/sf/openrocket/android/filebrowser/SimpleFileBrowser.java b/android/src/net/sf/openrocket/android/filebrowser/SimpleFileBrowser.java
index 1ebebfc4c23113615c125d31d72b9e72ff220979..1ca68f65c3a21a0c34aad10fe045906ef158ca57 100644 (file)
--- a/android/src/net/sf/openrocket/android/filebrowser/SimpleFileBrowser.java
+++ b/android/src/net/sf/openrocket/android/filebrowser/SimpleFileBrowser.java
@@ -161,7 +161,7 @@ public class SimpleFileBrowser extends SherlockListActivity {
                final File file = path.get(position);\r
                if (file.isDirectory()) {\r
                        if (file.canRead())\r
-                               getDir(path.get(position));\r
+                               getDir(file);\r
                        else {\r
                                new AlertDialog.Builder(this).setIcon(R.drawable.or_launcher)\r
                                .setTitle("[" + file.getName() + "] folder can't be read!")\r
@@ -244,13 +244,10 @@ public class SimpleFileBrowser extends SherlockListActivity {
                                }\r
                        }\r
 \r
-                       // Set the "base directory" thing.\r
+                       // Set the "favorite directory" thing.\r
                        {\r
                                ImageView v = (ImageView) (convertView.findViewById(R.id.filebrowser_list_item_homeicon));\r
-                               if ( !file.isDirectory() ) {\r
-                                       v.setVisibility(View.INVISIBLE);\r
-                                       v.setClickable(false);\r
-                               } else {\r
+                               if ( file.isDirectory() && hasUp && position > 1 ) {\r
                                        v.setVisibility(View.VISIBLE);\r
                                        if ( baseDirName.equals( file.getAbsolutePath() ) )  {\r
                                                v.setSelected(true);\r
@@ -259,6 +256,9 @@ public class SimpleFileBrowser extends SherlockListActivity {
                                                v.setClickable(true);\r
                                                v.setOnClickListener( new ChangeBaseDirectory(file.getAbsolutePath()));\r
                                        }\r
+                               } else {\r
+                                       v.setVisibility(View.INVISIBLE);\r
+                                       v.setClickable(false);\r
                                }\r
                        }\r
                        return convertView;\r
@@ -278,8 +278,8 @@ public class SimpleFileBrowser extends SherlockListActivity {
                        if ( v.isSelected() == false ) {\r
                                SharedPreferences pref = PreferenceManager.getDefaultSharedPreferences(SimpleFileBrowser.this);\r
                                baseDirName = dirname;\r
-                               pref.edit().putString(baseDirPrefKey, dirname).apply();\r
-                               SimpleFileBrowser.this.getDir(new File(dirname));\r
+                               pref.edit().putString(baseDirPrefKey, dirname).commit();\r
+                               ((BaseAdapter)SimpleFileBrowser.this.getListAdapter()).notifyDataSetChanged();\r
                        }\r
                }\r
                \r