altosdroid: Update tab contents before switching
authorKeith Packard <keithp@keithp.com>
Sat, 6 Sep 2014 06:10:07 +0000 (23:10 -0700)
committerKeith Packard <keithp@keithp.com>
Sat, 6 Sep 2014 06:10:07 +0000 (23:10 -0700)
Make sure the new tab contents are updated before switching tabs so
that the user doesn't see old stuff.

Signed-off-by: Keith Packard <keithp@keithp.com>
altosdroid/src/org/altusmetrum/AltosDroid/AltosDroidTab.java

index b960eb1a2a7d5c5e81f93e75d3640e049bace381..7b5b01b3ba332510a2976953c9bf0e8eab3c7edc 100644 (file)
@@ -39,37 +39,32 @@ public abstract class AltosDroidTab extends Fragment {
 
        public void set_visible(boolean visible) {
                FragmentTransaction     ft = AltosDroid.fm.beginTransaction();
-               if (visible)
+               if (visible) {
+                       AltosState              state = last_state;
+                       AltosGreatCircle        from_receiver = last_from_receiver;
+                       Location                receiver = last_receiver;
+
+                       last_state = null;
+                       last_from_receiver = null;
+                       last_receiver = null;
+                       show(state, from_receiver, receiver);
                        ft.show(this);
-               else
+               else
                        ft.hide(this);
                ft.commit();
        }
 
        public void update_ui(AltosState state, AltosGreatCircle from_receiver, Location receiver, boolean is_current) {
                if (is_current) {
-                       Log.d(AltosDroid.TAG, String.format("%s: visible, performing update", tab_name()));
+                       if (AltosDroid.D) Log.d(AltosDroid.TAG, String.format("%s: visible, performing update", tab_name()));
 
                        show(state, from_receiver, receiver);
                } else {
-                       Log.d(AltosDroid.TAG, String.format("%s: not visible, skipping update", tab_name()));
+                       if (AltosDroid.D) Log.d(AltosDroid.TAG, String.format("%s: not visible, skipping update", tab_name()));
                        last_state = state;
                        last_from_receiver = from_receiver;
                        last_receiver = receiver;
                        return;
                }
        }
-
-       public void onHiddenChanged(boolean hidden) {
-               if (last_state != null && isVisible()) {
-                       AltosState              state = last_state;
-                       AltosGreatCircle        from_receiver = last_from_receiver;
-                       Location                receiver = last_receiver;
-
-                       last_state = null;
-                       last_from_receiver = null;
-                       last_receiver = null;
-                       show(state, from_receiver, receiver);
-               }
-       }
 }