altos/arm: Align data so that gcc 5.4 doesn't do byte-accesses. Add -Wcast-align
authorKeith Packard <keithp@keithp.com>
Sun, 18 Dec 2016 04:58:36 +0000 (20:58 -0800)
committerKeith Packard <keithp@keithp.com>
Sun, 18 Dec 2016 05:04:33 +0000 (21:04 -0800)
commit89ecc32b90565ace078c4a84d4406a4d1f86821a
tree3b32f1d922380b3dfd25db75552a30dc84c24d41
parentf650211f9e99e1d3d0ae13ae559dd1c082f71545
altos/arm: Align data so that gcc 5.4 doesn't do byte-accesses. Add -Wcast-align

Gcc 5.4.1 tracks alignment of data through assignments, so that a
uint32_t pointer which comes from byte-aligned uint8_t data:

extern uint8_t foo[];

uint32_t *q = (void *) foo;

Fetches and stores through this pointer are done bytewise. This is
slow (meh), but if q references a device register, things to bad very
quickly.

This patch works around this bug in the compiler by adding
__attribute__((aligned(4))) tags to some variables, or changing them
from uint8_t to uint32_t. Places doing this will now be caught as I've
added -Wcast-align to the compiler flags. That required adding (void
*) casts, after the relevant code was checked to make sure the
compiler could tell that the addresses were aligned.

Signed-off-by: Keith Packard <keithp@keithp.com>
16 files changed:
src/aes/ao_aes.c
src/drivers/ao_gps_ublox.c
src/drivers/ao_trng_send.c
src/kernel/ao_list.h
src/kernel/ao_pyro.c
src/kernel/ao_task.h
src/stm/Makefile.defs
src/stm/ao_arch_funcs.h
src/stm/ao_eeprom_stm.c
src/stm/ao_usb_stm.c
src/stm/stm32l.h
src/stmf0/Makefile-stmf0.defs
src/stmf0/ao_adc_fast.h
src/stmf0/ao_arch_funcs.h
src/stmf0/ao_usb_stm.c
src/stmf0/stm32f0.h